[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-06-02 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1213975421 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +566,113 @@ public void testConcatOnSameFile()

[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-31 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211724811 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +566,113 @@ public void testConcatOnSameFile()

[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-31 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211643942 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +566,113 @@ public void testConcatOnSameFile()

[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-31 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211583457 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +566,113 @@ public void testConcatOnSameFile()

[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-31 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1211433782 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +566,113 @@ public void testConcatOnSameFile()

[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-24 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1204372000 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +564,36 @@ public void testConcatOnSameFile()

[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-24 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1204175628 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +564,36 @@ public void testConcatOnSameFile()

[GitHub] [hadoop] lfxy commented on a diff in pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-05-24 Thread via GitHub
lfxy commented on code in PR #5561: URL: https://github.com/apache/hadoop/pull/5561#discussion_r1204017406 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java: ## @@ -564,4 +564,36 @@ public void testConcatOnSameFile()