[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5145: HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

2022-11-21 Thread GitBox
mkuchenbecker commented on code in PR #5145: URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028385376 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/driver/TestStateStoreDriverBase.java: ## @@ -234,6 +234,25 @@ p

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5145: HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

2022-11-21 Thread GitBox
mkuchenbecker commented on code in PR #5145: URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028382408 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java: ## @@ -366,7 +375,7 @@

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5145: HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

2022-11-21 Thread GitBox
mkuchenbecker commented on code in PR #5145: URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028378298 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java: ## @@ -88,6 +88,15 @@