[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #3964: HADOOP-18104: S3A: Add configs to configure minSeekForVectorReads and maxReadSizeForVectorReads

2022-04-26 Thread GitBox
mukund-thakur commented on code in PR #3964: URL: https://github.com/apache/hadoop/pull/3964#discussion_r859104404 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -564,6 +568,23 @@ public void initialize(URI name, Configuration

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #3964: HADOOP-18104: S3A: Add configs to configure minSeekForVectorReads and maxReadSizeForVectorReads

2022-04-13 Thread GitBox
mukund-thakur commented on code in PR #3964: URL: https://github.com/apache/hadoop/pull/3964#discussion_r849909748 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractVectoredRead.java: ## @@ -19,15 +19,23 @@ package

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #3964: HADOOP-18104: S3A: Add configs to configure minSeekForVectorReads and maxReadSizeForVectorReads

2022-04-13 Thread GitBox
mukund-thakur commented on code in PR #3964: URL: https://github.com/apache/hadoop/pull/3964#discussion_r849898485 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AReadOpContext.java: ## @@ -69,17 +75,19 @@ * @param changeDetectionPolicy change detection

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #3964: HADOOP-18104: S3A: Add configs to configure minSeekForVectorReads and maxReadSizeForVectorReads

2022-04-13 Thread GitBox
mukund-thakur commented on code in PR #3964: URL: https://github.com/apache/hadoop/pull/3964#discussion_r849894430 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java: ## @@ -1066,4 +1066,29 @@ private Constants() { * Require that all S3 access

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #3964: HADOOP-18104: S3A: Add configs to configure minSeekForVectorReads and maxReadSizeForVectorReads

2022-04-13 Thread GitBox
mukund-thakur commented on code in PR #3964: URL: https://github.com/apache/hadoop/pull/3964#discussion_r849889242 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java: ## @@ -1066,4 +1066,29 @@ private Constants() { * Require that all S3 access