[GitHub] [hadoop] slfan1989 commented on pull request #5151: HADOOP-18533. RPC Client performance improvement

2022-11-20 Thread GitBox
slfan1989 commented on PR #5151: URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321285981 @huxinqiu I will deal with the problem of javadoc, we can focus on the RPC code logic. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] slfan1989 commented on pull request #5151: HADOOP-18533. RPC Client performance improvement

2022-11-20 Thread GitBox
slfan1989 commented on PR #5151: URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321142480 @huxinqiu Thank you very much for your contribution! We need to discuss something: 1. It seems that the benefit is to avoid declaring this variable `ResponseBuffer`,

[GitHub] [hadoop] slfan1989 commented on pull request #5151: HADOOP-18533. RPC Client performance improvement

2022-11-19 Thread GitBox
slfan1989 commented on PR #5151: URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321000642 @huxinqiu Can we add some unit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the