[GitHub] [hadoop] smengcl commented on pull request #2176: HDFS-15492. Make trash root inside each snapshottable directory

smengcl commented on pull request #2176: URL: https://github.com/apache/hadoop/pull/2176#issuecomment-692330196 > I'm late to this. But we should verify to make sure httpfs also behaves the sames. Otherwise it'll break Hue. hey @jojochuang, thanks for checking in! I have

[GitHub] [hadoop] smengcl commented on pull request #2176: HDFS-15492. Make trash root inside each snapshottable directory

smengcl commented on pull request #2176: URL: https://github.com/apache/hadoop/pull/2176#issuecomment-672032459 Reran the test. Much less unrelated flaky test failures now. I'm merging the closing this PR in a minute.

[GitHub] [hadoop] smengcl commented on pull request #2176: HDFS-15492. Make trash root inside each snapshottable directory

smengcl commented on pull request #2176: URL: https://github.com/apache/hadoop/pull/2176#issuecomment-670697255 I rebased the commits on to the latest trunk. Also made `dfs.namenode.snapshot.trashroot.enabled` a private config in FSNameSystem.