[GitHub] [hadoop] steveloughran commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-19 Thread via GitHub
steveloughran commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1268331301 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Soft

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-18 Thread via GitHub
steveloughran commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267028844 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java: ## @@ -17,26 +17,26 @@ */ package org.apache.hadoop.f

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-18 Thread via GitHub
steveloughran commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267026982 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java: ## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Soft

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-18 Thread via GitHub
steveloughran commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267026055 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1926,12 +1926,41 @@ enum RenameStrategy { SAME_FI

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5847: HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

2023-07-17 Thread via GitHub
steveloughran commented on code in PR #5847: URL: https://github.com/apache/hadoop/pull/5847#discussion_r1265143881 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java: ## @@ -1926,12 +1926,41 @@ enum RenameStrategy { SAME_FI