[GitHub] [hadoop] steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-06-12 Thread GitBox
steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#issuecomment-501186360 new PR is #951. Please can people review that as it is ~ready to go in and in need of criticism

[GitHub] [hadoop] steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-06-12 Thread GitBox
steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#issuecomment-501178280 closed to create a squashed one and keep yetus happy; rebase to trunk first.

[GitHub] [hadoop] steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-06-11 Thread GitBox
steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#issuecomment-501043896 I've just pushed up a new version which includes the checkstyle complaints and the various nits

[GitHub] [hadoop] steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-06-04 Thread GitBox
steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#issuecomment-498772103 thanks all for reviews, will go through them. FWIW, the latest patch has checks on dir updates if

[GitHub] [hadoop] steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-29 Thread GitBox
steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#issuecomment-496988983 unit test failures in hadoop common are unrelated; look like directory setup on test VM. ```

[GitHub] [hadoop] steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-28 Thread GitBox
steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#issuecomment-496684343 the 600 tabs are from the file `./hadoop-tools/hadoop-rumen/hs_err_pid15861.log`; not relevant

[GitHub] [hadoop] steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-28 Thread GitBox
steveloughran commented on issue #843: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/843#issuecomment-496556082 > The patch 600 line(s) with tabs. not sure what's up there. Usually its stack traces in docs,