steveloughran commented on pull request #1679:
URL: https://github.com/apache/hadoop/pull/1679#issuecomment-657531015
thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
steveloughran commented on pull request #1679:
URL: https://github.com/apache/hadoop/pull/1679#issuecomment-648147896
and some minor checkstyles
```
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MultipartUploader.java:103:
CompletableFuture abortUploadsUnd
steveloughran commented on pull request #1679:
URL: https://github.com/apache/hadoop/pull/1679#issuecomment-648147293
clearly unrelated failure
```
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
2.782 s <<< FAILURE! - in org.apache.hadoop.security.TestRace
steveloughran commented on pull request #1679:
URL: https://github.com/apache/hadoop/pull/1679#issuecomment-642640410
```
java.lang.AssertionError: 1 methods were not overridden correctly - see log
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Ass
steveloughran commented on pull request #1679:
URL: https://github.com/apache/hadoop/pull/1679#issuecomment-639086252
test s3 ireland; unguarded
faiures in ITestS3AConfiguration as expected errors didnt surface -probably
because I've disabled bucket existence checks
---
steveloughran commented on pull request #1679:
URL: https://github.com/apache/hadoop/pull/1679#issuecomment-638116319
need to rebase
This is an automated message from the Apache Git Service.
To respond to the message, please
steveloughran commented on pull request #1679:
URL: https://github.com/apache/hadoop/pull/1679#issuecomment-633044055
> also, we should let the builder take a
org.apache.hadoop.util.Progressable for regular callbacks
no: better to do that slow upload in a separate thread.
steveloughran commented on pull request #1679:
URL: https://github.com/apache/hadoop/pull/1679#issuecomment-633044192
aaron -thanks for the review. I'll do the tweaks you suggested, fix
checkstyle and once the tests are happy, merge
