[GitHub] [hadoop] steveloughran commented on pull request #2310: HADOOP-17244. S3A directory delete tombstones dir markers prematurely

2020-11-18 Thread GitBox
steveloughran commented on pull request #2310: URL: https://github.com/apache/hadoop/pull/2310#issuecomment-729677744 merged; closing This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] steveloughran commented on pull request #2310: HADOOP-17244. S3A directory delete tombstones dir markers prematurely

2020-11-17 Thread GitBox
steveloughran commented on pull request #2310: URL: https://github.com/apache/hadoop/pull/2310#issuecomment-728986329 forgot I hadn't merged this. rebase and one last run through checkstyle to shut it up before the merge

[GitHub] [hadoop] steveloughran commented on pull request #2310: HADOOP-17244. S3A directory delete tombstones dir markers prematurely

2020-10-22 Thread GitBox
steveloughran commented on pull request #2310: URL: https://github.com/apache/hadoop/pull/2310#issuecomment-714475083 Checkstyle still fussy. What a pain ``` ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:93: "Bulk

[GitHub] [hadoop] steveloughran commented on pull request #2310: HADOOP-17244. S3A directory delete tombstones dir markers prematurely

2020-10-21 Thread GitBox
steveloughran commented on pull request #2310: URL: https://github.com/apache/hadoop/pull/2310#issuecomment-713661838 java 11 javadoc and one line of whitespace. will fix This is an automated message from the Apache Git

[GitHub] [hadoop] steveloughran commented on pull request #2310: HADOOP-17244. S3A directory delete tombstones dir markers prematurely

2020-10-21 Thread GitBox
steveloughran commented on pull request #2310: URL: https://github.com/apache/hadoop/pull/2310#issuecomment-713653337 Note: did a retest with `-Dparallel-tests -DtestsThreadCount=4 -Dmarkers=keep -Ds3guard -Ddynamo -Dfs.s3a.directory.marker.audit=true -Dscale` . All good -didn't even get

[GitHub] [hadoop] steveloughran commented on pull request #2310: HADOOP-17244. S3A directory delete tombstones dir markers prematurely

2020-10-21 Thread GitBox
steveloughran commented on pull request #2310: URL: https://github.com/apache/hadoop/pull/2310#issuecomment-713555144 thanks. Resubmitting to Yetus the final rebased PR; conflict with the guava shading imports are going to be our future