[GitHub] [hadoop] steveloughran commented on pull request #4229: HADOOP-18069. okhttp@2.7.5 to 4.9.3

2022-04-26 Thread GitBox
steveloughran commented on PR #4229: URL: https://github.com/apache/hadoop/pull/4229#issuecomment-1110137354 commented. * checkstyle needs to be happy, along with javac. * spotbugs still thinks there is a problem. what is it that it is warning about? i'm worried about adding

[GitHub] [hadoop] steveloughran commented on pull request #4229: HADOOP-18069. okhttp@2.7.5 to 4.9.3

2022-04-24 Thread GitBox
steveloughran commented on PR #4229: URL: https://github.com/apache/hadoop/pull/4229#issuecomment-1107879441 the spotbugs failures are probably less a regression the lib as improved nullable declarations in the API letting spotbugs know the code is bad. that bit of okta api use needs to