[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-17 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1682615704 @mukund-thakur @mehakmeet you happy with this? we are, and once it's in I'm ready to rebase and merge to trunk -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-17 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1682611004 tested s3 london at scale; got the usual huge file multipart failure. turn off for now? also saw a transitive failure of ITestS3APrefetchingInputStream; seen that before.

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-17 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1682609014 OK, I added the setConf() feature. Means thing is potentially useful. V1 handlers get an error, as seen in the test ``` 2023-08-17 17:24:42,849 [setup] WARN

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-17 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1682558300 latest patch removed the redundant method *and* updates the auditing docs to cover the migration to the new option, plus any other updates needed. Note: storediag updated to print

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-16 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1680565367 Spotbugs is running off a version of the findbugs.xml which is not the one in the last commit. not sure how/why, but locally a call to `mvn spotbugs:check` is happy, the way it

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-14 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1677551297 HADOOP-18820. SDK v1 cut: S3AInternals move "public" s3 client api calls out of S3AFS and into a new S3AInternals interface which is implemented by a non-static inner class.

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-14 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1677351774 one more "little" bit of redesign. i want to move those entry points we expose from s3afs (client, credentials, getObjectMetadata() into a new S3AInternals API, which is what you

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-10 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1673784146 thought of one more change; add a `hadoop s3guard sdk` command to support probes for sdk version. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-07 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1667734322 good point. will skip mentioning it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-03 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1664021330 ...nice. do that as a followup to this so we isolate dependency version changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-01 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1660437266 last test run s3 london, only failure was the expected ITestS3AHugeFilesNoMultipart suite ``` -Dparallel-tests -DtestsThreadCount=8 -Dprefetch -Dscale ``` -- This

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-08-01 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1660262564 created https://issues.apache.org/jira/browse/YARN-11546 for the TestTimelineAuthFilterForV2 failure -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-07-27 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1653535263 the current pom changes means that s3 select operations fail ``` [ERROR] testReadLandsatRecordsNoMatch(org.apache.hadoop.fs.s3a.select.ITestS3SelectLandsat) Time elapsed:

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-07-26 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1652219827 hi, needs a bit more review/upvote. with this patch, we still support v1 providers if people set up the classpath, but we map the standard ones to v2 equivalents. -- This is an

[GitHub] [hadoop] steveloughran commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-07-26 Thread via GitHub
steveloughran commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1652156127 current dependency setup ``` [INFO] +- com.amazonaws:aws-java-sdk-core:jar:1.12.367:provided [INFO] | +- commons-logging:commons-logging:jar:1.1.3:provided [INFO] | +-