[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-04-24 Thread GitBox
tomscut commented on PR #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1107800632 I am sorry. I shouldn't use the same method name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-04-24 Thread GitBox
tomscut commented on PR #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1107794487 > @tomscut @ferhui @ayushtkn testExternalSPSMetrics is a duplicated function name which is already defined in TestExternalStoragePolicySatisfier.java this patch is breaking trunk build, pl

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-04-24 Thread GitBox
tomscut commented on PR #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1107791593 Thanks @ferhui and @ayushtkn . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-04-21 Thread GitBox
tomscut commented on PR #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1105917469 Thanks @ayushtkn for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-04-17 Thread GitBox
tomscut commented on PR #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1101031945 Thanks @ferhui for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-04-12 Thread GitBox
tomscut commented on PR #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1097594639 Hi @umamaheswararao @ayushtkn @tasanuma @ferhui Currently, external SPS has no metrics. We do not know the migration progress of the corresponding block, adding metrics are helpful. Cou

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-04-08 Thread GitBox
tomscut commented on PR #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1092680737 Hi @umamaheswararao @ayushtkn @tasanuma @ferhui , could you please take a look? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-04-05 Thread GitBox
tomscut commented on PR #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1088356041 Hi @umamaheswararao @ayushtkn @tasanuma @ferhui , could you please take a look? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-03-31 Thread GitBox
tomscut commented on pull request #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1084440796 Hi @ayushtkn @tasanuma @ferhui , could you please take a look? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hadoop] tomscut commented on pull request #4035: HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

2022-03-03 Thread GitBox
tomscut commented on pull request #4035: URL: https://github.com/apache/hadoop/pull/4035#issuecomment-1058839156 Hi @tasanuma @jojochuang @ferhui , could you please take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t