[GitHub] [hadoop] tomscut commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode should not trigger the edits rolling of active Namenode

2022-04-13 Thread GitBox
tomscut commented on PR #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1098634304 In summary, at this stage, should we disable OBN triggerActiveLogRoll first, or disable all SNN triggerActiveLogRoll directly? @xkrogen @sunchao I look forward to your discussion.

[GitHub] [hadoop] tomscut commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode should not trigger the edits rolling of active Namenode

2022-04-13 Thread GitBox
tomscut commented on PR #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1098630345 Thank you @xkrogen for your detailed explanation. I left out some information. You are right. I thought it was ANN automatic rolledits feature first, then discuss whether to let

[GitHub] [hadoop] tomscut commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode should not trigger the edits rolling of active Namenode

2022-04-12 Thread GitBox
tomscut commented on PR #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1097474203 > Hi @tomscut, sorry for the delay in my response. > > I am inclined to agree with @sunchao that the approach laid out in

[GitHub] [hadoop] tomscut commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode should not trigger the edits rolling of active Namenode

2022-04-05 Thread GitBox
tomscut commented on PR #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1089631143 Hi @xkrogen, could you please also take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] tomscut commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode should not trigger the edits rolling of active Namenode

2022-03-31 Thread GitBox
tomscut commented on pull request #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1084285726 > I think this is pretty similar to https://issues.apache.org/jira/browse/HDFS-14378. If I remember correctly, the better approach would be to have ANN roll its own edit logs.

[GitHub] [hadoop] tomscut commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode should not trigger the edits rolling of active Namenode

2022-03-29 Thread GitBox
tomscut commented on pull request #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1082513955 To avoid frequent edtis rolling, we should disable OBN from triggering the edits rolling of active Namenode. Hi @sunchao, please have a look at this. Thank you very

[GitHub] [hadoop] tomscut commented on pull request #4087: HDFS-16513. [SBN read] Observer Namenode should not trigger the edits rolling of active Namenode

2022-03-28 Thread GitBox
tomscut commented on pull request #4087: URL: https://github.com/apache/hadoop/pull/4087#issuecomment-1080317480 Hi @xkrogen @sunchao @tamaashu @ayushtkn @ferhui @virajjasani , please take a look at this. Thanks. -- This is an automated message from the Apache Git Service. To