tomscut commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1291347727
> @tomscut Thanks for involving me. In my case, I think this PR is
unnecessary. But we can print some warning logs to prompt the admin if the set
memory is too large, such as more than
tomscut commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1289848335
Hi @xkrogen @goiri @ZanderXu , could you please take a look? Thanks.
The unit test is unrelated to this change. It is another issue.
--
This is an automated message from the
tomscut commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1115568961
> I think this change is a bit too restrictive. There may well be valid use
cases for setting it above the 90% threshold. For example if you configured a
100GB heap, you really don't need
tomscut commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1110446887
Hi @tasanuma @ayushtkn @sunchao @xkrogen , could you please take a look.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tomscut commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1105921764
Hi @sunchao @xkrogen , could you please take a look. Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
