zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741787028
@ayushtkn
We can get back the ContainerLogAppender for CLA. But how about CRLA? If we
have to keep our old behavior, I think we can just revert HADOOP-18649.
--
This is
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741776757
@ayushtkn
Thanks for your reply. I think what you said is reasonable. We should try to
maintain old behaviour.
There are two appender for regular container log: CLA,
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741690367
@ayushtkn
Thanks for you reply! I reproduce the problem of
'testThreadDumpOnTaskTimeout' in my laptop. Here we can see the log dir:
```
(base)
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741619676
> Another observation, the day this PR was reverted, some tests which were
broken since eternity broke again.
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741613920
@ayushtkn @virajjasani
In my opinion, I think CLA should use FileAppender, and CRLA should use
RollingFileAppender.
FileAppender will disable the cap. Then CRLA will
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741612979
> ```
> 0 disables the cap.
> ```
@ayushtkn Thanks for you reply!
log4j.appender.CLA change s from
'org.apache.hadoop.yarn.ContainerLogAppender' to
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741028712
@virajjasani Thanks for your reply.
For CLA before HADOOP-18649:
CLA is org.apache.hadoop.yarn.ContainerLogAppender which is extend from
FileAppender.
In default,
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1736556764
@jojochuang @virajjasani @ayushtkn Can you please review this PR?
I think this PR should be merged into next release. In default, for trunk,
only show the latest line log. It
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1726712035
@ayushtkn
https://github.com/apache/hadoop/pull/6042 was reverted. Can you please
review this PR?
And I still think we should change the default value.
I found that before
