Re: [PR] HADOOP-18889. use getDuration() on http connection settings [hadoop]

2023-10-21 Thread via GitHub
hadoop-yetus commented on PR #6180: URL: https://github.com/apache/hadoop/pull/6180#issuecomment-1773895787 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18889. use getDuration() on http connection settings [hadoop]

2023-10-17 Thread via GitHub
virajjasani commented on code in PR #6180: URL: https://github.com/apache/hadoop/pull/6180#discussion_r1363235836 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSClientConfig.java: ## @@ -378,17 +388,39 @@ private static void initSigner(Configuration

Re: [PR] HADOOP-18889. use getDuration() on http connection settings [hadoop]

2023-10-17 Thread via GitHub
virajjasani commented on code in PR #6180: URL: https://github.com/apache/hadoop/pull/6180#discussion_r1363203939 ## hadoop-common-project/hadoop-common/src/main/resources/core-default.xml: ## @@ -1596,14 +1596,15 @@ fs.s3a.connection.establish.timeout - 5000 - Socket

Re: [PR] HADOOP-18889. use getDuration() on http connection settings [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6180: URL: https://github.com/apache/hadoop/pull/6180#issuecomment-1760389977 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HADOOP-18889. use getDuration() on http connection settings [hadoop]

2023-10-12 Thread via GitHub
steveloughran opened a new pull request, #6180: URL: https://github.com/apache/hadoop/pull/6180 Default time unit for all values is milliseconds ### How was this patch tested? testing in progress ### For code changes: - [ ] Does the title or this PR starts