steveloughran merged PR #6465:
URL: https://github.com/apache/hadoop/pull/6465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
steveloughran commented on PR #6465:
URL: https://github.com/apache/hadoop/pull/6465#issuecomment-1932193942
Ready to go in; reviews welcome.
@ahmarsuhail @mukund-thakur @HarshitGupta11
--
This is an automated message from the Apache Git Service.
To respond to the message, please
hadoop-yetus commented on PR #6465:
URL: https://github.com/apache/hadoop/pull/6465#issuecomment-1902752372
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on PR #6465:
URL: https://github.com/apache/hadoop/pull/6465#issuecomment-1902727835
applied my own review comments; tested against s3 express in usw2 with and
without -prefetch
--
This is an automated message from the Apache Git Service.
To respond to the
steveloughran commented on code in PR #6465:
URL: https://github.com/apache/hadoop/pull/6465#discussion_r1459580119
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java:
##
@@ -161,7 +171,11 @@ public void
hadoop-yetus commented on PR #6465:
URL: https://github.com/apache/hadoop/pull/6465#issuecomment-1898531150
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6465:
URL: https://github.com/apache/hadoop/pull/6465#issuecomment-1898520977
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6460:
URL: https://github.com/apache/hadoop/pull/6460#issuecomment-1896682323
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran opened a new pull request, #6460:
URL: https://github.com/apache/hadoop/pull/6460
This is actually trickier than it seems as we will need to go deep into the
implementation of caching.
Specifically: the prefetcher knows the file length and if you open a file
