Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-03-06 Thread via GitHub
hfutatzhanghb commented on PR #6475: URL: https://github.com/apache/hadoop/pull/6475#issuecomment-1980485362 @zhangshuyan0 Sir, Thanks a lot for your reviewing and merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-03-06 Thread via GitHub
zhangshuyan0 commented on PR #6475: URL: https://github.com/apache/hadoop/pull/6475#issuecomment-1980384103 Committed to trunk. Thanks for your contribution @hfutatzhanghb . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-03-06 Thread via GitHub
zhangshuyan0 merged PR #6475: URL: https://github.com/apache/hadoop/pull/6475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-01-31 Thread via GitHub
hadoop-yetus commented on PR #6475: URL: https://github.com/apache/hadoop/pull/6475#issuecomment-1919838617 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-01-31 Thread via GitHub
hfutatzhanghb commented on PR #6475: URL: https://github.com/apache/hadoop/pull/6475#issuecomment-1918964658 @Hexiaoqiao @zhangshuyan0 @tomscut Hi, sir. Could you please help me review this code when you are free ? Thanks! -- This is an automated message from the Apache Git Service. To

Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-01-21 Thread via GitHub
hadoop-yetus commented on PR #6475: URL: https://github.com/apache/hadoop/pull/6475#issuecomment-1902552730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-01-20 Thread via GitHub
hfutatzhanghb opened a new pull request, #6475: URL: https://github.com/apache/hadoop/pull/6475 ### Description of PR HDFS-17345. Currently, we have block report send time metrics recorded by blockReports. We should better add another metric to record block report creating cost