hfutatzhanghb commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2081853953
> @hfutatzhanghb As discussed above (which is also confirmed by
@zhangshuyan0), It is unsafe to remove BP lock here, just close this PR. Please
feel free to reopen it if there is
Hexiaoqiao closed pull request #6717: HDFS-17458. Remove unnecessary BP lock in
ReplicaMap.
URL: https://github.com/apache/hadoop/pull/6717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Hexiaoqiao commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2081852396
@hfutatzhanghb As discussed above (which is also confirmed by
@zhangshuyan0), It is unsafe to remove BP lock here, just close this PR. Please
feel free to reopen it if there is one
hadoop-yetus commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2074182504
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
_ Prechecks
zhangshuyan0 commented on code in PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#discussion_r1565660296
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java:
##
@@ -120,15 +118,13 @@ ReplicaInfo
hadoop-yetus commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049744473
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049700613
> @hfutatzhanghb Thanks for your works. We should be careful to remove BP
lock here. List one of the changes as example, it will return one definite
value before this PR because
hadoop-yetus commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049462537
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Hexiaoqiao commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049395174
@hfutatzhanghb Thanks for your works. We should be careful to remove BP lock
here. List one of the changes as example, it will return one definite value
before this PR because hold RW
hadoop-yetus commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049035589
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2049008972
@Hexiaoqiao @zhangshuyan0 @tomscut Sir, could you please take a look at
this PR when you have free time? Thanks a lot.
--
This is an automated message from the Apache Git
hadoop-yetus commented on PR #6717:
URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2047785996
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hfutatzhanghb opened a new pull request, #6717:
URL: https://github.com/apache/hadoop/pull/6717
### Description of PR
In [HDFS-16429](https://issues.apache.org/jira/browse/HDFS-16429) we make
LightWeightResizableGSet to be thread safe, and in
13 matches
Mail list logo
