Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

slfan1989 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1786176603 @mudit1289 Thank you very much for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

slfan1989 merged PR #6155: URL: https://github.com/apache/hadoop/pull/6155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1783751747 @slfan1989 , retriggered the build and it is successful, please merge when available -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1783751290 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1782986697 @slfan1989 , actually I do not have access to jenkins to retrigger it, can you please do it -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

slfan1989 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1782976936 > @slfan1989 , can we merge this? @mudit1289 Thank you for your contribution! Can we trigger jenkins compilation again? After this compilation, we will merge this pr. --

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1778497256 @slfan1989 , can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1774142907 @slfan1989 , check style issues are resolved now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1774142443 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

slfan1989 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1774103988 > @slfan1989 , can we merge this if this looks fine? LGTM, we need to fix the checkstyle issue. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1773878871 @slfan1989 , can we merge this if this looks fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1773864717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1771610859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1771606389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1771548389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on code in PR #6155: URL: https://github.com/apache/hadoop/pull/6155#discussion_r1365889906 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestMapTask.java: ## @@ -84,4 +93,77 @@ public

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

slfan1989 commented on code in PR #6155: URL: https://github.com/apache/hadoop/pull/6155#discussion_r1365884610 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestMapTask.java: ## @@ -84,4 +93,77 @@ public

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

slfan1989 commented on code in PR #6155: URL: https://github.com/apache/hadoop/pull/6155#discussion_r1365883869 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/MapTask.java: ## @@ -984,10 +987,16 @@ public v

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1765643608 @slfan1989 , bump, please check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1761375332 @slfan1989 , did you get a chance to go through this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1756929923 sure, @slfan1989 thanks for the comment, also I have assumed that code for writing new spills is present in only MapTask class, please let me know if we spill data from some other flow a

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

slfan1989 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1756479420 > @slfan1989 can you please review or tag relevant folks if possible @mudit1289 Thank you for your contribution! I will read this PR in the next 1-2 days. Sorry for the delayed res

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1752094060 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1752092732 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1752052299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1752029497 @slfan1989 can you please review or tag relevant folks if possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1752014752 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1751973241 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1751921208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1751842691 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1751803742 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1751750617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

hadoop-yetus commented on PR #6155: URL: https://github.com/apache/hadoop/pull/6155#issuecomment-1751261943 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] MAPREDUCE-7457: Added support to limit count of spill files [hadoop]

mudit1289 opened a new pull request, #6155: URL: https://github.com/apache/hadoop/pull/6155 https://issues.apache.org/jira/browse/MAPREDUCE-7457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th