Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-25 Thread via GitHub
slfan1989 commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1780232786 @goiri Thank you very much for your help in reviewing the code! I will continue to follow up on YARN-11594. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-25 Thread via GitHub
slfan1989 merged PR #6199: URL: https://github.com/apache/hadoop/pull/6199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-23 Thread via GitHub
slfan1989 commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1775505072 @goiri Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-22 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1774158476 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-21 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1773872937 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-20 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1773096949 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-20 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1772574582 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-20 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1772280778 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-19 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1771749746 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1771406631 @goiri Can you help review this PR again? Thank you very much! I improved the code to make it more readable. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6199: URL: https://github.com/apache/hadoop/pull/6199#discussion_r1365864346 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java: ## @@ -159,43 +214,59 @@ public RouterCLI(Configu

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-19 Thread via GitHub
slfan1989 commented on code in PR #6199: URL: https://github.com/apache/hadoop/pull/6199#discussion_r1365863997 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java: ## @@ -77,25 +79,70 @@ public class RouterCLI ext

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
slfan1989 commented on code in PR #6199: URL: https://github.com/apache/hadoop/pull/6199#discussion_r1364784350 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java: ## @@ -77,25 +79,70 @@ public class RouterCLI ext

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
goiri commented on code in PR #6199: URL: https://github.com/apache/hadoop/pull/6199#discussion_r1364211542 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java: ## @@ -77,25 +79,70 @@ public class RouterCLI extends

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1768853213 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1768713789 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1768559175 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1767831358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-17 Thread via GitHub
hadoop-yetus commented on PR #6199: URL: https://github.com/apache/hadoop/pull/6199#issuecomment-1767779573 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] YARN-11593. [Federation] Improve command line help information. [hadoop]

2023-10-17 Thread via GitHub
slfan1989 opened a new pull request, #6199: URL: https://github.com/apache/hadoop/pull/6199 ### Description of PR JIRA: YARN-11593. [Federation] Improve command line help information. ### How was this patch tested? ### For code changes: - [ ] Does the t