[ https://issues.apache.org/jira/browse/HADOOP-15798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696146#comment-16696146 ]
Gabor Bota edited comment on HADOOP-15798 at 11/22/18 5:32 PM: --------------------------------------------------------------- The fast and dirty fix would be to add {code:java} if(meta.isDeleted()) { parentMeta.getDirListingMeta().markDeleted(path); } {code} to {{LocalMetadataStore.java:281}} else branch, but I'd prefer a solution which is more versatile: add a new {{put}} method to {{DirListingMetadata}} with {{PathMetadata}} parameter type. This way we could add PathMetadata instead of just a FileStatus, so additional parameters like isDeleted could be set automatically and we could avoid problems like this. Currently running the tests, will report back soon. was (Author: gabor.bota): The fast and dirty fix would be to add {code:java} if(meta.isDeleted()) { parentMeta.getDirListingMeta().markDeleted(path); } {code} to {{LocalMetadataStore.java:281}} else branch, but I'd prefer a solution which is more versatile: add a new {{put}} method to {{DirListingMetadata}} with {{PathMetadata}} parameter type. This way we could add PathMetadata instead of just a FileStatus, so additional parameters like isDeleted could be set and we could avoid problems like this. Currently running the tests, will report back soon. > ITestS3GuardListConsistency#testConsistentListAfterDelete failing with > LocalMetadataStore > ----------------------------------------------------------------------------------------- > > Key: HADOOP-15798 > URL: https://issues.apache.org/jira/browse/HADOOP-15798 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.1.1 > Reporter: Gabor Bota > Assignee: Gabor Bota > Priority: Minor > > Test fails constantly when running with LocalMetadataStore. > {noformat} > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at org.junit.Assert.assertFalse(Assert.java:74) > at > org.apache.hadoop.fs.s3a.ITestS3GuardListConsistency.testConsistentListAfterDelete(ITestS3GuardListConsistency.java:205) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org