[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778680#comment-16778680
]
Yongjun Zhang commented on HADOOP-12909:
Hi [~xiaobingo],
Thanks for your work here. One
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229768#comment-15229768
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
> ... Actually, there aren't any visibility
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229762#comment-15229762
]
Hudson commented on HADOOP-12909:
-
FAILURE: Integrated in Hadoop-trunk-Commit #9575 (See
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229714#comment-15229714
]
Hadoop QA commented on HADOOP-12909:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227351#comment-15227351
]
Xiaobing Zhou commented on HADOOP-12909:
v009 is posted by adding tests for asynchronous case
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222024#comment-15222024
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
> ... The benefit of TestAsyncIPC extending
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220560#comment-15220560
]
Hadoop QA commented on HADOOP-12909:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220399#comment-15220399
]
Xiaobing Zhou commented on HADOOP-12909:
Patch v008 addressed all your latest comments except
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219698#comment-15219698
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
Some more comments for TestAsyncIPC:
-
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219438#comment-15219438
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
- It seems that we could simply return null
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218874#comment-15218874
]
Xiaobing Zhou commented on HADOOP-12909:
Thanks [~szetszwo], v007 removed @Unstable and changed
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217948#comment-15217948
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
- The parameter type in
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215902#comment-15215902
]
Steve Loughran commented on HADOOP-12909:
-
OK, let Sanjay comment; I have no objections to the
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214932#comment-15214932
]
Xiaobing Zhou commented on HADOOP-12909:
I posted v006 to fix your comments thanks
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211745#comment-15211745
]
Steve Loughran commented on HADOOP-12909:
-
I'll let sanjay handle the architectural issues.
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209655#comment-15209655
]
Hadoop QA commented on HADOOP-12909:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209312#comment-15209312
]
Xiaobing Zhou commented on HADOOP-12909:
bq. I was proposing having separate sync and async
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209292#comment-15209292
]
Xiaobing Zhou commented on HADOOP-12909:
Thanks [~sanjay.radia] for the comment. To avoid buffer
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209191#comment-15209191
]
Steve Loughran commented on HADOOP-12909:
-
I was proposing having separate sync and async
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207906#comment-15207906
]
Hadoop QA commented on HADOOP-12909:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207616#comment-15207616
]
Xiaobing Zhou commented on HADOOP-12909:
[~wheat9] looks like gRPC is still in early stage, we
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207608#comment-15207608
]
Xiaobing Zhou commented on HADOOP-12909:
I posted patch V004 that fixed test/code issues
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206117#comment-15206117
]
Steve Loughran commented on HADOOP-12909:
-
well, there's google's track record in backwards
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205710#comment-15205710
]
Haohui Mai commented on HADOOP-12909:
-
I'm concerned about the complexity and the effort to support
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204895#comment-15204895
]
Xiaobing Zhou commented on HADOOP-12909:
[~steve_l] I am not clear for this when you said 'could
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204887#comment-15204887
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
BTW, the current patch aligns with the
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204880#comment-15204880
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
bq. ... I know it's not easy with some
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204834#comment-15204834
]
Xiaobing Zhou commented on HADOOP-12909:
[~steve_l] why is the thread-local (i.e.
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204595#comment-15204595
]
Sanjay Radia commented on HADOOP-12909:
---
I haven't had a chance to look at the patch or review all
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204031#comment-15204031
]
Steve Loughran commented on HADOOP-12909:
-
I don't know of any easy way, though this could be an
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203481#comment-15203481
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
One more comment: the get() method should
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200187#comment-15200187
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
The new patch looks great! I like the idea
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203042#comment-15203042
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
> V003 fixed issues you mentioned, ...
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203039#comment-15203039
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
> ... Is there any cleaner way to do it?
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202966#comment-15202966
]
Steve Loughran commented on HADOOP-12909:
-
At first I thought this wasn't thread-safe, but it's
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198771#comment-15198771
]
Xiaobing Zhou commented on HADOOP-12909:
[~szetszwo] thanks for review. The patch V002 covered
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202643#comment-15202643
]
Hadoop QA commented on HADOOP-12909:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202612#comment-15202612
]
Xiaobing Zhou commented on HADOOP-12909:
V003 fixed issues you mentioned, thanks [~szetszwo].
>
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199205#comment-15199205
]
Hadoop QA commented on HADOOP-12909:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196700#comment-15196700
]
Hadoop QA commented on HADOOP-12909:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194662#comment-15194662
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
[~xiaobingo], thanks for posting a patch.
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194570#comment-15194570
]
Hadoop QA commented on HADOOP-12909:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194352#comment-15194352
]
Xiaobing Zhou commented on HADOOP-12909:
I posted the initial patch V000 for review, thanks.
>
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193894#comment-15193894
]
Tsz Wo Nicholas Sze commented on HADOOP-12909:
--
[~sseth], could you update your patch in
[
https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190172#comment-15190172
]
Siddharth Seth commented on HADOOP-12909:
-
There are potential problems with supporting client
45 matches
Mail list logo
