[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677632#comment-15677632
]
Aaron Fabbri commented on HADOOP-13651:
---
Sorry I just noticed your question. I just committed
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677627#comment-15677627
]
Aaron Fabbri commented on HADOOP-13651:
---
Committed to HADOOP-13345 branch. Thank you everyone who
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677545#comment-15677545
]
Hadoop QA commented on HADOOP-13651:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677461#comment-15677461
]
Mingliang Liu commented on HADOOP-13651:
+1
Thanks for the contribution. This is one of the
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676871#comment-15676871
]
Steve Loughran commented on HADOOP-13651:
-
+1 for into the feature branch
Before pulling it
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675307#comment-15675307
]
Lei (Eddy) Xu commented on HADOOP-13651:
This patch is in good shape now. Thanks for the good
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15673327#comment-15673327
]
Steve Loughran commented on HADOOP-13651:
-
the MiniYarnCluster is HADOOP-13801; need to spend
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671273#comment-15671273
]
Aaron Fabbri commented on HADOOP-13651:
---
On v6 patch, all unit tests pass. Ran integration tests
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671105#comment-15671105
]
Aaron Fabbri commented on HADOOP-13651:
---
Ok thanks.. And I should have put an asterisk next to
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669967#comment-15669967
]
Steve Loughran commented on HADOOP-13651:
-
# yes, just a comment "tested against s3 ireland"
#
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669911#comment-15669911
]
Steve Loughran commented on HADOOP-13651:
-
# yes, just a comment "tested against s3 ireland"
#
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668664#comment-15668664
]
Aaron Fabbri commented on HADOOP-13651:
---
Thanks for the good review [~steve_l].
Two questions:
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647718#comment-15647718
]
Steve Loughran commented on HADOOP-13651:
-
LGTM
bq. All integration tests pass (except for a
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647102#comment-15647102
]
Hadoop QA commented on HADOOP-13651:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635887#comment-15635887
]
Steve Loughran commented on HADOOP-13651:
-
Given that nothing is in trunk, just do a merge
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635275#comment-15635275
]
Aaron Fabbri commented on HADOOP-13651:
---
I will address above pre-commit issues after I get the
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634380#comment-15634380
]
Hadoop QA commented on HADOOP-13651:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625300#comment-15625300
]
Steve Loughran commented on HADOOP-13651:
-
..regarding the isEmptyDir logic, if you have a plan
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625286#comment-15625286
]
Steve Loughran commented on HADOOP-13651:
-
bq. What needs to be done before we can commit this
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625235#comment-15625235
]
Steve Loughran commented on HADOOP-13651:
-
# I've actually been talking with [~rajesh.balamohan]
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624188#comment-15624188
]
Aaron Fabbri commented on HADOOP-13651:
---
Following up your security comments,
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623076#comment-15623076
]
Aaron Fabbri commented on HADOOP-13651:
---
Great comments, thank you.
{quote}
Wrap with a
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623010#comment-15623010
]
Steve Loughran commented on HADOOP-13651:
-
That test setup would work: one s3aFS using the MD
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622984#comment-15622984
]
Steve Loughran commented on HADOOP-13651:
-
comments on patch 003
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622969#comment-15622969
]
Lei (Eddy) Xu commented on HADOOP-13651:
To make the test deterministic, I was thinking that we
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622912#comment-15622912
]
Steve Loughran commented on HADOOP-13651:
-
+1 with an instance per FS instance. S3A FS instances
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622860#comment-15622860
]
Steve Loughran commented on HADOOP-13651:
-
bq. can not reliability test eventual consistency
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620602#comment-15620602
]
Chris Nauroth commented on HADOOP-13651:
bq. I'll go study the FileSystem cache now (i.e. does
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616734#comment-15616734
]
Mingliang Liu commented on HADOOP-13651:
{quote}
this relationship is carried through into the
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616733#comment-15616733
]
Aaron Fabbri commented on HADOOP-13651:
---
Thanks for comments [~cnauroth]!
{quote}
would like to
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616699#comment-15616699
]
Chris Nauroth commented on HADOOP-13651:
Hello [~fabbri]. Thank you for sharing your patch.
I
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613780#comment-15613780
]
Aaron Fabbri commented on HADOOP-13651:
---
Thanks [~eddyxu]. I will post a new patch here shortly.
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610185#comment-15610185
]
Lei (Eddy) Xu commented on HADOOP-13651:
Hi, [~liuml07] and [~fabbri]
[~fabbri] and I had an
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606983#comment-15606983
]
Aaron Fabbri commented on HADOOP-13651:
---
Hey [~eddyxu], thank you for the thorough review!
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606749#comment-15606749
]
Lei (Eddy) Xu commented on HADOOP-13651:
Hi, [~fabbri]
Thanks for posting this missing and
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595749#comment-15595749
]
Aaron Fabbri commented on HADOOP-13651:
---
Quick update: I have all but one of the unit and
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563782#comment-15563782
]
Aaron Fabbri commented on HADOOP-13651:
---
Minor status update, since this JIRA has a long gestation
[
https://issues.apache.org/jira/browse/HADOOP-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517812#comment-15517812
]
Aaron Fabbri commented on HADOOP-13651:
---
Noticed we don't appear to have a JIRA for the
38 matches
Mail list logo
