[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651744#comment-15651744
]
Grant Sohn commented on HADOOP-13802:
-
[~liuml07], thanks for your help getting this in.
> Make
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649256#comment-15649256
]
Hudson commented on HADOOP-13802:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10792 (See
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649195#comment-15649195
]
Hadoop QA commented on HADOOP-13802:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648989#comment-15648989
]
Grant Sohn commented on HADOOP-13802:
-
Code change only reformatting text, does not require a test.
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648691#comment-15648691
]
Hadoop QA commented on HADOOP-13802:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648517#comment-15648517
]
Grant Sohn commented on HADOOP-13802:
-
Fixed.
> Make generic options help more consistent, and
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647252#comment-15647252
]
Akira Ajisaka commented on HADOOP-13802:
Agreed.
> Make generic options help more consistent,
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646689#comment-15646689
]
Grant Sohn commented on HADOOP-13802:
-
Would it okay, I replace the '\n' with println() instead?
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646136#comment-15646136
]
Akira Ajisaka commented on HADOOP-13802:
Mostly looks good to me.
Would you replace {{\n}} with
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645532#comment-15645532
]
Hadoop QA commented on HADOOP-13802:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645417#comment-15645417
]
Hadoop QA commented on HADOOP-13802:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645217#comment-15645217
]
Mingliang Liu commented on HADOOP-13802:
{code}
out.println("bin/hadoop command
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645142#comment-15645142
]
Grant Sohn commented on HADOOP-13802:
-
I'll try to add one shortly.
> Make generic options help
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645072#comment-15645072
]
Mingliang Liu commented on HADOOP-13802:
Do you mind providing a patch? I can review/commit this
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645059#comment-15645059
]
Mingliang Liu commented on HADOOP-13802:
{quote}
My only nit on this is adding the ":" at the
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645055#comment-15645055
]
Grant Sohn commented on HADOOP-13802:
-
That was a mistake on my part. Here is the corrected
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645041#comment-15645041
]
Mingliang Liu commented on HADOOP-13802:
The format looks pretty good.
Are we removing
{code}
17 matches
Mail list logo