[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852792#comment-15852792
]
Steve Loughran commented on HADOOP-13876:
-
bq. shouldn't you be at a pub at this hour.. or maybe
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852453#comment-15852453
]
Aaron Fabbri commented on HADOOP-13876:
---
Committed to feature branch. Big thanks to
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852436#comment-15852436
]
Hadoop QA commented on HADOOP-13876:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852099#comment-15852099
]
Aaron Fabbri commented on HADOOP-13876:
---
#1 thanks very much for the review. I'm happy to change
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852086#comment-15852086
]
Steve Loughran commented on HADOOP-13876:
-
LGTM.
+1
two minor niggles, but not enough to
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848840#comment-15848840
]
Aaron Fabbri commented on HADOOP-13876:
---
[~ste...@apache.org] I think I addressed everything here.
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847825#comment-15847825
]
Aaron Fabbri commented on HADOOP-13876:
---
v4 patch tested in US West 2. No new failures, so I
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15844062#comment-15844062
]
Steve Loughran commented on HADOOP-13876:
-
* log4j diffs are presumambly unintentional; leave
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843787#comment-15843787
]
Hadoop QA commented on HADOOP-13876:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843751#comment-15843751
]
Aaron Fabbri commented on HADOOP-13876:
---
Same test results as before (those three failures.. note
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840294#comment-15840294
]
Hadoop QA commented on HADOOP-13876:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840264#comment-15840264
]
Aaron Fabbri commented on HADOOP-13876:
---
[~ste...@apache.org], I propose we get your patch for
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837550#comment-15837550
]
Steve Loughran commented on HADOOP-13876:
-
LGTM
+1
This'll break any existing tables; they
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837512#comment-15837512
]
Steve Loughran commented on HADOOP-13876:
-
I'll look at this —thank you for putting in all the
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832317#comment-15832317
]
Aaron Fabbri commented on HADOOP-13876:
---
Done.. Feel free to tweak descriptions, etc.
> S3Guard:
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832303#comment-15832303
]
Aaron Fabbri commented on HADOOP-13876:
---
Ok, I will clone this and create a new one that covers
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832272#comment-15832272
]
Steve Loughran commented on HADOOP-13876:
-
well, the .patch file here was really about fixing
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832132#comment-15832132
]
Aaron Fabbri commented on HADOOP-13876:
---
I'm fine with your proposal for config here.
{quote}
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831590#comment-15831590
]
Steve Loughran commented on HADOOP-13876:
-
That's going to be a separate topic. Looking at this
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830928#comment-15830928
]
Aaron Fabbri commented on HADOOP-13876:
---
Thanks [~steve_l].
I agree that most of this is
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828126#comment-15828126
]
Steve Loughran commented on HADOOP-13876:
-
Cancelling patch and marking as dependent on
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818281#comment-15818281
]
Steve Loughran commented on HADOOP-13876:
-
we can just add it to core-site.xml and have it
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816224#comment-15816224
]
Mingliang Liu commented on HADOOP-13876:
Thanks [~ste...@apache.org] for clarifying the case. I
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815025#comment-15815025
]
Steve Loughran commented on HADOOP-13876:
-
I like the docs, but as stated: we don't need this
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813187#comment-15813187
]
Hadoop QA commented on HADOOP-13876:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811816#comment-15811816
]
Steve Loughran commented on HADOOP-13876:
-
This will also surface on a {{-Dscale}} test run, as
26 matches
Mail list logo
