[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895214#comment-15895214
]
Aaron Fabbri commented on HADOOP-14129:
---
[~liuml07] yes, v5 LGTM. +1
> ITestS3ACredentialsInURL
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895196#comment-15895196
]
Mingliang Liu commented on HADOOP-14129:
[~fabbri] is your vote valid for v5 patch as well?
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893307#comment-15893307
]
Hadoop QA commented on HADOOP-14129:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893205#comment-15893205
]
Mingliang Liu commented on HADOOP-14129:
Thanks [~fabbri] for your review. I believe not. I'll
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893217#comment-15893217
]
Hadoop QA commented on HADOOP-14129:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893177#comment-15893177
]
Aaron Fabbri commented on HADOOP-14129:
---
+1 on v4 patch. One minor question:
{code}
@@ -85,8
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892081#comment-15892081
]
Steve Loughran commented on HADOOP-14129:
-
Does that sysprop need to be restored after?
>
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891679#comment-15891679
]
Hadoop QA commented on HADOOP-14129:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889313#comment-15889313
]
Mingliang Liu commented on HADOOP-14129:
I just re-produced the same error...
{code}
Tests run:
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1599#comment-1599
]
Mingliang Liu commented on HADOOP-14129:
+1 on v2 patch. Committed to feature branch. Thanks for
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1581#comment-1581
]
Hadoop QA commented on HADOOP-14129:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1522#comment-1522
]
Aaron Fabbri commented on HADOOP-14129:
---
{code}
+LOG.error("IMPL: " + impl);
{code}
Did you
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888283#comment-15888283
]
Hadoop QA commented on HADOOP-14129:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886765#comment-15886765
]
Mingliang Liu commented on HADOOP-14129:
It fails to me as well. I +1 to fix it by assuming no
14 matches
Mail list logo
