[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-23 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061643#comment-16061643 ] Sean Mackrory commented on HADOOP-14499: Filed HADOOP-14585 for that, as it's unrelated to the

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-23 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060937#comment-16060937 ] Steve Loughran commented on HADOOP-14499: - temp files work on a shared FS. AWS is actually

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-22 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059709#comment-16059709 ] Sean Mackrory commented on HADOOP-14499: Just noticed there are actually 2 findbugs entries, and

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059633#comment-16059633 ] Hadoop QA commented on HADOOP-14499: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-22 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059124#comment-16059124 ] Steve Loughran commented on HADOOP-14499: - bear in mind that we can't guarantee that the clocks

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-21 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058469#comment-16058469 ] Aaron Fabbri commented on HADOOP-14499: --- Yeah sorry for delay responding to your earlier comment.

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-21 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058397#comment-16058397 ] Sean Mackrory commented on HADOOP-14499: That's from my comment on Jun 8th. Since we currently

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-21 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058374#comment-16058374 ] Aaron Fabbri commented on HADOOP-14499: --- Hey [~mackrorysd], thank you for the patch. Can you

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-21 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058021#comment-16058021 ] Steve Loughran commented on HADOOP-14499: - My IDE says that {{ancestors}} is the only unused

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-21 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057721#comment-16057721 ] Sean Mackrory commented on HADOOP-14499: I'm really quite mystified by that findbugs continuing

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056591#comment-16056591 ] Hadoop QA commented on HADOOP-14499: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-16 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051690#comment-16051690 ] Steve Loughran commented on HADOOP-14499: - We should have the local version match the remote

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-15 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050600#comment-16050600 ] Steve Loughran commented on HADOOP-14499: - FWIW, the findbugs change is from HADOOP-14316 >

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-08 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043602#comment-16043602 ] Sean Mackrory commented on HADOOP-14499: Well the idea behind prune is to not store metadata

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-08 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043139#comment-16043139 ] Steve Loughran commented on HADOOP-14499: - yeah, shouldn't we be keeping dirs until they are

[jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore

2017-06-07 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042079#comment-16042079 ] Aaron Fabbri commented on HADOOP-14499: --- I feel like we need to define prune() semantics a little