[jira] [Commented] (HADOOP-14627) Enable new features of ADLS SDK (MSI, Device Code auth)

2017-07-11 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082960#comment-16082960 ] John Zhuge commented on HADOOP-14627: - Add {{fs.adl.oauth2.msi.port}} with default value to

[jira] [Commented] (HADOOP-14627) Enable new features of ADLS SDK (MSI, Device Code auth)

2017-07-06 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076950#comment-16076950 ] John Zhuge commented on HADOOP-14627: - [~ASikaria] It does not hurt to call ```getPaswordString```

[jira] [Commented] (HADOOP-14627) Enable new features of ADLS SDK (MSI, Device Code auth)

2017-07-06 Thread Atul Sikaria (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076836#comment-16076836 ] Atul Sikaria commented on HADOOP-14627: --- Thanks [~ste...@apache.org] for reviewing. Will do a

[jira] [Commented] (HADOOP-14627) Enable new features of ADLS SDK (MSI, Device Code auth)

2017-07-06 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076496#comment-16076496 ] Steve Loughran commented on HADOOP-14627: - * A test would still be good, if just to verify that

[jira] [Commented] (HADOOP-14627) Enable new features of ADLS SDK (MSI, Device Code auth)

2017-07-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075706#comment-16075706 ] Mingliang Liu commented on HADOOP-14627: Current change is good. I just propose the general

[jira] [Commented] (HADOOP-14627) Enable new features of ADLS SDK (MSI, Device Code auth)

2017-07-05 Thread Atul Sikaria (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075698#comment-16075698 ] Atul Sikaria commented on HADOOP-14627: --- Thanks [~liuml07], I thought about that too. However, I

[jira] [Commented] (HADOOP-14627) Enable new features of ADLS SDK (MSI, Device Code auth)

2017-07-05 Thread Mingliang Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075640#comment-16075640 ] Mingliang Liu commented on HADOOP-14627: If there are multiple changes that are separable, we