[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283081#comment-16283081
]
Xiao Chen commented on HADOOP-14872:
Cherry-picked to branch-2 and branch-3.0
> CryptoInputStream
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277409#comment-16277409
]
Xiao Chen commented on HADOOP-14872:
FYI - I plan to backport this to branch-2 and branch-3.0 if no
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246199#comment-16246199
]
John Zhuge commented on HADOOP-14872:
-
Ran "test-patch" locally and got all +1s except these
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241596#comment-16241596
]
Xiao Chen commented on HADOOP-14872:
+1 from me too.
Thanks John and Steve!
> CryptoInputStream
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240680#comment-16240680
]
Steve Loughran commented on HADOOP-14872:
-
LGTM
+1
> CryptoInputStream should implement
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215175#comment-16215175
]
Steve Loughran commented on HADOOP-14872:
-
LGTM. Once this is in and I get back to defining
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211366#comment-16211366
]
John Zhuge commented on HADOOP-14872:
-
The changes can be divided into 2 independent groups:
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211349#comment-16211349
]
Xiao Chen commented on HADOOP-14872:
I'm okay to not add the 1-sentence explanations here.
Patch is
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210786#comment-16210786
]
Steve Loughran commented on HADOOP-14872:
-
Oh, it's not so big. Sorry I've not had time to look
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210647#comment-16210647
]
John Zhuge commented on HADOOP-14872:
-
[~xiaochen] Thanks for the review!
The patches are getting
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208272#comment-16208272
]
Xiao Chen commented on HADOOP-14872:
Thanks for the continued work on this John. My belated review,
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195613#comment-16195613
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195564#comment-16195564
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195289#comment-16195289
]
Hadoop QA commented on HADOOP-14872:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192604#comment-16192604
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192426#comment-16192426
]
John Zhuge commented on HADOOP-14872:
-
Reproduced TestHdfsCryptoStreams failure on my Mac with
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192301#comment-16192301
]
John Zhuge commented on HADOOP-14872:
-
TestKDiag and TestDataNodeVolumeFailure failures are known
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192264#comment-16192264
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191173#comment-16191173
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191140#comment-16191140
]
Steve Loughran commented on HADOOP-14872:
-
I don't really mind the enum, it's a nice way to keep
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185676#comment-16185676
]
Steve Loughran commented on HADOOP-14872:
-
We need to handle capabilities which aren't defined
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184893#comment-16184893
]
John Zhuge commented on HADOOP-14872:
-
What if hasCapability is called with the name of the enum,
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184098#comment-16184098
]
Steve Loughran commented on HADOOP-14872:
-
LGTM +1,
can you cut the extra blank line added to
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183839#comment-16183839
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183202#comment-16183202
]
Xiao Chen commented on HADOOP-14872:
Thanks [~jzhuge] and [~ste...@apache.org]!
Looks good to me
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180677#comment-16180677
]
Steve Loughran commented on HADOOP-14872:
-
LGTM
+1, with one little change requested before you
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177016#comment-16177016
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176240#comment-16176240
]
Steve Loughran commented on HADOOP-14872:
-
This is *exactly* what I'm thinking of!
# we should
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176200#comment-16176200
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171547#comment-16171547
]
Steve Loughran commented on HADOOP-14872:
-
off the record, I'm not happy that the HDFS team
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171543#comment-16171543
]
Steve Loughran commented on HADOOP-14872:
-
# This is one of those APIs which
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171301#comment-16171301
]
Hadoop QA commented on HADOOP-14872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170706#comment-16170706
]
Xiao Chen commented on HADOOP-14872:
Thanks John for reporting and fixing this! Looks pretty good
33 matches
Mail list logo
