[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206749#comment-16206749
]
Robert Kanter commented on HADOOP-14938:
Thanks for the branch-2 and branch-3.0 patches. The
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206692#comment-16206692
]
Misha Dmitriev commented on HADOOP-14938:
-
As far as I understand, the report above says that
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206675#comment-16206675
]
Hadoop QA commented on HADOOP-14938:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206582#comment-16206582
]
Misha Dmitriev commented on HADOOP-14938:
-
Ok, uploaded patches for both branch-3.0 and branch-2
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204200#comment-16204200
]
Hudson commented on HADOOP-14938:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13081 (See
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204173#comment-16204173
]
Robert Kanter commented on HADOOP-14938:
[~mi...@cloudera.com], the patch only applies to trunk
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204035#comment-16204035
]
Robert Kanter commented on HADOOP-14938:
LGTM +1
> Configuration.updatingResource map should be
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203961#comment-16203961
]
Misha Dmitriev commented on HADOOP-14938:
-
The only problem now is one comment from checkstyle,
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202988#comment-16202988
]
Hadoop QA commented on HADOOP-14938:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202879#comment-16202879
]
Misha Dmitriev commented on HADOOP-14938:
-
Thank you Robert. I've fixed checkstyle. Regarding
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202845#comment-16202845
]
Robert Kanter commented on HADOOP-14938:
Looks good to me. A couple minor comments:
# Can you
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201444#comment-16201444
]
Daniel Templeton commented on HADOOP-14938:
---
>From what I've read, you're almost correct on
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201400#comment-16201400
]
Misha Dmitriev commented on HADOOP-14938:
-
This time one test failed:
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200911#comment-16200911
]
Hadoop QA commented on HADOOP-14938:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199630#comment-16199630
]
Daniel Templeton commented on HADOOP-14938:
---
A couple of comments:
# It would be nice to have
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199377#comment-16199377
]
Misha Dmitriev commented on HADOOP-14938:
-
The test failure looks completely unrelated.
I'll
[
https://issues.apache.org/jira/browse/HADOOP-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198135#comment-16198135
]
Hadoop QA commented on HADOOP-14938:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
17 matches
Mail list logo