[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380987#comment-16380987
]
genericqa commented on HADOOP-15007:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379440#comment-16379440
]
Ajay Kumar commented on HADOOP-15007:
-
[~leftnoteasy], [~anu] Added patch for branch 3.1
>
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379387#comment-16379387
]
Wangda Tan commented on HADOOP-15007:
-
[~anu], apologize for my late responses, was traveling in the
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374840#comment-16374840
]
Hudson commented on HADOOP-15007:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13706 (See
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374822#comment-16374822
]
Anu Engineer commented on HADOOP-15007:
---
[~leftnoteasy] if you are ok with this, Can I commit this
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374821#comment-16374821
]
Ajay Kumar commented on HADOOP-15007:
-
[~anu], [~elek],[~ste...@apache.org], [~leftnoteasy] thanks
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374809#comment-16374809
]
Anu Engineer commented on HADOOP-15007:
---
[~ste...@apache.org] and [~elek]
I am committing this
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373694#comment-16373694
]
genericqa commented on HADOOP-15007:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373563#comment-16373563
]
Ajay Kumar commented on HADOOP-15007:
-
Patch v3 to address checkstyle issue.
> Stabilize and
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368078#comment-16368078
]
genericqa commented on HADOOP-15007:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368053#comment-16368053
]
Ajay Kumar commented on HADOOP-15007:
-
[~anu] patch v2 to remove HADOOP_SYSTEM_TAGS_DEFAULT.
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366512#comment-16366512
]
Anu Engineer commented on HADOOP-15007:
---
[~ajayydv] Overall it looks very good. Some minor
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366454#comment-16366454
]
genericqa commented on HADOOP-15007:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366393#comment-16366393
]
Ajay Kumar commented on HADOOP-15007:
-
[~leftnoteasy] moved it for 3.2
[~elek],[~anu],Uploaded new
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365116#comment-16365116
]
Wangda Tan commented on HADOOP-15007:
-
Ping [~ajayydv].
> Stabilize and document Configuration
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359873#comment-16359873
]
Elek, Marton commented on HADOOP-15007:
---
Thanks [~ajayydv] the patch.
But (to be honest) this is
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359734#comment-16359734
]
Wangda Tan commented on HADOOP-15007:
-
Thanks [~ajayydv] for working on the issue,
Since this is
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353214#comment-16353214
]
genericqa commented on HADOOP-15007:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352934#comment-16352934
]
Ajay Kumar commented on HADOOP-15007:
-
[~ste...@apache.org],[~anu],[~elek] thanks for valuable
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352138#comment-16352138
]
Elek, Marton commented on HADOOP-15007:
---
+1 for separaing action item 3.
+0 for action item 1 and
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351659#comment-16351659
]
Anu Engineer commented on HADOOP-15007:
---
{quote}Please, stop trying to argue this. I'm not going
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351626#comment-16351626
]
Steve Loughran commented on HADOOP-15007:
-
We use string constants for all other XML
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349144#comment-16349144
]
Anu Engineer commented on HADOOP-15007:
---
I think we are conflating different issues here into this
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349073#comment-16349073
]
Steve Loughran commented on HADOOP-15007:
-
I'd rather we just use strings and not worry about
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348427#comment-16348427
]
Elek, Marton commented on HADOOP-15007:
---
[~anu] I understand your concerns about type-safety. My
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347587#comment-16347587
]
Ajay Kumar commented on HADOOP-15007:
-
[~ste...@apache.org], Since excessive logging is the issue,
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347305#comment-16347305
]
Anu Engineer commented on HADOOP-15007:
---
In my mind, Enums are acting as a set of constants that
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347284#comment-16347284
]
Steve Loughran commented on HADOOP-15007:
-
The problem I'm having with enums is the stack trace.
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347219#comment-16347219
]
Anu Engineer commented on HADOOP-15007:
---
[~elek] , I personally favor type safety over duck
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347064#comment-16347064
]
Elek, Marton commented on HADOOP-15007:
---
As the tags are used only to classify configuration for
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242145#comment-16242145
]
Steve Loughran commented on HADOOP-15007:
-
New stack trace: what you get when a config option
[
https://issues.apache.org/jira/browse/HADOOP-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234337#comment-16234337
]
Steve Loughran commented on HADOOP-15007:
-
# Is this expected to be a stable change? Or at
32 matches
Mail list logo
