[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259131#comment-16259131
]
Genmao Yu commented on HADOOP-15024:
LGTM and +1
cc [~ste...@apache.org] and [~drankye]
>
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258905#comment-16258905
]
Hadoop QA commented on HADOOP-15024:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258866#comment-16258866
]
SammiChen commented on HADOOP-15024:
Hi [~uncleGen], thanks for review the patch!
I uploaded a new
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255218#comment-16255218
]
Genmao Yu commented on HADOOP-15024:
LGTM except two checkstyle warnings.
> AliyunOSS: Provide
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255170#comment-16255170
]
Hadoop QA commented on HADOOP-15024:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255114#comment-16255114
]
SammiChen commented on HADOOP-15024:
001 patch uploaded. User agent string is added plus the Hadoop
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254988#comment-16254988
]
SammiChen commented on HADOOP-15024:
Hi [~uncleGen], the patch is blocked by the UT failures when I
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254977#comment-16254977
]
Genmao Yu commented on HADOOP-15024:
[~Sammi] Are you busy now? As this is a simple change, do you
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247308#comment-16247308
]
Genmao Yu commented on HADOOP-15024:
OK, I will post a test result based on your new patch.
>
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247299#comment-16247299
]
SammiChen commented on HADOOP-15024:
Thanks [~ste...@apache.org] and [~uncleGen] for review the
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247288#comment-16247288
]
Genmao Yu commented on HADOOP-15024:
+1 to add a config like "fs.oss.user.agent.prefix"
{code}
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243788#comment-16243788
]
Steve Loughran commented on HADOOP-15024:
-
Makes sense: the other clients do this. S3A actually
[
https://issues.apache.org/jira/browse/HADOOP-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243618#comment-16243618
]
Hadoop QA commented on HADOOP-15024:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
13 matches
Mail list logo