[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-08-09 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575101#comment-16575101 ] Wei-Chiu Chuang commented on HADOOP-15317: -- Shouldn't this be a HDFS jira? :) > Improve

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-04-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423526#comment-16423526 ] Hudson commented on HADOOP-15317: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13915 (See

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-04-03 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423516#comment-16423516 ] Xiao Chen commented on HADOOP-15317: Pushed this to all branches (trunk, branch-3.[0-1], branch-2,

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-04-02 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423507#comment-16423507 ] Xiao Chen commented on HADOOP-15317: Failed tests look unrelated. Committing this > Improve

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-04-02 Thread Lei (Eddy) Xu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423267#comment-16423267 ] Lei (Eddy) Xu commented on HADOOP-15317: +1. Thanks [~xiaochen]! > Improve NetworkTopology

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-29 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420072#comment-16420072 ] genericqa commented on HADOOP-15317: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-29 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419883#comment-16419883 ] Ajay Kumar commented on HADOOP-15317: - +1 for patch v6 > Improve NetworkTopology chooseRandom's

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-29 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419805#comment-16419805 ] Xiao Chen commented on HADOOP-15317: That was intentional, as that's the number of nodes under the

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-28 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418341#comment-16418341 ] Ajay Kumar commented on HADOOP-15317: - [~xiaochen], patch v5 looks good. One question: * For

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-28 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417108#comment-16417108 ] genericqa commented on HADOOP-15317: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-28 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416876#comment-16416876 ] Xiao Chen commented on HADOOP-15317: Thanks for the review Eddy. [^HADOOP-15317.05.patch] addressed

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-27 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416597#comment-16416597 ] genericqa commented on HADOOP-15317: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-27 Thread Lei (Eddy) Xu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416436#comment-16416436 ] Lei (Eddy) Xu commented on HADOOP-15317: Thanks for working on this, [~xiaochen] A few

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-27 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416333#comment-16416333 ] Xiao Chen commented on HADOOP-15317: Thanks for looking at the test failures, definitely related.

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-26 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414630#comment-16414630 ] Ajay Kumar commented on HADOOP-15317: - [~xiaochen], thanks for updating the patch. New change to

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-26 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414507#comment-16414507 ] Ajay Kumar commented on HADOOP-15317: - Hi [~xiaochen], Seems you missed adding "special case to

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-24 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412494#comment-16412494 ] genericqa commented on HADOOP-15317: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-23 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412427#comment-16412427 ] Xiao Chen commented on HADOOP-15317: Thanks for the review [~ajayydv]. Comments addressed, and added

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-19 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405479#comment-16405479 ] Ajay Kumar commented on HADOOP-15317: - [~xiaochen], thanks for updating the patch. I think we can

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-16 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403275#comment-16403275 ] Xiao Chen commented on HADOOP-15317: Discussed with [~eddyxu] about this a little bit, uploaded 

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-15 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401149#comment-16401149 ] Ajay Kumar commented on HADOOP-15317: - [~xiaochen], thanks for working on this. Two comments: *

[jira] [Commented] (HADOOP-15317) Improve NetworkTopology chooseRandom's loop

2018-03-15 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399967#comment-16399967 ] genericqa commented on HADOOP-15317: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||