[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876996#comment-16876996
]
Steve Loughran commented on HADOOP-15679:
-
[~yumwang] -thanks; corrected
> ShutdownHookManager
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876884#comment-16876884
]
Yuming Wang commented on HADOOP-15679:
--
Hi [~ste...@apache.org] It seems Fix Version/s should be
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646902#comment-16646902
]
Steve Loughran commented on HADOOP-15679:
-
license is just
{code}
Lines that start with ?
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646646#comment-16646646
]
Hadoop QA commented on HADOOP-15679:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646605#comment-16646605
]
Hadoop QA commented on HADOOP-15679:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646405#comment-16646405
]
Hadoop QA commented on HADOOP-15679:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646312#comment-16646312
]
Steve Loughran commented on HADOOP-15679:
-
Test failure: .pid file in the test dir mistaken as
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645192#comment-16645192
]
Hadoop QA commented on HADOOP-15679:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623882#comment-16623882
]
Hadoop QA commented on HADOOP-15679:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623761#comment-16623761
]
Steve Loughran commented on HADOOP-15679:
-
issue was that in the backport, the checkstyle
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623692#comment-16623692
]
Steve Loughran commented on HADOOP-15679:
-
{code}
[WARNING]
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623447#comment-16623447
]
Hadoop QA commented on HADOOP-15679:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596203#comment-16596203
]
Steve Loughran commented on HADOOP-15679:
-
javadoc regression; builds.apache.org down right now
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595352#comment-16595352
]
genericqa commented on HADOOP-15679:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595239#comment-16595239
]
Steve Loughran commented on HADOOP-15679:
-
checkstyle is about unused import; removing and
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594921#comment-16594921
]
genericqa commented on HADOOP-15679:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590674#comment-16590674
]
genericqa commented on HADOOP-15679:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586820#comment-16586820
]
Hudson commented on HADOOP-15679:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14807 (See
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586809#comment-16586809
]
Steve Loughran commented on HADOOP-15679:
-
thanks.pushed up 3.1 & trunk patch; backporting to
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586556#comment-16586556
]
Xiaoyu Yao commented on HADOOP-15679:
-
{quote}One change not in this patch: logging if a too low
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584618#comment-16584618
]
Thomas Marquardt commented on HADOOP-15679:
---
+1 LGTM
> ShutdownHookManager shutdown time
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584593#comment-16584593
]
genericqa commented on HADOOP-15679:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584519#comment-16584519
]
Steve Loughran commented on HADOOP-15679:
-
One change not in this patch: logging if a too low
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584515#comment-16584515
]
Steve Loughran commented on HADOOP-15679:
-
[~xyao]: I'm adding a log at the end of the run; not
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584508#comment-16584508
]
Steve Loughran commented on HADOOP-15679:
-
[~tmarquardt], thanks for the comments
h3. imports
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583466#comment-16583466
]
genericqa commented on HADOOP-15679:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583394#comment-16583394
]
Thomas Marquardt commented on HADOOP-15679:
---
+1, with some comments:
Slightly unrelated to
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583368#comment-16583368
]
Steve Loughran commented on HADOOP-15679:
-
Thanks for the review.
I like your idea of debug
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583352#comment-16583352
]
Xiaoyu Yao commented on HADOOP-15679:
-
Thanks [~ste...@apache.org] for working on this. The patch
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582905#comment-16582905
]
Steve Loughran commented on HADOOP-15679:
-
HADOOP-15679 patch 002;
* move key & default to
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582865#comment-16582865
]
Steve Loughran commented on HADOOP-15679:
-
ignoring minor style and javadoc warnings (trivially
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582312#comment-16582312
]
genericqa commented on HADOOP-15679:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582097#comment-16582097
]
Steve Loughran commented on HADOOP-15679:
-
HADOOP-15769 patch 001: timeout for hooks extended
[
https://issues.apache.org/jira/browse/HADOOP-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581969#comment-16581969
]
Steve Loughran commented on HADOOP-15679:
-
one little detail, shutdown hook manager doesn't
34 matches
Mail list logo
