[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719338#comment-16719338
]
Hudson commented on HADOOP-15995:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15598 (See
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719320#comment-16719320
]
Giovanni Matteo Fumarola commented on HADOOP-15995:
---
Thanks [~lukmajercak] for
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718330#comment-16718330
]
Lukas Majercak commented on HADOOP-15995:
-
I changed it from conf to config because checkstyle
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718323#comment-16718323
]
Larry McCay commented on HADOOP-15995:
--
Assuming that testConfGetPassword provides test coverage
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718272#comment-16718272
]
Lukas Majercak commented on HADOOP-15995:
-
I agree some of the configs from LDAPGroupsMapping
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718268#comment-16718268
]
Wei-Chiu Chuang commented on HADOOP-15995:
--
Regarding the {{@Deprecated}} annotation, the
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718255#comment-16718255
]
Wei-Chiu Chuang commented on HADOOP-15995:
--
Probably not in this jira, but it would be helpful
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718168#comment-16718168
]
Íñigo Goiri commented on HADOOP-15995:
--
+1 on [^HADOOP-15995.007.patch].
[~lmccay] can you take a
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718157#comment-16718157
]
Hadoop QA commented on HADOOP-15995:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718005#comment-16718005
]
Lukas Majercak commented on HADOOP-15995:
-
Patch007 changes to use
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718003#comment-16718003
]
Hadoop QA commented on HADOOP-15995:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717977#comment-16717977
]
Hadoop QA commented on HADOOP-15995:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717950#comment-16717950
]
Lukas Majercak commented on HADOOP-15995:
-
[~lmccay], does the latest patch look good to you?
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717867#comment-16717867
]
Lukas Majercak commented on HADOOP-15995:
-
I changed to getPasswordFromCredentialProviders for
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717860#comment-16717860
]
Íñigo Goiri commented on HADOOP-15995:
--
The deprecated was added in HADOOP-12862.
No much
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717767#comment-16717767
]
Lukas Majercak commented on HADOOP-15995:
-
Thanks [~elgoiri]. I fixed the style issue in the
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716065#comment-16716065
]
Íñigo Goiri commented on HADOOP-15995:
--
Thanks [~lukmajercak] for the patch.
Minor comments:
* In
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715891#comment-16715891
]
Hadoop QA commented on HADOOP-15995:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715877#comment-16715877
]
Hadoop QA commented on HADOOP-15995:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715787#comment-16715787
]
Hadoop QA commented on HADOOP-15995:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715795#comment-16715795
]
Lukas Majercak commented on HADOOP-15995:
-
For some reason, yetus still picked patch002.
> Add
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715772#comment-16715772
]
Lukas Majercak commented on HADOOP-15995:
-
Another checkstyle issue fixed in patch004.
> Add
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715771#comment-16715771
]
Hadoop QA commented on HADOOP-15995:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715707#comment-16715707
]
Lukas Majercak commented on HADOOP-15995:
-
Patch 003 to fix the checkstyle issue.
> Add
[
https://issues.apache.org/jira/browse/HADOOP-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715687#comment-16715687
]
Hadoop QA commented on HADOOP-15995:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
25 matches
Mail list logo