[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-23 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846864#comment-16846864 ] Prabhu Joseph commented on HADOOP-16287: Thanks [~eyang]. > KerberosAuthenticationHandler

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846817#comment-16846817 ] Hudson commented on HADOOP-16287: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16591 (See

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-16 Thread Larry McCay (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841753#comment-16841753 ] Larry McCay commented on HADOOP-16287: -- [~daryn] - I see no difference between what is provided

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840528#comment-16840528 ] Eric Yang commented on HADOOP-16287: +1 on patch 007 to include the new

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-15 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840110#comment-16840110 ] Prabhu Joseph commented on HADOOP-16287: Fixed checkstyle issues inĀ [^HADOOP-16287-007.patch].

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840105#comment-16840105 ] Hadoop QA commented on HADOOP-16287: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839213#comment-16839213 ] Hadoop QA commented on HADOOP-16287: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-14 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839156#comment-16839156 ] Prabhu Joseph commented on HADOOP-16287: [~eyang] Have added new filter initializer

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-13 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1683#comment-1683 ] Eric Yang commented on HADOOP-16287: [~Prabhu Joseph] Thank you for the patch. I think we also

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-10 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836936#comment-16836936 ] Prabhu Joseph commented on HADOOP-16287: Thanks [~sunilg] and [~eyang] for review. The latest

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-10 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836930#comment-16836930 ] Sunil Govindan commented on HADOOP-16287: - ThanksĀ [~Prabhu Joseph] and [~eyang] In Summary, we

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-09 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836147#comment-16836147 ] Prabhu Joseph commented on HADOOP-16287: Test case failures are not related. Have reported

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836127#comment-16836127 ] Hadoop QA commented on HADOOP-16287: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-08 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836081#comment-16836081 ] Prabhu Joseph commented on HADOOP-16287: Patch 5 fixes checkstyle issues. >

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-08 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835961#comment-16835961 ] Eric Yang commented on HADOOP-16287: [~daryn] Any concern with patch 4? If not, I will give +1 on

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835531#comment-16835531 ] Hadoop QA commented on HADOOP-16287: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-08 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835487#comment-16835487 ] Prabhu Joseph commented on HADOOP-16287: [~eyang] Yes, using request attribute to set and get

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-07 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834908#comment-16834908 ] Eric Yang commented on HADOOP-16287: [~Prabhu Joseph] thank you for the patch. Patch 003 has two

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834787#comment-16834787 ] Hadoop QA commented on HADOOP-16287: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834645#comment-16834645 ] Hadoop QA commented on HADOOP-16287: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-07 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834607#comment-16834607 ] Prabhu Joseph commented on HADOOP-16287: [~daryn] [~eyang] Thanks for the review. When testing

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-03 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832604#comment-16832604 ] Eric Yang commented on HADOOP-16287: It would be best to ensure that respond of servers are

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-03 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832601#comment-16832601 ] Eric Yang commented on HADOOP-16287: [~daryn] {quote}-1 on returning a new auth cookie as the

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-03 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832580#comment-16832580 ] Daryn Sharp commented on HADOOP-16287: -- We need this, but -1 on one very seemingly simple change

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832478#comment-16832478 ] Hadoop QA commented on HADOOP-16287: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||