[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110580#comment-16110580 ] Steve Loughran commented on HADOOP-3733: I think that seems a reasonable strategy. Can you supply

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110297#comment-16110297 ] Vinayakumar B commented on HADOOP-3733: --- bq. I don't want to revert this, as it does a lot. But I

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109840#comment-16109840 ] Steve Loughran commented on HADOOP-3733: Given that distcp clearly never worked if there was a

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107425#comment-16107425 ] Vinayakumar B commented on HADOOP-3733: --- Stripping down the userinfo part of provided uri in the

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337054#comment-15337054 ] Chris Nauroth commented on HADOOP-3733: --- The new test fails if your AWS secret key contains a '+'.

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334408#comment-15334408 ] Hudson commented on HADOOP-3733: SUCCESS: Integrated in Hadoop-trunk-Commit #9971 (See

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334375#comment-15334375 ] Chris Nauroth commented on HADOOP-3733: --- [~raviprak], thank you very much for the thorough code

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334355#comment-15334355 ] Ravi Prakash commented on HADOOP-3733: -- Thanks a lot Steve! +1 . Will commit to trunk and branch-2

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333595#comment-15333595 ] Steve Loughran commented on HADOOP-3733: Thanks for finding the final quirk..I'll address it. I

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332793#comment-15332793 ] Ravi Prakash commented on HADOOP-3733: -- I reviewed the patch. Thanks a lot Steve. It looks great!

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332517#comment-15332517 ] Ravi Prakash commented on HADOOP-3733: -- Found it. In {{S3xLoginHelper.extractLoginDetails}} we

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332289#comment-15332289 ] Hadoop QA commented on HADOOP-3733: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332273#comment-15332273 ] Ravi Prakash commented on HADOOP-3733: -- Thanks Steve! With patch v6, I am able to use aws secrets

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331856#comment-15331856 ] Hadoop QA commented on HADOOP-3733: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330262#comment-15330262 ] Hadoop QA commented on HADOOP-3733: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330098#comment-15330098 ] Steve Loughran commented on HADOOP-3733: Testing: s3 ireland. Again, all well except that

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330095#comment-15330095 ] Steve Loughran commented on HADOOP-3733: Patch 002 * fixes findbug bug. * fixes checkstyle

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329688#comment-15329688 ] Hadoop QA commented on HADOOP-3733: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329632#comment-15329632 ] Steve Loughran commented on HADOOP-3733: ...ok root cause is that (a) the S3 filesystems are

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329221#comment-15329221 ] Steve Loughran commented on HADOOP-3733: OK, I think I see the issue: you are putting the secret

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327754#comment-15327754 ] Ravi Prakash commented on HADOOP-3733: -- Hi Steve! I seem to still be observing the issue. How are

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322497#comment-15322497 ] Steve Loughran commented on HADOOP-3733: Can I observer that one of my secret keys does contain a

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228558#comment-15228558 ] Ravi Prakash commented on HADOOP-3733: -- We should see if we can get this whenever 3.0.0 is released

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132075#comment-15132075 ] Daniel Darabos commented on HADOOP-3733: We're using {{s3n}} and we set {{fs.s3n.awsAccessKeyId}}

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132633#comment-15132633 ] Terry Siu commented on HADOOP-3733: --- Thanks, Daniel, but I had tried setting fs.s3a.access.key and

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126898#comment-15126898 ] Terry Siu commented on HADOOP-3733: --- Howdy! Given the lack of activity/comments for almost a year, can

[jira] [Commented] (HADOOP-3733) "s3:" URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126901#comment-15126901 ] Terry Siu commented on HADOOP-3733: --- Just to clarify my comment above, I'm using Hive to create a table

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14330218#comment-14330218 ] Steve Loughran commented on HADOOP-3733: The focus on s3 client stuff has shifted

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326597#comment-14326597 ] Peng Cheng commented on HADOOP-3733: Hey, any follow up story on this issue? Its been

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066629#comment-14066629 ] Allen Wittenauer commented on HADOOP-3733: -- It probably be better if secrets

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962534#comment-13962534 ] Jerry Ye commented on HADOOP-3733: -- Aside from setting the credentials in

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962550#comment-13962550 ] Hadoop QA commented on HADOOP-3733: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827360#comment-13827360 ] Charles Menguy commented on HADOOP-3733: I can confirm that I have been hitting

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810150#comment-13810150 ] Ulrich Cech commented on HADOOP-3733: - I can confirm, that this bug treats us very

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726760#comment-13726760 ] Joseph Lawson commented on HADOOP-3733: --- I would like to comment that this bug will

[jira] [Commented] (HADOOP-3733) s3: URLs break when Secret Key contains a slash, even if encoded

[ https://issues.apache.org/jira/browse/HADOOP-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584986#comment-13584986 ] Hadoop QA commented on HADOOP-3733: --- {color:green}+1 overall{color}. Here are the