[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715592#comment-15715592
]
Steve Loughran commented on HADOOP-6240:
Just a heads up that I've filed HADOOP-1
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757655#action_12757655
]
Hudson commented on HADOOP-6240:
Integrated in Hadoop-Common-trunk #102 (See
[http://huds
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757479#action_12757479
]
Hudson commented on HADOOP-6240:
Integrated in Hadoop-Common-trunk-Commit #42 (See
[http:
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757462#action_12757462
]
Hadoop QA commented on HADOOP-6240:
---
+1 overall. Here are the results of testing the la
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757425#action_12757425
]
Sanjay Radia commented on HADOOP-6240:
--
Checked your latest minor changes.
+1
> Rena
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757343#action_12757343
]
Sanjay Radia commented on HADOOP-6240:
--
+1 looks good.
> Rename operation is not con
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757268#action_12757268
]
Hadoop QA commented on HADOOP-6240:
---
+1 overall. Here are the results of testing the la
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757212#action_12757212
]
Tom White commented on HADOOP-6240:
---
Does the new rename method need a comment to explai
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756996#action_12756996
]
Sanjay Radia commented on HADOOP-6240:
--
Change comment in the default implementation
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756990#action_12756990
]
Hadoop QA commented on HADOOP-6240:
---
+1 overall. Here are the results of testing the la
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756969#action_12756969
]
Hadoop QA commented on HADOOP-6240:
---
-1 overall. Here are the results of testing the la
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756756#action_12756756
]
Suresh Srinivas commented on HADOOP-6240:
-
+1 for varargs. It is much cleaner.
>
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756717#action_12756717
]
Doug Cutting commented on HADOOP-6240:
--
Suresh, I was thinking we'd use varargs, e.g.
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756716#action_12756716
]
Sanjay Radia commented on HADOOP-6240:
--
+1 to suresh's proposal.
I suspect he has use
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756707#action_12756707
]
Doug Cutting commented on HADOOP-6240:
--
> I often test these apps on the local file s
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756695#action_12756695
]
Todd Lipcon commented on HADOOP-6240:
-
bq. In terms of atomicity, I'm leaning toward a
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756684#action_12756684
]
Owen O'Malley commented on HADOOP-6240:
---
I like the Overwrite flag. Currently, in th
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756683#action_12756683
]
Suresh Srinivas commented on HADOOP-6240:
-
Here is the summary of the discussion s
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756632#action_12756632
]
Sanjay Radia commented on HADOOP-6240:
--
I like the Overwrite flag. It resolves the op
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756621#action_12756621
]
Doug Cutting commented on HADOOP-6240:
--
> It appears that you are being inconsistent
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756604#action_12756604
]
Eli Collins commented on HADOOP-6240:
-
+1 for the value of atomic rename for apps.
I
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756540#action_12756540
]
dhruba borthakur commented on HADOOP-6240:
--
There are many apps that I have built
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756357#action_12756357
]
Sanjay Radia commented on HADOOP-6240:
--
> we're saying that we don't want to claim su
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756341#action_12756341
]
Todd Lipcon commented on HADOOP-6240:
-
bq. The javadoc for the DistributedClient.renam
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756314#action_12756314
]
dhruba borthakur commented on HADOOP-6240:
--
I like this statement. The javadoc fo
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756313#action_12756313
]
dhruba borthakur commented on HADOOP-6240:
--
> Rename may be atomic; please see th
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756307#action_12756307
]
Sanjay Radia commented on HADOOP-6240:
--
Q. what should FileContext#rename do for rena
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756298#action_12756298
]
Sanjay Radia commented on HADOOP-6240:
--
Proposal for rename spec
# Rename may be at
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756276#action_12756276
]
Doug Cutting commented on HADOOP-6240:
--
> Renames across dirs may be be atomic depend
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756269#action_12756269
]
Sanjay Radia commented on HADOOP-6240:
--
So proposal is:
* a renames within a director
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756200#action_12756200
]
Doug Cutting commented on HADOOP-6240:
--
> For those that do we can provide an API:
>
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756176#action_12756176
]
Sanjay Radia commented on HADOOP-6240:
--
Sanjay> atomic if fs supports it and is withi
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756108#action_12756108
]
Doug Cutting commented on HADOOP-6240:
--
Suresh> all the behaviors I documented in my
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755826#action_12755826
]
Sanjay Radia commented on HADOOP-6240:
--
How about the rewording suresh's option 1s as
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755815#action_12755815
]
dhruba borthakur commented on HADOOP-6240:
--
One of the concerns that I have initi
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755813#action_12755813
]
Suresh Srinivas commented on HADOOP-6240:
-
Doug, Sanjay and others can you please
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755791#action_12755791
]
Suresh Srinivas commented on HADOOP-6240:
-
bq. Which behaviors are different from
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755594#action_12755594
]
Doug Cutting commented on HADOOP-6240:
--
Which behaviors are different from the curren
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755303#action_12755303
]
Sanjay Radia commented on HADOOP-6240:
--
Any time one is moving from current state to
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755290#action_12755290
]
Konstantin Shvachko commented on HADOOP-6240:
-
> rename2 from /a/file1 to /b/f
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755287#action_12755287
]
Jakob Homan commented on HADOOP-6240:
-
Options 2 definitely seem the less dangerous an
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755286#action_12755286
]
Suresh Srinivas commented on HADOOP-6240:
-
Sorry for the typos in the previous con
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755282#action_12755282
]
Suresh Srinivas commented on HADOOP-6240:
-
Based on discussion everyone seems to a
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755272#action_12755272
]
Suresh Srinivas commented on HADOOP-6240:
-
bq. The namenode does not keep track of
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755179#action_12755179
]
Konstantin Shvachko commented on HADOOP-6240:
-
Yep, atomic rewrite of a symlin
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755163#action_12755163
]
Todd Lipcon commented on HADOOP-6240:
-
bq. The namenode does not keep track of files o
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755144#action_12755144
]
Konstantin Shvachko commented on HADOOP-6240:
-
> I could certainly be convince
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755143#action_12755143
]
Doug Cutting commented on HADOOP-6240:
--
> it would be nice to simply open the file, r
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755119#action_12755119
]
Todd Lipcon commented on HADOOP-6240:
-
bq. Is there a use case, when atomic rename rep
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755107#action_12755107
]
Konstantin Shvachko commented on HADOOP-6240:
-
It was probably too general for
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754292#action_12754292
]
Todd Lipcon commented on HADOOP-6240:
-
+1 for any solution that avoids sinking to the
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754283#action_12754283
]
Doug Cutting commented on HADOOP-6240:
--
> We should not provide atomic renames [ ...
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754277#action_12754277
]
Suresh Srinivas commented on HADOOP-6240:
-
LocalFileSystem can do necessary things
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754255#action_12754255
]
Konstantin Shvachko commented on HADOOP-6240:
-
I just want to comment on atomi
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753768#action_12753768
]
Doug Cutting commented on HADOOP-6240:
--
> Personally I am not in favor of doing renam
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753753#action_12753753
]
Suresh Srinivas commented on HADOOP-6240:
-
I still do not understand why protected
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753745#action_12753745
]
Doug Cutting commented on HADOOP-6240:
--
So why not make this issue depend on HADOOP-6
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753730#action_12753730
]
Suresh Srinivas commented on HADOOP-6240:
-
Owen actually educated me that protecte
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753726#action_12753726
]
Doug Cutting commented on HADOOP-6240:
--
> Actually it is package private.
If it's pa
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753712#action_12753712
]
Suresh Srinivas commented on HADOOP-6240:
-
Sorry my bad, I had written it as prote
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753670#action_12753670
]
Doug Cutting commented on HADOOP-6240:
--
A protected method cannot be called by other
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753382#action_12753382
]
Sanjay Radia commented on HADOOP-6240:
--
I might have been a little hasty in my commen
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753366#action_12753366
]
Sanjay Radia commented on HADOOP-6240:
--
Doug if you look at HADOOP-6223's AbstractFil
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753323#action_12753323
]
Doug Cutting commented on HADOOP-6240:
--
> I am not a fan of method name rename2 eithe
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753298#action_12753298
]
Suresh Srinivas commented on HADOOP-6240:
-
The main issue is not throwing IOExcept
[
https://issues.apache.org/jira/browse/HADOOP-6240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752647#action_12752647
]
Doug Cutting commented on HADOOP-6240:
--
I generally dislike putting version numbers i
66 matches
Mail list logo