Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
ferhui commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2071256036 @ZanderXu Thanks for contribution. @kokonguyen191 Thanks for review. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
ferhui merged PR #6741: URL: https://github.com/apache/hadoop/pull/6741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2070306218 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
kokonguyen191 commented on code in PR #6741: URL: https://github.com/apache/hadoop/pull/6741#discussion_r1574451782 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListOpenFiles.java: ## @@ -48,6 +48,7 @@ import

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
ZanderXu commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2068640362 The spotbugs will be fixed by HDFS-17485. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
ZanderXu commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2068623064 > @ZanderXu could you check the failed test cases and the spotbugs @ferhui All of failed UTs have been fixed by HDFS-17435. And the spotbugs is not introduced by this PR, I will

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-18 Thread via GitHub
ferhui commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2065598746 @ZanderXu could you check the failed test cases and the spotbugs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-18 Thread via GitHub
hadoop-yetus commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2065037657 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-18 Thread via GitHub
hadoop-yetus commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2064298103 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-18 Thread via GitHub
ferhui commented on code in PR #6741: URL: https://github.com/apache/hadoop/pull/6741#discussion_r1570474704 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListOpenFiles.java: ## @@ -32,6 +32,7 @@ import

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-17 Thread via GitHub
ferhui commented on code in PR #6741: URL: https://github.com/apache/hadoop/pull/6741#discussion_r1569812780 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestNameNodePrunesMissingStorages.java: ## @@ -22,6 +22,7 @@ import

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-17 Thread via GitHub
ferhui commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2062890927 BTW, can also check the checkstyle issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-17 Thread via GitHub
hadoop-yetus commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2060740027 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |