Re: [PR] HDFS-17451. RBF: fix spotbugs for redundant nullcheck of dns. [hadoop]

2024-04-10 Thread via GitHub
KeeProMise commented on code in PR #6697: URL: https://github.com/apache/hadoop/pull/6697#discussion_r1558805351 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java: ## @@ -1090,7 +1090,7 @@ DatanodeInfo[]

Re: [PR] HADOOP-19107. Drop support for HBase v1 & upgrade HBase v2 [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6629: URL: https://github.com/apache/hadoop/pull/6629#issuecomment-2046646167 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19107) Drop support for HBase v1

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835615#comment-17835615 ] ASF GitHub Bot commented on HADOOP-19107: - hadoop-yetus commented on PR #6629: URL:

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835680#comment-17835680 ] ASF GitHub Bot commented on HADOOP-18656: - anujmodi2021 commented on code in PR #6409: URL:

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835689#comment-17835689 ] ASF GitHub Bot commented on HADOOP-16822: - steveloughran merged PR #6458: URL:

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835690#comment-17835690 ] ASF GitHub Bot commented on HADOOP-16822: - steveloughran commented on PR #6458: URL:

[PR] (3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
pan3793 opened a new pull request, #6719: URL: https://github.com/apache/hadoop/pull/6719 This backport https://github.com/apache/hadoop/pull/6458 to branch-3.3 This reverts commit 2c4ab72a60113e4dd4ef2375e6f9413e519b1044. Justification: this was making debugging through IDEs

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835709#comment-17835709 ] ASF GitHub Bot commented on HADOOP-16822: - pan3793 opened a new pull request, #6719: URL:

Re: [PR] (3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
pan3793 commented on PR #6719: URL: https://github.com/apache/hadoop/pull/6719#issuecomment-2047387046 cc @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835691#comment-17835691 ] ASF GitHub Bot commented on HADOOP-18656: - anujmodi2021 opened a new pull request, #6718: URL:

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835692#comment-17835692 ] ASF GitHub Bot commented on HADOOP-16822: - steveloughran commented on PR #6458: URL:

[jira] [Commented] (HADOOP-19109) Fix metrics description

2024-04-10 Thread wangzhihui (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835656#comment-17835656 ] wangzhihui commented on HADOOP-19109: - [~wuxiaobao] I have confirmed that is right. We don't need

[jira] [Updated] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16822: Description: h5. Improvement request The third-party libraries shading hadoop-client-api

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835710#comment-17835710 ] ASF GitHub Bot commented on HADOOP-16822: - pan3793 commented on PR #6719: URL:

Re: [PR] HADOOP-18656: [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-10 Thread via GitHub
anujmodi2021 commented on code in PR #6409: URL: https://github.com/apache/hadoop/pull/6409#discussion_r1559208012 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java: ## @@ -1240,8 +1244,8 @@ public boolean getRenameResilience() {

[PR] HADOOP-18656: [Backport to 3.4] [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-10 Thread via GitHub
anujmodi2021 opened a new pull request, #6718: URL: https://github.com/apache/hadoop/pull/6718 Description of PR Jira Ticket: https://issues.apache.org/jira/browse/HADOOP-18656 Today, when a recursive delete is issued for a large directory in ADLS Gen2 (HNS) account, the directory

Re: [PR] Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
steveloughran commented on PR #6458: URL: https://github.com/apache/hadoop/pull/6458#issuecomment-2047244916 merged to 3.4; branch-3.3 had conflicts. @pan3793 if you want it there, create another PR so yetus can validate it. thanks! -- This is an automated message from the Apache Git

[jira] [Commented] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835695#comment-17835695 ] ASF GitHub Bot commented on HADOOP-19098: - steveloughran merged PR #6706: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2047309028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19109) Fix metrics description

2024-04-10 Thread Xiaobao Wu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobao Wu updated HADOOP-19109: Summary: Fix metrics description (was: checkPermission should not ignore original

[jira] [Updated] (HADOOP-19109) Fix metrics description

2024-04-10 Thread Xiaobao Wu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobao Wu updated HADOOP-19109: Affects Version/s: 3.3.4 Description: This description of the RpcLockWaitTimeNumOps  

[jira] [Commented] (HADOOP-19109) Fix metrics description

2024-04-10 Thread wangzhihui (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835651#comment-17835651 ] wangzhihui commented on HADOOP-19109: - [~wuxiaobao]  Please add the code paragraphs to prove the

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-10 Thread via GitHub
haiyang1987 commented on code in PR #6710: URL: https://github.com/apache/hadoop/pull/6710#discussion_r1558977912 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java: ## @@ -287,4 +300,69 @@ public void

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835703#comment-17835703 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

[PR] HDFS-17458. Remove unnecessary BP lock in ReplicaMap. [hadoop]

2024-04-10 Thread via GitHub
hfutatzhanghb opened a new pull request, #6717: URL: https://github.com/apache/hadoop/pull/6717 ### Description of PR In [HDFS-16429](https://issues.apache.org/jira/browse/HDFS-16429) we make LightWeightResizableGSet to be thread safe, and in

Re: [PR] Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
steveloughran merged PR #6458: URL: https://github.com/apache/hadoop/pull/6458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
steveloughran commented on PR #6458: URL: https://github.com/apache/hadoop/pull/6458#issuecomment-2047239403 done, though as I pressed sent I realised the title had pulled line #2 up; sorry. will cherrypick to 3.4 -- This is an automated message from the Apache Git Service. To

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-10 Thread via GitHub
haiyang1987 commented on PR #6710: URL: https://github.com/apache/hadoop/pull/6710#issuecomment-2046720852 Thanks @ZanderXu @Hexiaoqiao for your detailed coment. Update pr, please help me review this PR again when you are free, thanks ~ -- This is an automated message from the

[jira] [Resolved] (HADOOP-19109) Fix metrics description

2024-04-10 Thread Xiaobao Wu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobao Wu resolved HADOOP-19109. - Resolution: Not A Problem > Fix metrics description > --- > >

Re: [PR] HADOOP-19107. Drop support for HBase v1 & upgrade HBase v2 [hadoop]

2024-04-10 Thread via GitHub
ayushtkn commented on PR #6629: URL: https://github.com/apache/hadoop/pull/6629#issuecomment-2047133044 The test failures doesn't look related. VM crashing and stuff is sorted ASF License is green. I can get a green run if everyone is happy -- This is an automated message from

[jira] [Commented] (HADOOP-19107) Drop support for HBase v1

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835675#comment-17835675 ] ASF GitHub Bot commented on HADOOP-19107: - ayushtkn commented on PR #6629: URL:

Re: [PR] HADOOP-19098. Vector IO: Specify and validate ranges consistently. #6604 [hadoop]

2024-04-10 Thread via GitHub
steveloughran merged PR #6706: URL: https://github.com/apache/hadoop/pull/6706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-19079. Check class is an exception class before constructing an instance [hadoop]

2024-04-10 Thread via GitHub
steveloughran commented on code in PR #6557: URL: https://github.com/apache/hadoop/pull/6557#discussion_r1559479255 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/LambdaTestUtils.java: ## @@ -823,6 +922,19 @@ public static E verifyCause( }

[jira] [Commented] (HADOOP-19079) check that class that is loaded is really an exception

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835744#comment-17835744 ] ASF GitHub Bot commented on HADOOP-19079: - steveloughran commented on code in PR #6557: URL:

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835716#comment-17835716 ] ASF GitHub Bot commented on HADOOP-16822: - steveloughran commented on PR #6719: URL:

Re: [PR] (3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
steveloughran commented on PR #6719: URL: https://github.com/apache/hadoop/pull/6719#issuecomment-2047450904 thanks; let's see what yetus says. +1 pending that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835731#comment-17835731 ] ASF GitHub Bot commented on HADOOP-16822: - steveloughran commented on PR #6719: URL:

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835739#comment-17835739 ] ASF GitHub Bot commented on HADOOP-19096: - steveloughran merged PR #6276: URL:

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835775#comment-17835775 ] ASF GitHub Bot commented on HADOOP-16822: - hadoop-yetus commented on PR #6719: URL:

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835792#comment-17835792 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835719#comment-17835719 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2047457646 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19096: [ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-10 Thread via GitHub
steveloughran merged PR #6276: URL: https://github.com/apache/hadoop/pull/6276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-204751 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835727#comment-17835727 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HADOOP-18656: [Backport to 3.4] [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6718: URL: https://github.com/apache/hadoop/pull/6718#issuecomment-2047520884 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2047848306 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-04-10 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19098: Fix Version/s: 3.3.9 > Vector IO: consistent specified rejection of overlapping ranges >

[jira] [Resolved] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-04-10 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-19098. - Resolution: Fixed > Vector IO: consistent specified rejection of overlapping ranges >

[jira] [Resolved] (HADOOP-19101) Vectored Read into off-heap buffer broken in fallback implementation

2024-04-10 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-19101. - Fix Version/s: 3.3.9 3.4.1 Resolution: Fixed > Vectored Read

Re: [PR] (3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6719: URL: https://github.com/apache/hadoop/pull/6719#issuecomment-2047773513 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17458. Remove unnecessary BP lock in ReplicaMap. [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6717: URL: https://github.com/apache/hadoop/pull/6717#issuecomment-2047785996 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2047859421 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-16822) Provide source artifacts for hadoop-client-api

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835724#comment-17835724 ] ASF GitHub Bot commented on HADOOP-16822: - pan3793 commented on PR #6719: URL:

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835728#comment-17835728 ] ASF GitHub Bot commented on HADOOP-18656: - hadoop-yetus commented on PR #6718: URL:

Re: [PR] (3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
steveloughran commented on PR #6719: URL: https://github.com/apache/hadoop/pull/6719#issuecomment-2047574043 @pan3793 interesting...though it's probably a yetus change. on long-lived patches I sometimes just delete the old ones, as really its only the last one or two which are of any

Re: [PR] HADOOP-19096: [ABFS] [CST Optimization] Enhancing Client-Side Throttling Metrics Updating Logic [hadoop]

2024-04-10 Thread via GitHub
steveloughran commented on PR #6276: URL: https://github.com/apache/hadoop/pull/6276#issuecomment-2047597319 thanks, in trunk. @anmolanmol1234 can you do a pr and retest for 3.4? I'll rebase my work on this and see how it goes -- This is an automated message from the Apache Git Service.

[jira] [Commented] (HADOOP-19096) [ABFS] Enhancing Client-Side Throttling Metrics Updation Logic

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835740#comment-17835740 ] ASF GitHub Bot commented on HADOOP-19096: - steveloughran commented on PR #6276: URL:

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6710: URL: https://github.com/apache/hadoop/pull/6710#issuecomment-2047669969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-10 Thread via GitHub
Hexiaoqiao commented on PR #6710: URL: https://github.com/apache/hadoop/pull/6710#issuecomment-2047772604 Hi @haiyang1987 . There are one spotbug find and another unit test failed at latest Yetus report which is not related to this changes, would you mind to fix it later? Thanks. --

[jira] [Updated] (HADOOP-19101) Vectored Read into off-heap buffer broken in fallback implementation

2024-04-10 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19101: Release Note: PositionedReadable.readVectored() will read incorrect data when reading

Re: [PR] (3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" [hadoop]

2024-04-10 Thread via GitHub
pan3793 commented on PR #6719: URL: https://github.com/apache/hadoop/pull/6719#issuecomment-2047470996 @steveloughran One thing not related to this patch. I saw lots of Hadoop ecosystem projects using Yetus, but its comments are too too too long, actually, GitHub supports the collapsed

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835732#comment-17835732 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2047577845 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19131) Assist reflection IO with WrappedOperations class

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835789#comment-17835789 ] ASF GitHub Bot commented on HADOOP-19131: - hadoop-yetus commented on PR #6686: URL:

Re: [PR] HDFS-17453. IncrementalBlockReport can have race condition with Edit Log Tailer [hadoop]

2024-04-10 Thread via GitHub
goiri merged PR #6708: URL: https://github.com/apache/hadoop/pull/6708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835889#comment-17835889 ] ASF GitHub Bot commented on HADOOP-18679: - mukund-thakur commented on code in PR #6494: URL:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-10 Thread via GitHub
mukund-thakur commented on code in PR #6494: URL: https://github.com/apache/hadoop/pull/6494#discussion_r1560055171 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/BulkDeleteOperationCallbacksImpl.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache

[jira] [Commented] (HADOOP-19079) check that class that is loaded is really an exception

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835981#comment-17835981 ] ASF GitHub Bot commented on HADOOP-19079: - hadoop-yetus commented on PR #6557: URL:

Re: [PR] HADOOP-19079. Check class is an exception class before constructing an instance [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6557: URL: https://github.com/apache/hadoop/pull/6557#issuecomment-2048880051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Test PR: Test Jenkins. (WIP) [hadoop]

2024-04-10 Thread via GitHub
hadoop-yetus commented on PR #6707: URL: https://github.com/apache/hadoop/pull/6707#issuecomment-2048829301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17754) Remove lock contention in overlay of Configuration

2024-04-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835951#comment-17835951 ] ASF GitHub Bot commented on HADOOP-17754: - liangxs closed pull request #3089: HADOOP-17754.

Re: [PR] HADOOP-17754. Remove lock contention in overlay of Configuration [hadoop]

2024-04-10 Thread via GitHub
liangxs closed pull request #3089: HADOOP-17754. Remove lock contention in overlay of Configuration URL: https://github.com/apache/hadoop/pull/3089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17455. Fix Client throw IndexOutOfBoundsException in DFSInputStream#fetchBlockAt [hadoop]

2024-04-10 Thread via GitHub
haiyang1987 commented on PR #6710: URL: https://github.com/apache/hadoop/pull/6710#issuecomment-2048812653 > Hi @haiyang1987 . There are one spotbug find and another unit test failed at latest Yetus report which is not related to this changes, would you mind to fix it later? Thanks.

Re: [PR] HDFS-17453. IncrementalBlockReport can have race condition with Edit Log Tailer [hadoop]

2024-04-10 Thread via GitHub
yuanboliu commented on PR #6708: URL: https://github.com/apache/hadoop/pull/6708#issuecomment-2048874743 @dannytbecker thanks for your work, I'm just wondering what's the case of three GS with one block -- This is an automated message from the Apache Git Service. To respond to the