Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2059736403 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
mukund-thakur commented on code in PR #6726: URL: https://github.com/apache/hadoop/pull/6726#discussion_r1567902648 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractBulkDelete.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache

[jira] [Commented] (HADOOP-19151) Support configurable SASL mechanism

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837881#comment-17837881 ] ASF GitHub Bot commented on HADOOP-19151: - szetszwo opened a new pull request, #6740: URL:

[jira] [Updated] (HADOOP-19151) Support configurable SASL mechanism

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19151: Labels: pull-request-available (was: ) > Support configurable SASL mechanism >

[PR] HADOOP-19151. Support configurable SASL mechanism. [hadoop]

2024-04-16 Thread via GitHub
szetszwo opened a new pull request, #6740: URL: https://github.com/apache/hadoop/pull/6740 ### Description of PR Currently, the SASL mechanism is hard coded to DIGEST-MD5. As mentioned in [HADOOP-14811](https://issues.apache.org/jira/browse/HADOOP-14811), DIGEST-MD5 is known to be

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on code in PR #6739: URL: https://github.com/apache/hadoop/pull/6739#discussion_r1567940219 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProvider.java: ## @@ -35,7 +34,6 @@ import java.util.Map; import

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837871#comment-17837871 ] ASF GitHub Bot commented on HADOOP-18679: - mukund-thakur commented on code in PR #6726: URL:

[jira] [Commented] (HADOOP-19136) Upgrade commons-io to 2.16.0

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837846#comment-17837846 ] ASF GitHub Bot commented on HADOOP-19136: - hadoop-yetus commented on PR #6704: URL:

Re: [PR] HDFS-17381. Distcp of EC files should not be limited to DFS. [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on code in PR #6551: URL: https://github.com/apache/hadoop/pull/6551#discussion_r1567914216 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableDirectoryCreateCommand.java: ## @@ -67,31 +67,13 @@ protected Object

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837904#comment-17837904 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739: URL:

[jira] [Created] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread Tsz-wo Sze (Jira)
Tsz-wo Sze created HADOOP-19152: --- Summary: Do not hard code security providers. Key: HADOOP-19152 URL: https://issues.apache.org/jira/browse/HADOOP-19152 Project: Hadoop Common Issue Type:

Re: [PR] HDFS-17367. Add PercentUsed for Different StorageTypes in JMX [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6735: URL: https://github.com/apache/hadoop/pull/6735#issuecomment-2059825741 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837923#comment-17837923 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo commented on PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2059994340 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837905#comment-17837905 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2060001044 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2060158389 > there are downstream modules which depend on bc from hadoop common. they need to be adjusted so their poms declare explicit use. ... It make sense for the downstream modules

[jira] [Commented] (HADOOP-19107) Drop support for HBase v1

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837874#comment-17837874 ] ASF GitHub Bot commented on HADOOP-19107: - steveloughran commented on code in PR #6629: URL:

[jira] [Commented] (HADOOP-19150) Test ITestAbfsRestOperationException#testAuthFailException is broken.

2024-04-16 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837883#comment-17837883 ] Steve Loughran commented on HADOOP-19150: - actually, it should be {code}

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2060155541 > the pr cuts out all bouncy castle init. What will break? @steveloughran , thanks for looking at this! As mentioned in `core-default.xml`, could we ask admin to set

Re: [PR] HADOOP-19136. Upgrade commons-io to 2.16.0. [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6704: URL: https://github.com/apache/hadoop/pull/6704#issuecomment-2059798218 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837853#comment-17837853 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo opened a new pull request, #6739: URL:

Re: [PR] HADOOP-19124. Update org.ehcache from 3.3.1 to 3.8.2. (#6665) [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on PR #6705: URL: https://github.com/apache/hadoop/pull/6705#issuecomment-2059872469 yeah, 3.3 is a different complication...if things are hard it's good to go through yetus. going from 3.5 to 3.4 locally I often locally cherrypick, run any new/changed tests and

[jira] [Commented] (HADOOP-19124) Update org.ehcache from 3.3.1 to 3.8.2.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837876#comment-17837876 ] ASF GitHub Bot commented on HADOOP-19124: - steveloughran commented on PR #6705: URL:

Re: [PR] HADOOP-19107. Drop support for HBase v1 & upgrade HBase v2 [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on code in PR #6629: URL: https://github.com/apache/hadoop/pull/6629#discussion_r1567902995 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/pom.xml: ## @@ -494,86 +489,12 @@

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837922#comment-17837922 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo commented on PR #6739: URL:

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837950#comment-17837950 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2060278478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-16 Thread via GitHub
ZanderXu opened a new pull request, #6741: URL: https://github.com/apache/hadoop/pull/6741 [FGL] UTs support fine-grained locking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] HDFS-17472. [FGL] gcDeletedSnapshot and getDelegationToken support FGL [hadoop]

2024-04-16 Thread via GitHub
ZanderXu opened a new pull request, #6743: URL: https://github.com/apache/hadoop/pull/6743 [FGL] gcDeletedSnapshot and getDelegationToken support FGL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837948#comment-17837948 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

[jira] [Commented] (HADOOP-19130) FTPFileSystem rename with full qualified path broken

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837964#comment-17837964 ] ASF GitHub Bot commented on HADOOP-19130: - zj619 commented on code in PR #6678: URL:

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837952#comment-17837952 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on PR #6617: URL:

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-16 Thread via GitHub
snvijaya commented on code in PR #6716: URL: https://github.com/apache/hadoop/pull/6716#discussion_r1567404776 ##

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ferhui commented on code in PR #6737: URL: https://github.com/apache/hadoop/pull/6737#discussion_r1568165869 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/NamenodeFGL.md: ## @@ -0,0 +1,201 @@ + + +HDFS Namenode Fine-grained Locking +== + +

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567168026 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ferhui commented on PR #6737: URL: https://github.com/apache/hadoop/pull/6737#issuecomment-2060276815 @kokonguyen191 Thanks for contribution. Left some comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
ZanderXu commented on code in PR #6737: URL: https://github.com/apache/hadoop/pull/6737#discussion_r1568168688 ## hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/NamenodeFGL.md: ## @@ -0,0 +1,201 @@ + + +HDFS Namenode Fine-grained Locking +== +

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2060283113 Hi @steveloughran , thank you a lot for the review. Have taken the comments. Have taken assertj in the new test util class. Class `ITestAbfsInputStreamFooter` is now extending

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6737: URL: https://github.com/apache/hadoop/pull/6737#issuecomment-2060343659 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19130) FTPFileSystem rename with full qualified path broken

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837963#comment-17837963 ] ASF GitHub Bot commented on HADOOP-19130: - zj619 commented on code in PR #6678: URL:

Re: [PR] HADOOP-19130. FTPFileSystem rename with full qualified path broken [hadoop]

2024-04-16 Thread via GitHub
zj619 commented on code in PR #6678: URL: https://github.com/apache/hadoop/pull/6678#discussion_r1568219463 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ftp/FTPFileSystem.java: ## @@ -685,21 +685,21 @@ private boolean rename(FTPClient client, Path

Re: [PR] HADOOP-19130. FTPFileSystem rename with full qualified path broken [hadoop]

2024-04-16 Thread via GitHub
zj619 commented on code in PR #6678: URL: https://github.com/apache/hadoop/pull/6678#discussion_r1568220170 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/ftp/TestFTPFileSystem.java: ## @@ -60,6 +62,9 @@ public class TestFTPFileSystem { @Rule

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837741#comment-17837741 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2059240094 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2059255931 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues [hadoop]

2024-04-16 Thread via GitHub
slfan1989 commented on code in PR #6732: URL: https://github.com/apache/hadoop/pull/6732#discussion_r1567460352 ##

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837744#comment-17837744 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617: URL:

[PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu opened a new pull request, #6736: URL: https://github.com/apache/hadoop/pull/6736 ### Description of PR Hadoop 3.2 introduced optimization features for HDFS StringTable (b60ca37914b22550e3630fa02742d40697decb3), It resulted in lower versions of Hadoop upgraded to 3.2 and

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
anmolanmol1234 commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1566774019 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -128,6 +133,15 @@ public class AbfsInputStream

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837561#comment-17837561 ] ASF GitHub Bot commented on HADOOP-19139: - anmolanmol1234 commented on code in PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
anmolanmol1234 commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1566892429 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsInputStreamStatistics.java: ## @@ -227,15 +227,23 @@ public void

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
hiwangzhihui commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1566889645 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SerialNumberManager.java: ## @@ -115,6 +119,36 @@ public static StringTable

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837564#comment-17837564 ] ASF GitHub Bot commented on HADOOP-19139: - anmolanmol1234 commented on code in PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2058560721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837605#comment-17837605 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567064541 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java: ## @@ -114,6 +117,75 @@ public static T awaitFuture(final

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837628#comment-17837628 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567089420 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837637#comment-17837637 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567090171 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2058754745 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567171371 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsInputStreamReadFooter.java: ## @@ -54,9 +63,44 @@ public class

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837676#comment-17837676 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567203473 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java: ## @@ -628,25 +638,59 @@ private void

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2058878425 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6352: URL: https://github.com/apache/hadoop/pull/6352#issuecomment-2058742919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
kokonguyen191 opened a new pull request, #6737: URL: https://github.com/apache/hadoop/pull/6737 ### Description of PR Documentation for FGL. Contains basic design description and related config. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837674#comment-17837674 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567066497 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837629#comment-17837629 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837630#comment-17837630 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837632#comment-17837632 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837639#comment-17837639 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837638#comment-17837638 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on code in PR #6617: URL:

[jira] [Commented] (HADOOP-19130) FTPFileSystem rename with full qualified path broken

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837648#comment-17837648 ] ASF GitHub Bot commented on HADOOP-19130: - ayushtkn commented on code in PR #6678: URL:

Re: [PR] HADOOP-19130. FTPFileSystem rename with full qualified path broken [hadoop]

2024-04-16 Thread via GitHub
ayushtkn commented on code in PR #6678: URL: https://github.com/apache/hadoop/pull/6678#discussion_r1567096724 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/ftp/TestFTPFileSystem.java: ## @@ -236,4 +241,52 @@ public void testFTPSetTimeout() {

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567168026 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the

Re: [PR] HADOOP-19130. FTPFileSystem rename with full qualified path broken [hadoop]

2024-04-16 Thread via GitHub
hiwangzhihui commented on PR #6678: URL: https://github.com/apache/hadoop/pull/6678#issuecomment-2058653715 @ayushtkn I have checked it and there is no problem; Please help to merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567074053 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567198629 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclEntryStatusFormat.java: ## @@ -47,7 +47,7 @@ public enum AclEntryStatusFormat

Re: [PR] HDFS-17367. Add PercentUsed for Different StorageTypes in JMX [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6735: URL: https://github.com/apache/hadoop/pull/6735#issuecomment-2058881480 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837682#comment-17837682 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617: URL:

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567205509 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SerialNumberManager.java: ## @@ -115,6 +119,36 @@ public static StringTable

[jira] [Commented] (HADOOP-19130) FTPFileSystem rename with full qualified path broken

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837625#comment-17837625 ] ASF GitHub Bot commented on HADOOP-19130: - hiwangzhihui commented on PR #6678: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567063343 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java: ## @@ -114,6 +117,75 @@ public static T awaitFuture(final

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
saxenapranav commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1567087997 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamTestUtils.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-16 Thread via GitHub
anmolanmol1234 commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1566892915 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsInputStreamStatistics.java: ## @@ -227,15 +227,23 @@ public void

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837661#comment-17837661 ] ASF GitHub Bot commented on HADOOP-19139: - anmolanmol1234 commented on code in PR #6699: URL:

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
kokonguyen191 commented on PR #6737: URL: https://github.com/apache/hadoop/pull/6737#issuecomment-2058823041 @ZanderXu Please take a look. Written based on the google docs in the main ticket -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
steveloughran opened a new pull request, #6738: URL: https://github.com/apache/hadoop/pull/6738 ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837710#comment-17837710 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran opened a new pull request, #6738: URL:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on PR #6738: URL: https://github.com/apache/hadoop/pull/6738#issuecomment-2059110117 This is #6726 with another commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837716#comment-17837716 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran commented on PR #6738: URL:

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837717#comment-17837717 ] ASF GitHub Bot commented on HADOOP-18679: - steveloughran commented on code in PR #6726: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2059115354 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837718#comment-17837718 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617: URL:

Re: [PR] HDFS-17459. [FGL] Add documentation [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6737: URL: https://github.com/apache/hadoop/pull/6737#issuecomment-2059128762 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on PR #6726: URL: https://github.com/apache/hadoop/pull/6726#issuecomment-2059138849 commented. I've also done a PR #6738 which tunes the API to work with iceberg, having just written a PoC of the iceberg binding. My PR * moved the wrapper methods to a new

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-16 Thread via GitHub
steveloughran commented on PR #6676: URL: https://github.com/apache/hadoop/pull/6676#issuecomment-2059164245 @anujmodi2021 can you do a PR for this for branch-3.4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   >