Re: [PR] HADOOP-19151. Support configurable SASL mechanism. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6740: URL: https://github.com/apache/hadoop/pull/6740#issuecomment-2072641545 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6738: URL: https://github.com/apache/hadoop/pull/6738#issuecomment-2072921149 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840157#comment-17840157 ] ASF GitHub Bot commented on HADOOP-18679: - hadoop-yetus commented on PR #6738: URL:

[jira] [Commented] (HADOOP-19151) Support configurable SASL mechanism

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840131#comment-17840131 ] ASF GitHub Bot commented on HADOOP-19151: - hadoop-yetus commented on PR #6740: URL:

Re: [PR] HDFS-17484. Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when they are not busy actually. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6758: URL: https://github.com/apache/hadoop/pull/6758#issuecomment-2072683616 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2072565481 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840126#comment-17840126 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739: URL:

[jira] [Commented] (HADOOP-19151) Support configurable SASL mechanism

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840152#comment-17840152 ] ASF GitHub Bot commented on HADOOP-19151: - szetszwo commented on PR #6740: URL:

[jira] [Created] (HADOOP-19157) [ABFS] Filesystem contract tests to use methodPath for robust parallel test runs

2024-04-23 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19157: --- Summary: [ABFS] Filesystem contract tests to use methodPath for robust parallel test runs Key: HADOOP-19157 URL: https://issues.apache.org/jira/browse/HADOOP-19157

Re: [PR] HDFS-17496. DataNode supports more fine-grained dataset lock based on blockid. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6764: URL: https://github.com/apache/hadoop/pull/6764#issuecomment-2072671948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840143#comment-17840143 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo commented on code in PR #6739: URL:

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840144#comment-17840144 ] ASF GitHub Bot commented on HADOOP-19152: - szetszwo commented on code in PR #6739: URL:

Re: [PR] HDFS-17496. DataNode supports more fine-grained dataset lock based on blockid. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6764: URL: https://github.com/apache/hadoop/pull/6764#issuecomment-2072709220 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19151. Support configurable SASL mechanism. [hadoop]

2024-04-23 Thread via GitHub
szetszwo commented on PR #6740: URL: https://github.com/apache/hadoop/pull/6740#issuecomment-2072883206 The mvnsite failure is not related to this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HADOOP-19150: [ABFS] Fixing Test Code for ITestAbfsRestOperationException#testAuthFailException [hadoop]

2024-04-23 Thread via GitHub
mukund-thakur commented on PR #6756: URL: https://github.com/apache/hadoop/pull/6756#issuecomment-2072900446 Not sure what is wrong with Yetus here. can you please add an empty commit such that yetus run again. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HADOOP-19150) Test ITestAbfsRestOperationException#testAuthFailException is broken.

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840155#comment-17840155 ] ASF GitHub Bot commented on HADOOP-19150: - mukund-thakur commented on PR #6756: URL:

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-23 Thread via GitHub
steveloughran commented on PR #6716: URL: https://github.com/apache/hadoop/pull/6716#issuecomment-2072467711 One thing I'm considering here, make that "initial attempt at base dir delete" a numeric threshold. good: agile bad: harder to test, less consistent; harder to replicate

[jira] [Commented] (HADOOP-19157) [ABFS] Filesystem contract tests to use methodPath for robust parallel test runs

2024-04-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840122#comment-17840122 ] Steve Loughran commented on HADOOP-19157: - note: this is not a problem with abfs -it just has

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-23 Thread via GitHub
szetszwo commented on code in PR #6739: URL: https://github.com/apache/hadoop/pull/6739#discussion_r1576476164 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoUtils.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-23 Thread via GitHub
szetszwo commented on code in PR #6739: URL: https://github.com/apache/hadoop/pull/6739#discussion_r1576476989 ## hadoop-common-project/hadoop-common/src/main/resources/core-default.xml: ## @@ -3625,7 +3625,19 @@ The switch to turn S3A auditing on or off. The JCE provider

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2072822967 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6763: URL: https://github.com/apache/hadoop/pull/6763#issuecomment-2071588551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839982#comment-17839982 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6763: URL:

[jira] [Created] (HADOOP-19155) Fix TestZKSignerSecretProvider failing unit test

2024-04-23 Thread kuper (Jira)
kuper created HADOOP-19155: -- Summary: Fix TestZKSignerSecretProvider failing unit test Key: HADOOP-19155 URL: https://issues.apache.org/jira/browse/HADOOP-19155 Project: Hadoop Common Issue Type:

[jira] [Commented] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839964#comment-17839964 ] ASF GitHub Bot commented on HADOOP-19146: - hadoop-yetus commented on PR #6723: URL:

Re: [PR] HADOOP-19146 noaa-cors-pds bucket access with global endpoint fails [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6723: URL: https://github.com/apache/hadoop/pull/6723#issuecomment-2071522327 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues [hadoop]

2024-04-23 Thread via GitHub
tomicooler commented on code in PR #6732: URL: https://github.com/apache/hadoop/pull/6732#discussion_r1575731004 ##

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-23 Thread via GitHub
saxenapranav commented on PR #6763: URL: https://github.com/apache/hadoop/pull/6763#issuecomment-2071475267 -- AGGREGATED TEST RESULT HNS-OAuth

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-23 Thread via GitHub
saxenapranav commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2071476916 Thank you @steveloughran very much! Have opened a PR against branch-3.4 https://github.com/apache/hadoop/pull/6763. Thank you! -- This is an automated message from the Apache Git

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839951#comment-17839951 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on PR #6763: URL:

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839952#comment-17839952 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on PR #6617: URL:

Re: [PR] HDFS-17488. DN can fail IBRs with NPE when a volume is removed [hadoop]

2024-04-23 Thread via GitHub
kokonguyen191 commented on PR #6759: URL: https://github.com/apache/hadoop/pull/6759#issuecomment-2071495428 Hi @ZanderXu @Hexiaoqiao, can you help me take a look whenever you're free? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2071517523 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839962#comment-17839962 ] ASF GitHub Bot commented on HADOOP-19137: - hadoop-yetus commented on PR #6752: URL:

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6753: URL: https://github.com/apache/hadoop/pull/6753#issuecomment-2071566319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19154) upgrade bouncy castle to 1.78.1 due to CVEs

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840199#comment-17840199 ] ASF GitHub Bot commented on HADOOP-19154: - hadoop-yetus commented on PR #6755: URL:

Re: [PR] HADOOP-19154. Upgrade bouncycastle to 1.78.1 due to CVEs [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6755: URL: https://github.com/apache/hadoop/pull/6755#issuecomment-2073215984 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] [DRAFT] Jackson 2.14 [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6761: URL: https://github.com/apache/hadoop/pull/6761#issuecomment-2073319770 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17497. The number of bytes of the last committed block should be calculated into the file length [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6765: URL: https://github.com/apache/hadoop/pull/6765#issuecomment-2073379567 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2073100512 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840214#comment-17840214 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2073325889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-23 Thread via GitHub
steveloughran commented on code in PR #6739: URL: https://github.com/apache/hadoop/pull/6739#discussion_r1576632095 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoUtils.java: ## @@ -19,53 +19,63 @@ import

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840167#comment-17840167 ] ASF GitHub Bot commented on HADOOP-19152: - steveloughran commented on code in PR #6739: URL:

Re: [PR] HDFS-17367. Add PercentUsed for Different StorageTypes in JMX [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6735: URL: https://github.com/apache/hadoop/pull/6735#issuecomment-2073091922 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17470. FsVolumeList#getNextVolume can be moved out of DataSetLock. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6733: URL: https://github.com/apache/hadoop/pull/6733#issuecomment-2073412719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2073373773 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6732: URL: https://github.com/apache/hadoop/pull/6732#issuecomment-2073537387 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19131) Assist reflection IO with WrappedOperations class

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840242#comment-17840242 ] ASF GitHub Bot commented on HADOOP-19131: - hadoop-yetus commented on PR #6686: URL:

Re: [PR] HDFS-17469. Audit log for reportBadBlocks RPC [hadoop]

2024-04-23 Thread via GitHub
ZanderXu merged PR #6731: URL: https://github.com/apache/hadoop/pull/6731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17497. The number of bytes of the last committed block should be calculated into the file length [hadoop]

2024-04-23 Thread via GitHub
ZanderXu commented on PR #6765: URL: https://github.com/apache/hadoop/pull/6765#issuecomment-2073863664 @xkrogen master, I very much hope you can review this PR when you are available, since you are familiar with ~~HDFS-10843~~ -- This is an automated message from the Apache Git Service.

Re: [PR] HDFS-17467. IncrementalBlockReportManager#getPerStorageIBR may throw NPE when remove volumes. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6730: URL: https://github.com/apache/hadoop/pull/6730#issuecomment-2073563142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2073589561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17466. Move FsVolumeList#getVolumes() invocation out of DataSetLock [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6728: URL: https://github.com/apache/hadoop/pull/6728#issuecomment-2073685786 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17469. Audit log for reportBadBlocks RPC [hadoop]

2024-04-23 Thread via GitHub
ZanderXu commented on PR #6731: URL: https://github.com/apache/hadoop/pull/6731#issuecomment-2073830839 Merged. Thanks @cxzl25 for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-19140) [ABFS, S3A] Add IORateLimiter api to hadoop common

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840237#comment-17840237 ] ASF GitHub Bot commented on HADOOP-19140: - hadoop-yetus commented on PR #6703: URL:

Re: [PR] HADOOP-19140. [ABFS, S3A] Add IORateLimiter API [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6703: URL: https://github.com/apache/hadoop/pull/6703#issuecomment-2073517148 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17469. Audit log for reportBadBlocks RPC [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6731: URL: https://github.com/apache/hadoop/pull/6731#issuecomment-2073517962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19147. Update ISA-L to 2.31.0 in the build image. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6729: URL: https://github.com/apache/hadoop/pull/6729#issuecomment-2073593403 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19147) Update ISA-L to 2.31.0 in the build image

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840243#comment-17840243 ] ASF GitHub Bot commented on HADOOP-19147: - hadoop-yetus commented on PR #6729: URL:

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6716: URL: https://github.com/apache/hadoop/pull/6716#issuecomment-2073739524 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17467. IncrementalBlockReportManager#getPerStorageIBR may throw NPE when remove volumes. [hadoop]

2024-04-23 Thread via GitHub
ZanderXu commented on PR #6730: URL: https://github.com/apache/hadoop/pull/6730#issuecomment-2073833703 @hfutatzhanghb thanks for your report. It looks like HDFS-17488. Let's review HDFS-17488 together to fix this bug if you have time. Thanks -- This is an automated message from the

Re: [PR] HDFS-17467. IncrementalBlockReportManager#getPerStorageIBR may throw NPE when remove volumes. [hadoop]

2024-04-23 Thread via GitHub
hfutatzhanghb commented on PR #6730: URL: https://github.com/apache/hadoop/pull/6730#issuecomment-2073859407 > @hfutatzhanghb thanks for your report. It looks like [HDFS-17488](https://issues.apache.org/jira/browse/HDFS-17488). Let's review

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840274#comment-17840274 ] ASF GitHub Bot commented on HADOOP-18679: - hadoop-yetus commented on PR #6726: URL:

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6726: URL: https://github.com/apache/hadoop/pull/6726#issuecomment-2073964537 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840287#comment-17840287 ] ASF GitHub Bot commented on HADOOP-19146: - hadoop-yetus commented on PR #6723: URL:

Re: [PR] HADOOP-19145. Add software architecture document [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6712: URL: https://github.com/apache/hadoop/pull/6712#issuecomment-2074047351 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17456. Fix the dfsused statistics of datanode are incorrect when appending a file. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6713: URL: https://github.com/apache/hadoop/pull/6713#issuecomment-2074088648 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-23 Thread via GitHub
saxenapranav commented on code in PR #6716: URL: https://github.com/apache/hadoop/pull/6716#discussion_r1577262719 ##

Re: [PR] HADOOP-19155. Fix TestZKSignerSecretProvider failing unit test [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6766: URL: https://github.com/apache/hadoop/pull/6766#issuecomment-2074049822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19145) Software Architecture Document

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840288#comment-17840288 ] ASF GitHub Bot commented on HADOOP-19145: - hadoop-yetus commented on PR #6712: URL:

[jira] [Commented] (HADOOP-19155) Fix TestZKSignerSecretProvider failing unit test

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840289#comment-17840289 ] ASF GitHub Bot commented on HADOOP-19155: - hadoop-yetus commented on PR #6766: URL:

[jira] [Updated] (HADOOP-19155) Fix TestZKSignerSecretProvider failing unit test

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19155: Labels: pull-request-available (was: ) > Fix TestZKSignerSecretProvider failing unit

Re: [PR] HDFS-17464. Improve some logs output in class FsDatasetImpl [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6724: URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2074072638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[PR] Fix TestZKSignerSecretProvider failing unit test [hadoop]

2024-04-23 Thread via GitHub
gp1314 opened a new pull request, #6766: URL: https://github.com/apache/hadoop/pull/6766 ### Description of PR - TestZKSignerSecretProvider and TestRandomSignerSecretProvider{} unit test occasional failure - The reason was that the MockZKSignerSecretProvider class

Re: [PR] HDFS-17462. Fix NPE in Router concat when trg is an empty ile [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6722: URL: https://github.com/apache/hadoop/pull/6722#issuecomment-2074005099 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19146 noaa-cors-pds bucket access with global endpoint fails [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6723: URL: https://github.com/apache/hadoop/pull/6723#issuecomment-2074047003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17464. Improve some logs output in class FsDatasetImpl [hadoop]

2024-04-23 Thread via GitHub
hfutatzhanghb commented on PR #6724: URL: https://github.com/apache/hadoop/pull/6724#issuecomment-2074091225 @zhangshuyan0 @ZanderXu @haiyang1987 Hi, sir. please help me reivew this simple modification when you have free time, thanks~ -- This is an automated message from the Apache Git

Re: [PR] HDFS-17367. Add PercentUsed for Different StorageTypes in JMX [hadoop]

2024-04-23 Thread via GitHub
haiyang1987 commented on code in PR #6735: URL: https://github.com/apache/hadoop/pull/6735#discussion_r1576147893 ## hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md: ## @@ -326,6 +326,15 @@ Each metrics record contains tags such as HAState and Hostname as

Re: [PR] HDFS-17488. DN can fail IBRs with NPE when a volume is removed [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6759: URL: https://github.com/apache/hadoop/pull/6759#issuecomment-2072209318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17367. Add PercentUsed for Different StorageTypes in JMX [hadoop]

2024-04-23 Thread via GitHub
zhtttylz commented on code in PR #6735: URL: https://github.com/apache/hadoop/pull/6735#discussion_r1576202576 ## hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md: ## @@ -326,6 +326,15 @@ Each metrics record contains tags such as HAState and Hostname as

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-23 Thread via GitHub
steveloughran commented on code in PR #6716: URL: https://github.com/apache/hadoop/pull/6716#discussion_r1576221197 ##

Re: [PR] MAPREDUCE-7474. Improve Manifest committer resilience [hadoop]

2024-04-23 Thread via GitHub
steveloughran commented on code in PR #6716: URL: https://github.com/apache/hadoop/pull/6716#discussion_r1576225937 ## hadoop-tools/hadoop-azure/pom.xml: ## @@ -45,6 +45,8 @@ 7200 10 1000 + +100 Review Comment: this is for maven test runs only. s3a

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839987#comment-17839987 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on PR #6699: URL:

Re: [PR] HDFS-17488. DN can fail IBRs with NPE when a volume is removed [hadoop]

2024-04-23 Thread via GitHub
ZanderXu commented on code in PR #6759: URL: https://github.com/apache/hadoop/pull/6759#discussion_r1575829376 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/IncrementalBlockReportManager.java: ## @@ -169,11 +169,17 @@ private

Re: [PR] YARN-11686. Correct traversing indexs when scheduling asynchronously using Capacity Scheduler [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6750: URL: https://github.com/apache/hadoop/pull/6750#issuecomment-2071760148 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17484. Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when they are not busy actually. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6758: URL: https://github.com/apache/hadoop/pull/6758#issuecomment-2071762108 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17476. fix: False positive "Observer Node is too far behind" due to long overflow. [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6747: URL: https://github.com/apache/hadoop/pull/6747#issuecomment-2071793284 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2071857509 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840039#comment-17840039 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6732: URL: https://github.com/apache/hadoop/pull/6732#issuecomment-2071872714 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-19156) ZooKeeper based state stores use different ZK address configs

2024-04-23 Thread liu bin (Jira)
liu bin created HADOOP-19156: Summary: ZooKeeper based state stores use different ZK address configs Key: HADOOP-19156 URL: https://issues.apache.org/jira/browse/HADOOP-19156 Project: Hadoop Common

Re: [PR] HDFS-17451. RBF: fix spotbugs for redundant nullcheck of dns. [hadoop]

2024-04-23 Thread via GitHub
haiyang1987 commented on PR #6697: URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2072033364 Committed to trunk. Thanks @KeeProMise for your contributions! and @ZanderXu @simbadzina @ayushtkn @slfan1989 review! -- This is an automated message from the Apache Git Service. To

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-23 Thread via GitHub
steveloughran merged PR #6763: URL: https://github.com/apache/hadoop/pull/6763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-19102. - Fix Version/s: 3.5.0 3.4.1 Resolution: Fixed > [ABFS]:

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840073#comment-17840073 ] ASF GitHub Bot commented on HADOOP-19102: - steveloughran merged PR #6763: URL:

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840076#comment-17840076 ] ASF GitHub Bot commented on HADOOP-19152: - steveloughran commented on code in PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-23 Thread via GitHub
steveloughran commented on code in PR #6739: URL: https://github.com/apache/hadoop/pull/6739#discussion_r1576126175 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoUtils.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6753: URL: https://github.com/apache/hadoop/pull/6753#issuecomment-2072124888 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17475. Add verifyReadable command to check if files are readable [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6745: URL: https://github.com/apache/hadoop/pull/6745#issuecomment-2072123314 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

  1   2   >