date:20121029


 [ 
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8957:
--

 Target Version/s: 3.0.0, trunk-win  (was: trunk-win)
Affects Version/s: 3.0.0

 FileContext.getFileContext causes multiple test failures on Windows due to 
 InvocationTargetException
 

 Key: HADOOP-8957
 URL: https://issues.apache.org/jira/browse/HADOOP-8957
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth

 This appears to be a problem with parsing a Windows-specific path, ultimately 
 throwing InvocationTargetException from AbstractFileSystem.newInstance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HADOOP-8990) Some minor issus in protobuf based ipc

2012-10-29 Thread Binglin Chang (JIRA)

Binglin Chang created HADOOP-8990:
-

 Summary: Some minor issus in protobuf based ipc
 Key: HADOOP-8990
 URL: https://issues.apache.org/jira/browse/HADOOP-8990
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Binglin Chang
Priority: Minor


1. proto file naming
RpcPayloadHeader.proto include not only RpcPayLoadHeader, but also 
RpcResponseHeaderProto, which is irrelevant to the file name.
hadoop_rpc.proto only include HadoopRpcRequestProto, and the filename 
hadoop_rpc is strange comparing to other .proto file names.
How about merge those two file into HadoopRpc.proto?

2. proto class naming
In rpc request RpcPayloadHeader includes callId, but in rpc response callId is 
included in RpcResponseHeader, and there is also HadoopRpcRequestHeader, this 
is just too confusing.

3. The rpc system is not fully protobuf based, there are still some Writables:
RpcRequestWritable and RpcResponseWritable.
rpc response exception name and stack trace string.
And RpcRequestWritable uses protobuf style varint32 prefix, but 
RpcResponseWritable uses int32 prefix, why this inconsistency?

Currently rpc request is splitted into length, PayLoadHeader and PayLoad, and 
response into RpcResponseHeader, response and error message. 
I think wrap request and response into single RequstProto and ResponseProto is 
better, cause this gives a formal complete wire format definition, 
or developer need to look into the source code and hard coding the 
communication format.

These issues above make it very confusing and hard for developers to use these 
rpc interfaces.

Some of these issues can be solved without breaking compatibility, but some can 
not, but at least we need to know what will be changed and what will stay 
stable?



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException


 [ 
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8957:
--

Status: Patch Available  (was: Open)

 FileContext.getFileContext causes multiple test failures on Windows due to 
 InvocationTargetException
 

 Key: HADOOP-8957
 URL: https://issues.apache.org/jira/browse/HADOOP-8957
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8957.patch


 This appears to be a problem with parsing a Windows-specific path, ultimately 
 throwing InvocationTargetException from AbstractFileSystem.newInstance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException

[
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HADOOP-8957:
--

Attachment: HADOOP-8957.patch

The attached patch fixes multiple bugs in ViewFS when running on Windows. I'd
like to start the patch on trunk and then immediately merge to branch-trunk-win
after commit. Here is a summary of the changes:

# AbstractFileSystem.isValidName was catching file names with ':' as invalid.
This is not correct on a local file system on Windows, where ':' is valid in a
drive specification. To fix this, I refactored isValidName such that only HDFS
(and not other file systems like local) enforce these rules. I added new tests
to check that this worked. I also enhanced a test in TestDFSUtil.
# ChRootedFs was calling Path.toString and then trimming the first character to
remove the first slash. On Windows, if the Path has a drive specification,
then toString removes the first slash. Instead, we can use
Path.toUri().getPath().
# ViewFileSystem.InternalDirOfViewFs.getFileStatus contained a call to
Path.makeQualified with a null working directory. This throws
NullPointerException if the default URI is not absolute. This condition can
happen on Windows, where the tree of paths can transition from absolute to
relative to absolute. (/ is absolute, /C: is relative, and /C:/foo is
absolute.) To fix this, we can resolve against / for the working directory
instead of null.

FileContext.getFileContext causes multiple test failures on Windows due to
InvocationTargetException

Key: HADOOP-8957
URL: https://issues.apache.org/jira/browse/HADOOP-8957
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: HADOOP-8957.patch

This appears to be a problem with parsing a Windows-specific path, ultimately
throwing InvocationTargetException from AbstractFileSystem.newInstance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8958) ViewFs:Non absolute mount name failures when running multiple tests on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8958:
--

 Target Version/s: 3.0.0, trunk-win  (was: trunk-win)
Affects Version/s: 3.0.0

 ViewFs:Non absolute mount name failures when running multiple tests on Windows
 --

 Key: HADOOP-8958
 URL: https://issues.apache.org/jira/browse/HADOOP-8958
 Project: Hadoop Common
  Issue Type: Bug
  Components: viewfs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth

 This appears to be an issue with parsing a Windows-specific path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8958) ViewFs:Non absolute mount name failures when running multiple tests on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8958:
--

Attachment: HADOOP-8958.patch

The attached patch fixes this problem.  I'd like to start the patch on trunk 
and then immediately merge to branch-trunk-win after commit.

The problem was that the tests attempted to determine a testing mount point for 
ViewFS by taking the testing path and trimming the first segment from that.  On 
Windows, if the testing path is /C:/build/test, then this logic yields /C:, 
which is not an absolute path.  The ViewFS mount point must be an absolute 
path.  I changed this logic to use Path and walk up the directory hierarchy to 
the shortest absolute path that is not root.


 ViewFs:Non absolute mount name failures when running multiple tests on Windows
 --

 Key: HADOOP-8958
 URL: https://issues.apache.org/jira/browse/HADOOP-8958
 Project: Hadoop Common
  Issue Type: Bug
  Components: viewfs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8958.patch


 This appears to be an issue with parsing a Windows-specific path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8958) ViewFs:Non absolute mount name failures when running multiple tests on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8958:
--

Status: Patch Available  (was: Open)

 ViewFs:Non absolute mount name failures when running multiple tests on Windows
 --

 Key: HADOOP-8958
 URL: https://issues.apache.org/jira/browse/HADOOP-8958
 Project: Hadoop Common
  Issue Type: Bug
  Components: viewfs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8958.patch


 This appears to be an issue with parsing a Windows-specific path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8957) FileContext.getFileContext causes multiple test failures on Windows due to InvocationTargetException


[ 
https://issues.apache.org/jira/browse/HADOOP-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485914#comment-13485914
 ] 

Hadoop QA commented on HADOOP-8957:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12551168/HADOOP-8957.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1681//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1681//console

This message is automatically generated.

 FileContext.getFileContext causes multiple test failures on Windows due to 
 InvocationTargetException
 

 Key: HADOOP-8957
 URL: https://issues.apache.org/jira/browse/HADOOP-8957
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8957.patch


 This appears to be a problem with parsing a Windows-specific path, ultimately 
 throwing InvocationTargetException from AbstractFileSystem.newInstance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8958) ViewFs:Non absolute mount name failures when running multiple tests on Windows


[ 
https://issues.apache.org/jira/browse/HADOOP-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485933#comment-13485933
 ] 

Hadoop QA commented on HADOOP-8958:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12551169/HADOOP-8958.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1682//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1682//console

This message is automatically generated.

 ViewFs:Non absolute mount name failures when running multiple tests on Windows
 --

 Key: HADOOP-8958
 URL: https://issues.apache.org/jira/browse/HADOOP-8958
 Project: Hadoop Common
  Issue Type: Bug
  Components: viewfs
Affects Versions: 3.0.0, trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8958.patch


 This appears to be an issue with parsing a Windows-specific path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8847) Change untar to use Java API instead of spawning tar process

2012-10-29 Thread Bikas Saha (JIRA)


[ 
https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485975#comment-13485975
 ] 

Bikas Saha commented on HADOOP-8847:


Ping

 Change untar to use Java API instead of spawning tar process
 

 Key: HADOOP-8847
 URL: https://issues.apache.org/jira/browse/HADOOP-8847
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Bikas Saha
Assignee: Bikas Saha
 Attachments: HADOOP-8847.branch-1-win.1.patch, 
 HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz


 Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be 
 present on all platforms by default eg. Windows. So changing this to use JAVA 
 API's would help make it more cross-platform. FileUtil.unZip() uses the same 
 approach.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8456) Support spaces in user names and group names in results returned via winutils


[ 
https://issues.apache.org/jira/browse/HADOOP-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486053#comment-13486053
 ] 

Daryn Sharp commented on HADOOP-8456:
-

Let me investigate a bit further.

 Support spaces in user names and group names in results returned via winutils
 -

 Key: HADOOP-8456
 URL: https://issues.apache.org/jira/browse/HADOOP-8456
 Project: Hadoop Common
  Issue Type: Bug
  Components: native
Affects Versions: 1-win
Reporter: Chuan Liu
Assignee: Ivan Mitic
Priority: Minor
 Attachments: HADOOP-8456.branch-1-win.spaces.patch


 When parsing results returned by ‘ls’, we made implicit assumption that user 
 and group names cannot contain spaces. On Linux, spaces are not allowed in 
 user names and group names. This is not the case for Windows. We need to find 
 a way to fix the problem for Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8963) CopyFromLocal doesn't always create user directory


[ 
https://issues.apache.org/jira/browse/HADOOP-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486078#comment-13486078
 ] 

Daryn Sharp commented on HADOOP-8963:
-

Please add a few tests cases to make sure the overwrite flag is honored.

 CopyFromLocal doesn't always create user directory
 --

 Key: HADOOP-8963
 URL: https://issues.apache.org/jira/browse/HADOOP-8963
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.3
Reporter: Billie Rinaldi
Assignee: Arpit Gupta
Priority: Trivial
 Attachments: HADOOP-8963.branch-1.patch, HADOOP-8963.branch-1.patch, 
 HADOOP-8963.branch-1.patch


 When you use the command hadoop fs -copyFromLocal filename . before the 
 /user/username directory has been created, the file is created with name 
 /user/username instead of a directory being created with file 
 /user/username/filename.  The command hadoop fs -copyFromLocal filename 
 filename works as expected, creating /user/username and 
 /user/username/filename, and hadoop fs -copyFromLocal filename . works as 
 expected if the /user/username directory already exists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8779) Use tokens regardless of authentication type


[ 
https://issues.apache.org/jira/browse/HADOOP-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486088#comment-13486088
 ] 

Daryn Sharp commented on HADOOP-8779:
-

bq.  This might work. isSecurityEnabled is extensively used in the code base. 
Pls make sure the new semantics fits in all cases (especially where it might be 
used to mean Kerberos is enabled).

Yes, this is exactly what I'm doing. :)

 Use tokens regardless of authentication type
 

 Key: HADOOP-8779
 URL: https://issues.apache.org/jira/browse/HADOOP-8779
 Project: Hadoop Common
  Issue Type: New Feature
  Components: fs, security
Affects Versions: 3.0.0, 2.0.2-alpha
Reporter: Daryn Sharp
Assignee: Daryn Sharp

 Security is a combination of authentication and authorization (tokens).  
 Authorization may be granted independently of the authentication model.  
 Tokens should be used regardless of simple or kerberos authentication.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HADOOP-8991) Add support for SASL PLAIN authentication

Daryn Sharp created HADOOP-8991:
---

 Summary: Add support for SASL PLAIN authentication
 Key: HADOOP-8991
 URL: https://issues.apache.org/jira/browse/HADOOP-8991
 Project: Hadoop Common
  Issue Type: Sub-task
  Components: ipc
Reporter: Daryn Sharp
Assignee: Daryn Sharp


Adding SASL PLAIN auth will allow {{isSecurityEnabled}} to mean SASL is active 
instead of only meaning kerberos is enabled.  SASL will always require tokens.  
PLAIN will be the same as SIMPLE, with the added requirement of tokens.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8963) CopyFromLocal doesn't always create user directory

2012-10-29 Thread Arpit Gupta (JIRA)


[ 
https://issues.apache.org/jira/browse/HADOOP-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486178#comment-13486178
 ] 

Arpit Gupta commented on HADOOP-8963:
-

Thanks for the feedback Daryn. I will incorporate it and add more tests.

 CopyFromLocal doesn't always create user directory
 --

 Key: HADOOP-8963
 URL: https://issues.apache.org/jira/browse/HADOOP-8963
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.3
Reporter: Billie Rinaldi
Assignee: Arpit Gupta
Priority: Trivial
 Attachments: HADOOP-8963.branch-1.patch, HADOOP-8963.branch-1.patch, 
 HADOOP-8963.branch-1.patch


 When you use the command hadoop fs -copyFromLocal filename . before the 
 /user/username directory has been created, the file is created with name 
 /user/username instead of a directory being created with file 
 /user/username/filename.  The command hadoop fs -copyFromLocal filename 
 filename works as expected, creating /user/username and 
 /user/username/filename, and hadoop fs -copyFromLocal filename . works as 
 expected if the /user/username directory already exists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8986) Server$Call object is never released after it is sent

[
https://issues.apache.org/jira/browse/HADOOP-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Joseph Evans updated HADOOP-8986:

Description: When an IPC response cannot be returned without blocking an
Server$Call object is attached to the SelectionKey of the write selector.
However the call object is never removed from the SlectionKey. So for a
connection that rarely has large responses but is long lived there is a lot of
data. (was: When an IPC response cannot be returned without blocking the
Server$Call object attached to the SelectionKey of the write selector. However
the call object is never removed from the SlectionKey. So for a connection that
rarely has large responses but is long lived there is a lot of data.)

Server$Call object is never released after it is sent
-

Key: HADOOP-8986
URL: https://issues.apache.org/jira/browse/HADOOP-8986
Project: Hadoop Common
Issue Type: Bug
Components: ipc
Affects Versions: 2.0.2-alpha, 0.23.4
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Critical

When an IPC response cannot be returned without blocking an Server$Call
object is attached to the SelectionKey of the write selector. However the
call object is never removed from the SlectionKey. So for a connection that
rarely has large responses but is long lived there is a lot of data.

[jira] [Commented] (HADOOP-8456) Support spaces in user names and group names in results returned via winutils

2012-10-29 Thread Allen Wittenauer (JIRA)

[
https://issues.apache.org/jira/browse/HADOOP-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486234#comment-13486234
]

Allen Wittenauer commented on HADOOP-8456:
--

bq. Generally, we want to natively integrate Hadoop with Windows, in a sense
that Windows user/group information flows thru Hadoop.

bq. Let me know if this makes sense.

It does, but I'm just trying to get a measure for what the user
expectation/experience is going to be for those that are going to use this
interface. (Which, I suspect, is what Daryn's questions are about as well).
'ls' is a UNIXy thing, which why I asked specifically about cygwin and SUA. If
Windows users are expecting different output, it may be worthwhile to implement
a dir subcommand.

In other words, we should implement 'expected behavior' not necessarily what is
convenient if there is a collision. (But convenience can always be provided via
an option...) So if cygwin/sua show with spaces by default, that's what we
should do. If they provide an option that puts separators in place, that's
what we should. Consistency is key for (inter)operability.

Support spaces in user names and group names in results returned via winutils
-

Key: HADOOP-8456
URL: https://issues.apache.org/jira/browse/HADOOP-8456
Project: Hadoop Common
Issue Type: Bug
Components: native
Affects Versions: 1-win
Reporter: Chuan Liu
Assignee: Ivan Mitic
Priority: Minor
Attachments: HADOOP-8456.branch-1-win.spaces.patch

When parsing results returned by ‘ls’, we made implicit assumption that user
and group names cannot contain spaces. On Linux, spaces are not allowed in
user names and group names. This is not the case for Windows. We need to find
a way to fix the problem for Windows.

[jira] [Created] (HADOOP-8992) Enhance unit-test coverage of class HarFileSystem

Ivan A. Veselovsky created HADOOP-8992:
--

 Summary: Enhance unit-test coverage of class HarFileSystem
 Key: HADOOP-8992
 URL: https://issues.apache.org/jira/browse/HADOOP-8992
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Assignee: Ivan A. Veselovsky
Priority: Minor


New unit test TestHarFileSystem2 provided in order to enhance coverage of class 
HarFileSystem.
Also some unused methods deleted from class HarFileSystem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8992) Enhance unit-test coverage of class HarFileSystem


 [ 
https://issues.apache.org/jira/browse/HADOOP-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan A. Veselovsky updated HADOOP-8992:
---

Attachment: HADOOP-8992-branch-2.patch
HADOOP-8992-branch-0.23.patch

-branch-2 patch is also suitable for 'trunk'.

 Enhance unit-test coverage of class HarFileSystem
 -

 Key: HADOOP-8992
 URL: https://issues.apache.org/jira/browse/HADOOP-8992
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Assignee: Ivan A. Veselovsky
Priority: Minor
 Attachments: HADOOP-8992-branch-0.23.patch, HADOOP-8992-branch-2.patch


 New unit test TestHarFileSystem2 provided in order to enhance coverage of 
 class HarFileSystem.
 Also some unused methods deleted from class HarFileSystem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8992) Enhance unit-test coverage of class HarFileSystem


 [ 
https://issues.apache.org/jira/browse/HADOOP-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan A. Veselovsky updated HADOOP-8992:
---

Status: Patch Available  (was: Open)

 Enhance unit-test coverage of class HarFileSystem
 -

 Key: HADOOP-8992
 URL: https://issues.apache.org/jira/browse/HADOOP-8992
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Assignee: Ivan A. Veselovsky
Priority: Minor
 Attachments: HADOOP-8992-branch-0.23.patch, HADOOP-8992-branch-2.patch


 New unit test TestHarFileSystem2 provided in order to enhance coverage of 
 class HarFileSystem.
 Also some unused methods deleted from class HarFileSystem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HADOOP-8993) Remove unused methods from FileUtil class

Ivan A. Veselovsky created HADOOP-8993:
--

 Summary: Remove unused methods from FileUtil class
 Key: HADOOP-8993
 URL: https://issues.apache.org/jira/browse/HADOOP-8993
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Priority: Minor


Some methods in class org.apache.hadoop.fs.FileUtil are used neither in project 
code nor in tests, that is, are a dead code. 
This lowers the overall coverage of that class.
The suggested patches remove the unused methods.

Note: one of #copy(5) method is unused in 0.23 branch, while is used in 
branch-2, so the patches for these branches are different.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8993) Remove unused methods from FileUtil class


 [ 
https://issues.apache.org/jira/browse/HADOOP-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan A. Veselovsky updated HADOOP-8993:
---

Assignee: Ivan A. Veselovsky
  Status: Patch Available  (was: Open)

 Remove unused methods from FileUtil class
 -

 Key: HADOOP-8993
 URL: https://issues.apache.org/jira/browse/HADOOP-8993
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Assignee: Ivan A. Veselovsky
Priority: Minor
 Attachments: HADOOP-8993-branch-0.23.patch, HADOOP-8993-branch-2.patch


 Some methods in class org.apache.hadoop.fs.FileUtil are used neither in 
 project code nor in tests, that is, are a dead code. 
 This lowers the overall coverage of that class.
 The suggested patches remove the unused methods.
 Note: one of #copy(5) method is unused in 0.23 branch, while is used in 
 branch-2, so the patches for these branches are different.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8993) Remove unused methods from FileUtil class


 [ 
https://issues.apache.org/jira/browse/HADOOP-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan A. Veselovsky updated HADOOP-8993:
---

Attachment: HADOOP-8993-branch-2.patch
HADOOP-8993-branch-0.23.patch

The patch -branch-2 is also suitable for 'trunk'.

 Remove unused methods from FileUtil class
 -

 Key: HADOOP-8993
 URL: https://issues.apache.org/jira/browse/HADOOP-8993
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Priority: Minor
 Attachments: HADOOP-8993-branch-0.23.patch, HADOOP-8993-branch-2.patch


 Some methods in class org.apache.hadoop.fs.FileUtil are used neither in 
 project code nor in tests, that is, are a dead code. 
 This lowers the overall coverage of that class.
 The suggested patches remove the unused methods.
 Note: one of #copy(5) method is unused in 0.23 branch, while is used in 
 branch-2, so the patches for these branches are different.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8986) Server$Call object is never released after it is sent


 [ 
https://issues.apache.org/jira/browse/HADOOP-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated HADOOP-8986:


Attachment: HADOOP-8986.txt

There are no tests for this patch.  I have tested it manually.  All of the old 
functionality should still work, it is just that more memory will be released 
to be collected when a call finishes.

 Server$Call object is never released after it is sent
 -

 Key: HADOOP-8986
 URL: https://issues.apache.org/jira/browse/HADOOP-8986
 Project: Hadoop Common
  Issue Type: Bug
  Components: ipc
Affects Versions: 2.0.2-alpha, 0.23.4
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Critical
 Attachments: HADOOP-8986.txt


 When an IPC response cannot be returned without blocking an Server$Call 
 object is attached to the SelectionKey of the write selector.  However the 
 call object is never removed from the SlectionKey. So for a connection that 
 rarely has large responses but is long lived there is a lot of data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8986) Server$Call object is never released after it is sent


 [ 
https://issues.apache.org/jira/browse/HADOOP-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Joseph Evans updated HADOOP-8986:


Status: Patch Available  (was: Open)

 Server$Call object is never released after it is sent
 -

 Key: HADOOP-8986
 URL: https://issues.apache.org/jira/browse/HADOOP-8986
 Project: Hadoop Common
  Issue Type: Bug
  Components: ipc
Affects Versions: 0.23.4, 2.0.2-alpha
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Critical
 Attachments: HADOOP-8986.txt


 When an IPC response cannot be returned without blocking an Server$Call 
 object is attached to the SelectionKey of the write selector.  However the 
 call object is never removed from the SlectionKey. So for a connection that 
 rarely has large responses but is long lived there is a lot of data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8993) Remove unused methods from FileUtil class


[ 
https://issues.apache.org/jira/browse/HADOOP-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486260#comment-13486260
 ] 

Hadoop QA commented on HADOOP-8993:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12551223/HADOOP-8993-branch-2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1683//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1683//console

This message is automatically generated.

 Remove unused methods from FileUtil class
 -

 Key: HADOOP-8993
 URL: https://issues.apache.org/jira/browse/HADOOP-8993
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Assignee: Ivan A. Veselovsky
Priority: Minor
 Attachments: HADOOP-8993-branch-0.23.patch, HADOOP-8993-branch-2.patch


 Some methods in class org.apache.hadoop.fs.FileUtil are used neither in 
 project code nor in tests, that is, are a dead code. 
 This lowers the overall coverage of that class.
 The suggested patches remove the unused methods.
 Note: one of #copy(5) method is unused in 0.23 branch, while is used in 
 branch-2, so the patches for these branches are different.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8992) Enhance unit-test coverage of class HarFileSystem


[ 
https://issues.apache.org/jira/browse/HADOOP-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486261#comment-13486261
 ] 

Hadoop QA commented on HADOOP-8992:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12551220/HADOOP-8992-branch-2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1684//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1684//console

This message is automatically generated.

 Enhance unit-test coverage of class HarFileSystem
 -

 Key: HADOOP-8992
 URL: https://issues.apache.org/jira/browse/HADOOP-8992
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Assignee: Ivan A. Veselovsky
Priority: Minor
 Attachments: HADOOP-8992-branch-0.23.patch, HADOOP-8992-branch-2.patch


 New unit test TestHarFileSystem2 provided in order to enhance coverage of 
 class HarFileSystem.
 Also some unused methods deleted from class HarFileSystem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8986) Server$Call object is never released after it is sent


[ 
https://issues.apache.org/jira/browse/HADOOP-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486273#comment-13486273
 ] 

Hadoop QA commented on HADOOP-8986:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12551227/HADOOP-8986.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1685//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1685//console

This message is automatically generated.

 Server$Call object is never released after it is sent
 -

 Key: HADOOP-8986
 URL: https://issues.apache.org/jira/browse/HADOOP-8986
 Project: Hadoop Common
  Issue Type: Bug
  Components: ipc
Affects Versions: 2.0.2-alpha, 0.23.4
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Critical
 Attachments: HADOOP-8986.txt


 When an IPC response cannot be returned without blocking an Server$Call 
 object is attached to the SelectionKey of the write selector.  However the 
 call object is never removed from the SlectionKey. So for a connection that 
 rarely has large responses but is long lived there is a lot of data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8986) Server$Call object is never released after it is sent


[ 
https://issues.apache.org/jira/browse/HADOOP-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486296#comment-13486296
 ] 

Daryn Sharp commented on HADOOP-8986:
-

Looks good.  Did you investigate whether a test can be added to 
{{TestIPCServerResponder}}?  It causes partial writes which may allow you to 
check if the response is null out after the call finally completes.

 Server$Call object is never released after it is sent
 -

 Key: HADOOP-8986
 URL: https://issues.apache.org/jira/browse/HADOOP-8986
 Project: Hadoop Common
  Issue Type: Bug
  Components: ipc
Affects Versions: 2.0.2-alpha, 0.23.4
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Critical
 Attachments: HADOOP-8986.txt


 When an IPC response cannot be returned without blocking an Server$Call 
 object is attached to the SelectionKey of the write selector.  However the 
 call object is never removed from the SlectionKey. So for a connection that 
 rarely has large responses but is long lived there is a lot of data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HADOOP-8994) TestDFSShell creates file named noFileHere, making further tests hard to understand

Andy Isaacson created HADOOP-8994:
-

 Summary: TestDFSShell creates file named noFileHere, making 
further tests hard to understand
 Key: HADOOP-8994
 URL: https://issues.apache.org/jira/browse/HADOOP-8994
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Andy Isaacson


While working on HDFS-1331 I added a test to {{TestDFSShell}} which used 
{{noFileHere}} in the negative case.  This failed mysteriously because the 
earlier tests run {{-touchz noFileHere}} for no good reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8994) TestDFSShell creates file named noFileHere, making further tests hard to understand


 [ 
https://issues.apache.org/jira/browse/HADOOP-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Isaacson updated HADOOP-8994:
--

Attachment: hadoop8994.txt

Change name of the file that is created to {{isFileHere}}.

 TestDFSShell creates file named noFileHere, making further tests hard to 
 understand
 -

 Key: HADOOP-8994
 URL: https://issues.apache.org/jira/browse/HADOOP-8994
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Andy Isaacson
Assignee: Andy Isaacson
 Attachments: hadoop8994.txt


 While working on HDFS-1331 I added a test to {{TestDFSShell}} which used 
 {{noFileHere}} in the negative case.  This failed mysteriously because the 
 earlier tests run {{-touchz noFileHere}} for no good reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HADOOP-8994) TestDFSShell creates file named noFileHere, making further tests hard to understand


 [ 
https://issues.apache.org/jira/browse/HADOOP-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Isaacson reassigned HADOOP-8994:
-

Assignee: Andy Isaacson

 TestDFSShell creates file named noFileHere, making further tests hard to 
 understand
 -

 Key: HADOOP-8994
 URL: https://issues.apache.org/jira/browse/HADOOP-8994
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Andy Isaacson
Assignee: Andy Isaacson
 Attachments: hadoop8994.txt


 While working on HDFS-1331 I added a test to {{TestDFSShell}} which used 
 {{noFileHere}} in the negative case.  This failed mysteriously because the 
 earlier tests run {{-touchz noFileHere}} for no good reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8994) TestDFSShell creates file named noFileHere, making further tests hard to understand


 [ 
https://issues.apache.org/jira/browse/HADOOP-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Isaacson updated HADOOP-8994:
--

Status: Patch Available  (was: Open)

 TestDFSShell creates file named noFileHere, making further tests hard to 
 understand
 -

 Key: HADOOP-8994
 URL: https://issues.apache.org/jira/browse/HADOOP-8994
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Reporter: Andy Isaacson
Assignee: Andy Isaacson
 Attachments: hadoop8994.txt


 While working on HDFS-1331 I added a test to {{TestDFSShell}} which used 
 {{noFileHere}} in the negative case.  This failed mysteriously because the 
 earlier tests run {{-touchz noFileHere}} for no good reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8994) TestDFSShell creates file named noFileHere, making further tests hard to understand


 [ 
https://issues.apache.org/jira/browse/HADOOP-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Isaacson updated HADOOP-8994:
--

Affects Version/s: 3.0.0
   2.0.2-alpha

 TestDFSShell creates file named noFileHere, making further tests hard to 
 understand
 -

 Key: HADOOP-8994
 URL: https://issues.apache.org/jira/browse/HADOOP-8994
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0, 2.0.2-alpha
Reporter: Andy Isaacson
Assignee: Andy Isaacson
 Attachments: hadoop8994.txt


 While working on HDFS-1331 I added a test to {{TestDFSShell}} which used 
 {{noFileHere}} in the negative case.  This failed mysteriously because the 
 earlier tests run {{-touchz noFileHere}} for no good reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8994) TestDFSShell creates file named noFileHere, making further tests hard to understand


 [ 
https://issues.apache.org/jira/browse/HADOOP-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Isaacson updated HADOOP-8994:
--

Component/s: test

 TestDFSShell creates file named noFileHere, making further tests hard to 
 understand
 -

 Key: HADOOP-8994
 URL: https://issues.apache.org/jira/browse/HADOOP-8994
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0, 2.0.2-alpha
Reporter: Andy Isaacson
Assignee: Andy Isaacson
Priority: Minor
 Attachments: hadoop8994.txt


 While working on HDFS-1331 I added a test to {{TestDFSShell}} which used 
 {{noFileHere}} in the negative case.  This failed mysteriously because the 
 earlier tests run {{-touchz noFileHere}} for no good reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8994) TestDFSShell creates file named noFileHere, making further tests hard to understand


 [ 
https://issues.apache.org/jira/browse/HADOOP-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Isaacson updated HADOOP-8994:
--

Priority: Minor  (was: Major)

 TestDFSShell creates file named noFileHere, making further tests hard to 
 understand
 -

 Key: HADOOP-8994
 URL: https://issues.apache.org/jira/browse/HADOOP-8994
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0, 2.0.2-alpha
Reporter: Andy Isaacson
Assignee: Andy Isaacson
Priority: Minor
 Attachments: hadoop8994.txt


 While working on HDFS-1331 I added a test to {{TestDFSShell}} which used 
 {{noFileHere}} in the negative case.  This failed mysteriously because the 
 earlier tests run {{-touchz noFileHere}} for no good reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8953) Shell PathData parsing failures on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-8953:
--

Release Note: Support Windows paths with drive specifiers. This is 
currently broken on branch-trunk-win. 
  Status: Patch Available  (was: Open)

Resolves TestPathData failures. The patch may need to be updated as we resolve 
more path-related issues on Windows.

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth

 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8986) Server$Call object is never released after it is sent


[ 
https://issues.apache.org/jira/browse/HADOOP-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486335#comment-13486335
 ] 

Robert Joseph Evans commented on HADOOP-8986:
-

I didn't look that closely at adding in a test because I was mostly concerned 
that it did not break any existing functionality.  I will look at 
TestIPCResponder to see if I can add something in there.

 Server$Call object is never released after it is sent
 -

 Key: HADOOP-8986
 URL: https://issues.apache.org/jira/browse/HADOOP-8986
 Project: Hadoop Common
  Issue Type: Bug
  Components: ipc
Affects Versions: 2.0.2-alpha, 0.23.4
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Critical
 Attachments: HADOOP-8986.txt


 When an IPC response cannot be returned without blocking an Server$Call 
 object is attached to the SelectionKey of the write selector.  However the 
 call object is never removed from the SlectionKey. So for a connection that 
 rarely has large responses but is long lived there is a lot of data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8953) Shell PathData parsing failures on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-8953:
--

Attachment: HADOOP-8953-branch-trunk-win.patch

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8978) TestTrash fails on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8978:
--

Attachment: HADOOP-8978.patch

The attached patch ports the relevant code from branch-1-win onto 
branch-trunk-win.  I also added JavaDocs and tests.  With this patch in place, 
the tests pass.

Note that this patch is dependent on the HADOOP-8956 patch getting committed to 
branch-trunk-win first.  Otherwise, this patch file won't apply cleanly.

 TestTrash fails on Windows
 --

 Key: HADOOP-8978
 URL: https://issues.apache.org/jira/browse/HADOOP-8978
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8978.patch


 The tests assert that a file is found in trash after deleting, but it's not 
 found when run on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8978) TestTrash fails on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8978:
--

Attachment: (was: HADOOP-8978.patch)

 TestTrash fails on Windows
 --

 Key: HADOOP-8978
 URL: https://issues.apache.org/jira/browse/HADOOP-8978
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8978-branch-trunk-win.patch


 The tests assert that a file is found in trash after deleting, but it's not 
 found when run on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8978) TestTrash fails on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8978:
--

Attachment: HADOOP-8978-branch-trunk-win.patch

 TestTrash fails on Windows
 --

 Key: HADOOP-8978
 URL: https://issues.apache.org/jira/browse/HADOOP-8978
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8978-branch-trunk-win.patch


 The tests assert that a file is found in trash after deleting, but it's not 
 found when run on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8953) Shell PathData parsing failures on Windows


[ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486362#comment-13486362
 ] 

Arpit Agarwal commented on HADOOP-8953:
---

Hi Daryn, would you have a link to the jira handy? File URIs formatted as 
described in that MSDN article should work already.

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8976) TestFSMainOperationsLocalFileSystem fails on Windows


[ 
https://issues.apache.org/jira/browse/HADOOP-8976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486386#comment-13486386
 ] 

Chris Nauroth commented on HADOOP-8976:
---

This test failure is fixed with a combination of patches I've submitted on 
other issues: HADOOP-8956, HADOOP-8957, and HADOOP-8958.

 TestFSMainOperationsLocalFileSystem fails on Windows
 

 Key: HADOOP-8976
 URL: https://issues.apache.org/jira/browse/HADOOP-8976
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth

 There are multiple failures in this test suite, and there appear to be many 
 different reasons.  This needs further investigation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8993) Remove unused methods from FileUtil class


[ 
https://issues.apache.org/jira/browse/HADOOP-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486389#comment-13486389
 ] 

Suresh Srinivas commented on HADOOP-8993:
-

FileUtil is tagged as InterfaceAudience.Public. That means other hadoop 
projects or applications could be using them.

 Remove unused methods from FileUtil class
 -

 Key: HADOOP-8993
 URL: https://issues.apache.org/jira/browse/HADOOP-8993
 Project: Hadoop Common
  Issue Type: Improvement
Reporter: Ivan A. Veselovsky
Assignee: Ivan A. Veselovsky
Priority: Minor
 Attachments: HADOOP-8993-branch-0.23.patch, HADOOP-8993-branch-2.patch


 Some methods in class org.apache.hadoop.fs.FileUtil are used neither in 
 project code nor in tests, that is, are a dead code. 
 This lowers the overall coverage of that class.
 The suggested patches remove the unused methods.
 Note: one of #copy(5) method is unused in 0.23 branch, while is used in 
 branch-2, so the patches for these branches are different.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8986) Server$Call object is never released after it is sent


[ 
https://issues.apache.org/jira/browse/HADOOP-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486402#comment-13486402
 ] 

Suresh Srinivas commented on HADOOP-8986:
-

+1 for the patch. I feel it is unnecessary to add test for this.

 Server$Call object is never released after it is sent
 -

 Key: HADOOP-8986
 URL: https://issues.apache.org/jira/browse/HADOOP-8986
 Project: Hadoop Common
  Issue Type: Bug
  Components: ipc
Affects Versions: 2.0.2-alpha, 0.23.4
Reporter: Robert Joseph Evans
Assignee: Robert Joseph Evans
Priority: Critical
 Attachments: HADOOP-8986.txt


 When an IPC response cannot be returned without blocking an Server$Call 
 object is attached to the SelectionKey of the write selector.  However the 
 call object is never removed from the SlectionKey. So for a connection that 
 rarely has large responses but is long lived there is a lot of data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8994) TestDFSShell creates file named noFileHere, making further tests hard to understand


[ 
https://issues.apache.org/jira/browse/HADOOP-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486405#comment-13486405
 ] 

Hadoop QA commented on HADOOP-8994:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12551231/hadoop8994.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1686//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1686//console

This message is automatically generated.

 TestDFSShell creates file named noFileHere, making further tests hard to 
 understand
 -

 Key: HADOOP-8994
 URL: https://issues.apache.org/jira/browse/HADOOP-8994
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0, 2.0.2-alpha
Reporter: Andy Isaacson
Assignee: Andy Isaacson
Priority: Minor
 Attachments: hadoop8994.txt


 While working on HDFS-1331 I added a test to {{TestDFSShell}} which used 
 {{noFileHere}} in the negative case.  This failed mysteriously because the 
 earlier tests run {{-touchz noFileHere}} for no good reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8953) Shell PathData parsing failures on Windows


[ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486407#comment-13486407
 ] 

Hadoop QA commented on HADOOP-8953:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12551240/HADOOP-8953-branch-trunk-win.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1687//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1687//console

This message is automatically generated.

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8953) Shell PathData parsing failures on Windows

2012-10-29 Thread Ivan Mitic (JIRA)


[ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486411#comment-13486411
 ] 

Ivan Mitic commented on HADOOP-8953:


Thanks Arpit for the patch.

bq. In one of the original windows jiras it was agreed that going forward only 
standard uris will be supported by hadoop.
Right, we agreed on only supporting valid URIs in HADOOP-8409 for hadoop 
generic options. The same should hold on trunk.

Arpit, please wait for me to review and test the patch. The goal of the patch 
is to fix the above two unittests, right? Two early comments
 - I don't think we want to have Windows specific code in FileSystem.java
 - PathData seems to replicate a lot of the logic from Path, can we avoid this?

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8995) Remove unnecessary bogus exception string from Configuration

2012-10-29 Thread Jing Zhao (JIRA)


 [ 
https://issues.apache.org/jira/browse/HADOOP-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HADOOP-8995:
--

Attachment: Hadoop.8995.b1.001.patch

Patch uploaded.

 Remove unnecessary bogus exception string from Configuration
 

 Key: HADOOP-8995
 URL: https://issues.apache.org/jira/browse/HADOOP-8995
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Jing Zhao
Assignee: Jing Zhao
Priority: Minor
 Attachments: Hadoop.8995.b1.001.patch


 In Configuration#Configuration(boolean) and 
 Configuration#Configuration(Configuration), bogus exceptions are thrown when 
 Log level is DEBUG.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HADOOP-8995) Remove unnecessary bogus exception string from Configuration

2012-10-29 Thread Jing Zhao (JIRA)

Jing Zhao created HADOOP-8995:
-

 Summary: Remove unnecessary bogus exception string from 
Configuration
 Key: HADOOP-8995
 URL: https://issues.apache.org/jira/browse/HADOOP-8995
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Jing Zhao
Assignee: Jing Zhao
Priority: Minor


In Configuration#Configuration(boolean) and 
Configuration#Configuration(Configuration), bogus exceptions are thrown when 
Log level is DEBUG.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8995) Remove unnecessary bogus exception string from Configuration


[ 
https://issues.apache.org/jira/browse/HADOOP-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486433#comment-13486433
 ] 

Suresh Srinivas commented on HADOOP-8995:
-

+1 for the change.

 Remove unnecessary bogus exception string from Configuration
 

 Key: HADOOP-8995
 URL: https://issues.apache.org/jira/browse/HADOOP-8995
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Jing Zhao
Assignee: Jing Zhao
Priority: Minor
 Attachments: Hadoop.8995.b1.001.patch


 In Configuration#Configuration(boolean) and 
 Configuration#Configuration(Configuration), bogus exceptions are thrown when 
 Log level is DEBUG.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8953) Shell PathData parsing failures on Windows


[ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486436#comment-13486436
 ] 

Daryn Sharp commented on HADOOP-8953:
-

bq. PathData seems to replicate a lot of the logic from Path, can we avoid this?
Sadly, no.  The {{Path}} object will munge the path in various ways such that 
you can't get the string back used to create the {{Path}} object.  This 
requires {{PathData}} to maintain its own copy of the path string so the output 
to the user matches exactly what they provided to the command.  {{Path}} also 
strips trailing slashes which breaks the shell's ability to disambiguate if the 
path is to be treated as a directory.

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8995) Remove unnecessary bogus exception log from Configuration


 [ 
https://issues.apache.org/jira/browse/HADOOP-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HADOOP-8995:


Summary: Remove unnecessary bogus exception log from Configuration  (was: 
Remove unnecessary bogus exception string from Configuration)

 Remove unnecessary bogus exception log from Configuration
 -

 Key: HADOOP-8995
 URL: https://issues.apache.org/jira/browse/HADOOP-8995
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Jing Zhao
Assignee: Jing Zhao
Priority: Minor
 Attachments: Hadoop.8995.b1.001.patch


 In Configuration#Configuration(boolean) and 
 Configuration#Configuration(Configuration), bogus exceptions are thrown when 
 Log level is DEBUG.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HADOOP-8995) Remove unnecessary bogus exception log from Configuration


 [ 
https://issues.apache.org/jira/browse/HADOOP-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas resolved HADOOP-8995.
-

   Resolution: Fixed
Fix Version/s: 1.2.0
 Hadoop Flags: Reviewed

I committed the patch to branch-1. Thank you Jing.

 Remove unnecessary bogus exception log from Configuration
 -

 Key: HADOOP-8995
 URL: https://issues.apache.org/jira/browse/HADOOP-8995
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Jing Zhao
Assignee: Jing Zhao
Priority: Minor
 Fix For: 1.2.0

 Attachments: Hadoop.8995.b1.001.patch


 In Configuration#Configuration(boolean) and 
 Configuration#Configuration(Configuration), bogus exceptions are thrown when 
 Log level is DEBUG.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8953) Shell PathData parsing failures on Windows


[ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486442#comment-13486442
 ] 

Daryn Sharp commented on HADOOP-8953:
-

What we really should be doing is removing the drive letter support from 
{{Path}}.  Uris formatted according to the MSDN article shouldn't require the 
special handling.

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8953) Shell PathData parsing failures on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-8953:
--

Attachment: (was: HADOOP-8953-branch-trunk-win.patch)

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8953) Shell PathData parsing failures on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-8953:
--

Attachment: HADOOP-8953-branch-trunk-win.patch

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8953) Shell PathData parsing failures on Windows


[ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486470#comment-13486470
 ] 

Hadoop QA commented on HADOOP-8953:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12551261/HADOOP-8953-branch-trunk-win.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:red}-1 javac{color:red}.  The patch appears to cause the build to 
fail.

Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1688//console

This message is automatically generated.

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8953) Shell PathData parsing failures on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-8953:
--

Release Note:   (was: Support Windows paths with drive specifiers. This is 
currently broken on branch-trunk-win. )

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8953) Shell PathData parsing failures on Windows


 [ 
https://issues.apache.org/jira/browse/HADOOP-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HADOOP-8953:
--

Assignee: Arpit Agarwal  (was: Chris Nauroth)
  Status: Open  (was: Patch Available)

 Shell PathData parsing failures on Windows
 --

 Key: HADOOP-8953
 URL: https://issues.apache.org/jira/browse/HADOOP-8953
 Project: Hadoop Common
  Issue Type: Bug
  Components: fs
Affects Versions: trunk-win
Reporter: Chris Nauroth
Assignee: Arpit Agarwal
 Attachments: HADOOP-8953-branch-trunk-win.patch


 Several test suites fail on Windows, apparently due to Windows-specific path 
 parsing bugs in PathData.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-23) single node cluster gets one reducer

2012-10-29 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HADOOP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486622#comment-13486622
 ] 

Hudson commented on HADOOP-23:
--

Integrated in flume-trunk #320 (See 
[https://builds.apache.org/job/flume-trunk/320/])
FLUME-1653: Update Hadoop-23 profile to point to hadoop-2 alpha artifacts 
(Revision 831a86fc5501a8624b184ea65e53749df31692b8)

 Result = SUCCESS

 single node cluster gets one reducer
 

 Key: HADOOP-23
 URL: https://issues.apache.org/jira/browse/HADOOP-23
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Priority: Minor

 Running on a single node cluster (it runs a job tracker and a single task 
 tracker), even though my application asks for 7 reduces, it only gets one. I 
 haven't tracked down what is happening yet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-2) Reused Keys and Values fail with a Combiner

2012-10-29 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HADOOP-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486624#comment-13486624
 ] 

Hudson commented on HADOOP-2:
-

Integrated in flume-trunk #320 (See 
[https://builds.apache.org/job/flume-trunk/320/])
FLUME-1653: Update Hadoop-23 profile to point to hadoop-2 alpha artifacts 
(Revision 831a86fc5501a8624b184ea65e53749df31692b8)

 Result = SUCCESS

 Reused Keys and Values fail with a Combiner
 ---

 Key: HADOOP-2
 URL: https://issues.apache.org/jira/browse/HADOOP-2
 Project: Hadoop Common
  Issue Type: Bug
Reporter: Owen O'Malley
Assignee: Owen O'Malley
 Fix For: 0.1.0

 Attachments: clone-map-output.patch


 If the map function reuses the key or value by destructively modifying it 
 after the output.collect(key,value) call and your application uses a 
 combiner, the data is corrupted by having lots of instances with the last key 
 or value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8995) Remove unnecessary bogus exception log from Configuration

2012-10-29 Thread Harsh J (JIRA)


[ 
https://issues.apache.org/jira/browse/HADOOP-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486642#comment-13486642
 ] 

Harsh J commented on HADOOP-8995:
-

Just to clarify, these were not _bogus_ but helpers in identifying what classes 
instantiated the Configuration object (prints a trace).

Has not come helpful to me personally, but was a good thing to have (just in 
case). Perhaps we could have just lowered its level below DEBUG, such as TRACE.

 Remove unnecessary bogus exception log from Configuration
 -

 Key: HADOOP-8995
 URL: https://issues.apache.org/jira/browse/HADOOP-8995
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Jing Zhao
Assignee: Jing Zhao
Priority: Minor
 Fix For: 1.2.0

 Attachments: Hadoop.8995.b1.001.patch


 In Configuration#Configuration(boolean) and 
 Configuration#Configuration(Configuration), bogus exceptions are thrown when 
 Log level is DEBUG.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8995) Remove unnecessary bogus exception log from Configuration


[ 
https://issues.apache.org/jira/browse/HADOOP-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486647#comment-13486647
 ] 

Suresh Srinivas commented on HADOOP-8995:
-

Harsh, this was introduced many many years ago. Of all these years I have 
worked on Hadoop I do not remember using this. That is why this has been 
removed on trunk.


 Remove unnecessary bogus exception log from Configuration
 -

 Key: HADOOP-8995
 URL: https://issues.apache.org/jira/browse/HADOOP-8995
 Project: Hadoop Common
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Jing Zhao
Assignee: Jing Zhao
Priority: Minor
 Fix For: 1.2.0

 Attachments: Hadoop.8995.b1.001.patch


 In Configuration#Configuration(boolean) and 
 Configuration#Configuration(Configuration), bogus exceptions are thrown when 
 Log level is DEBUG.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (HADOOP-8995) Remove unnecessary bogus exception log from Configuration