[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800081 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800145 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800116 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800112 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800095 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800088 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800092 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800079 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800081 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800076 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800073 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800084 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341800029 ## File path:

[GitHub] [hadoop] virajjasani commented on issue #1681: HADOOP-16672 : adding null check for ticket.doAs() while setting up I…

2019-11-01 Thread GitBox
virajjasani commented on issue #1681: HADOOP-16672 : adding null check for ticket.doAs() while setting up I… URL: https://github.com/apache/hadoop/pull/1681#issuecomment-549006949 @jojochuang we seem to have null check for ticket everywhere but here for this method hence I thought of

[GitHub] [hadoop] hadoop-yetus commented on issue #1689: HADOOP-16679. Switch to okhttp3

2019-11-01 Thread GitBox
hadoop-yetus commented on issue #1689: HADOOP-16679. Switch to okhttp3 URL: https://github.com/apache/hadoop/pull/1689#issuecomment-548997506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341793670 ## File path:

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341793602 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1690: HADOOP-16680. Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider

2019-11-01 Thread GitBox
hadoop-yetus commented on issue #1690: HADOOP-16680. Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider URL: https://github.com/apache/hadoop/pull/1690#issuecomment-548993831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] jojochuang merged pull request #1670: HDFS-14925. Rename operation should check nest snapshot

2019-11-01 Thread GitBox
jojochuang merged pull request #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] jojochuang commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot

2019-11-01 Thread GitBox
jojochuang commented on issue #1670: HDFS-14925. Rename operation should check nest snapshot URL: https://github.com/apache/hadoop/pull/1670#issuecomment-548984506 Thanks @bshashikant for review and @zhjwpku for the patch!

[GitHub] [hadoop] hadoop-yetus commented on issue #1689: HADOOP-16679. Switch to okhttp3

2019-11-01 Thread GitBox
hadoop-yetus commented on issue #1689: HADOOP-16679. Switch to okhttp3 URL: https://github.com/apache/hadoop/pull/1689#issuecomment-548983724 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0

[GitHub] [hadoop] jojochuang commented on a change in pull request #1669: HDFS-14802. The feature of protect directories should be used in RenameOp

2019-11-01 Thread GitBox
jojochuang commented on a change in pull request #1669: HDFS-14802. The feature of protect directories should be used in RenameOp URL: https://github.com/apache/hadoop/pull/1669#discussion_r341783012 ## File path:

[jira] [Commented] (HADOOP-16680) Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider

2019-11-01 Thread Lukas Majercak (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965135#comment-16965135 ] Lukas Majercak commented on HADOOP-16680: - Linked the PR, it will probably fail because of the

[jira] [Commented] (HADOOP-16678) Review of ArrayWritable

2019-11-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965136#comment-16965136 ] Hadoop QA commented on HADOOP-16678: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] lukmajercak opened a new pull request #1690: HADOOP-16680. Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider

2019-11-01 Thread GitBox
lukmajercak opened a new pull request #1690: HADOOP-16680. Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider URL: https://github.com/apache/hadoop/pull/1690 This is an automated message from the Apache Git

[GitHub] [hadoop] jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency

2019-11-01 Thread GitBox
jeeteshm commented on a change in pull request #1611: HADOOP-16612 Track Azure Blob File System client-perceived latency URL: https://github.com/apache/hadoop/pull/1611#discussion_r341773035 ## File path:

[jira] [Commented] (HADOOP-16679) Switch to okhttp3

2019-11-01 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965114#comment-16965114 ] Íñigo Goiri commented on HADOOP-16679: -- [~zhangduo], [~ste...@apache.org], do you mind taking a

[jira] [Commented] (HADOOP-16680) Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider

2019-11-01 Thread Lukas Majercak (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965109#comment-16965109 ] Lukas Majercak commented on HADOOP-16680: - Will add a PR momentarily. > Add

[jira] [Commented] (HADOOP-16679) Switch to okhttp3

2019-11-01 Thread Lukas Majercak (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965108#comment-16965108 ] Lukas Majercak commented on HADOOP-16679: - [~elgoiri] I'm trying to add

[jira] [Created] (HADOOP-16680) Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider

2019-11-01 Thread Lukas Majercak (Jira)
Lukas Majercak created HADOOP-16680: --- Summary: Add MicrosoftGraphGroupsMapping GroupMappingServiceProvider Key: HADOOP-16680 URL: https://issues.apache.org/jira/browse/HADOOP-16680 Project: Hadoop

[jira] [Commented] (HADOOP-16679) Switch to okhttp3

2019-11-01 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965104#comment-16965104 ] Íñigo Goiri commented on HADOOP-16679: -- [~lukmajercak], what's the reason to upgrade? > Switch to

[GitHub] [hadoop] lukmajercak opened a new pull request #1689: HADOOP-16679

2019-11-01 Thread GitBox
lukmajercak opened a new pull request #1689: HADOOP-16679 URL: https://github.com/apache/hadoop/pull/1689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Created] (HADOOP-16679) Switch to okhttp3

2019-11-01 Thread Lukas Majercak (Jira)
Lukas Majercak created HADOOP-16679: --- Summary: Switch to okhttp3 Key: HADOOP-16679 URL: https://issues.apache.org/jira/browse/HADOOP-16679 Project: Hadoop Common Issue Type: Improvement

[jira] [Updated] (HADOOP-16678) Review of ArrayWritable

2019-11-01 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HADOOP-16678: Status: Patch Available (was: Open) > Review of ArrayWritable > ---

[jira] [Updated] (HADOOP-16678) Review of ArrayWritable

2019-11-01 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HADOOP-16678: Attachment: HADOOP-16678.1.patch > Review of ArrayWritable > --- > >

[jira] [Created] (HADOOP-16678) Review of ArrayWritable

2019-11-01 Thread David Mollitor (Jira)
David Mollitor created HADOOP-16678: --- Summary: Review of ArrayWritable Key: HADOOP-16678 URL: https://issues.apache.org/jira/browse/HADOOP-16678 Project: Hadoop Common Issue Type:

[GitHub] [hadoop] jojochuang commented on issue #1681: HADOOP-16672 : adding null check for ticket.doAs() while setting up I…

2019-11-01 Thread GitBox
jojochuang commented on issue #1681: HADOOP-16672 : adding null check for ticket.doAs() while setting up I… URL: https://github.com/apache/hadoop/pull/1681#issuecomment-548942409 Do you know when the ticket is null? Can you post a stack trace so that it's easier to tell why. Looking

[GitHub] [hadoop] hadoop-yetus commented on issue #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
hadoop-yetus commented on issue #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#issuecomment-548927380 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:|

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
hadoop-yetus commented on a change in pull request #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#discussion_r341726647 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/StreamStateModel.java

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
hadoop-yetus commented on a change in pull request #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#discussion_r341726640 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/StreamStateModel.java

[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
hadoop-yetus commented on a change in pull request #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#discussion_r341726657 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/StreamStateModel.java

[GitHub] [hadoop] xkrogen commented on issue #1685: HDFS-14824. [Dynamometer] Dynamometer in org.apache.hadoop.tools does not output the benchmark results.

2019-11-01 Thread GitBox
xkrogen commented on issue #1685: HDFS-14824. [Dynamometer] Dynamometer in org.apache.hadoop.tools does not output the benchmark results. URL: https://github.com/apache/hadoop/pull/1685#issuecomment-548855292 Thanks @tasanuma !

[GitHub] [hadoop] xkrogen merged pull request #1685: HDFS-14824. [Dynamometer] Dynamometer in org.apache.hadoop.tools does not output the benchmark results.

2019-11-01 Thread GitBox
xkrogen merged pull request #1685: HDFS-14824. [Dynamometer] Dynamometer in org.apache.hadoop.tools does not output the benchmark results. URL: https://github.com/apache/hadoop/pull/1685 This is an automated message from

[jira] [Resolved] (HADOOP-16598) Backport "HADOOP-16558 [COMMON+HDFS] use protobuf-maven-plugin to generate protobuf classes" to all active branches

2019-11-01 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HADOOP-16598. Resolution: Fixed Reclosing after fixing branch-2 and branch-2.9 commits (revert and

[jira] [Reopened] (HADOOP-16598) Backport "HADOOP-16558 [COMMON+HDFS] use protobuf-maven-plugin to generate protobuf classes" to all active branches

2019-11-01 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HADOOP-16598: Thanks for checking. Reopening while I fix. > Backport "HADOOP-16558 [COMMON+HDFS] use

[GitHub] [hadoop] steveloughran commented on issue #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
steveloughran commented on issue #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#issuecomment-548815620 Had some time to look at the comments here after too long break; more work is needed ## Output stream spec Needs more

[GitHub] [hadoop] steveloughran commented on a change in pull request #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
steveloughran commented on a change in pull request #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#discussion_r341593810 ## File path: hadoop-common-project/hadoop-common/src/site/markdown/filesystem/outputstream.md ## @@

[GitHub] [hadoop] steveloughran commented on a change in pull request #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
steveloughran commented on a change in pull request #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#discussion_r341592899 ## File path: hadoop-common-project/hadoop-common/src/site/markdown/filesystem/outputstream.md ## @@

[GitHub] [hadoop] steveloughran commented on a change in pull request #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
steveloughran commented on a change in pull request #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#discussion_r341589702 ## File path: hadoop-common-project/hadoop-common/src/site/markdown/filesystem/filesystem.md ## @@

[GitHub] [hadoop] steveloughran commented on a change in pull request #575: HADOOP-13327 Output Stream Specification

2019-11-01 Thread GitBox
steveloughran commented on a change in pull request #575: HADOOP-13327 Output Stream Specification URL: https://github.com/apache/hadoop/pull/575#discussion_r341589438 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/StreamStateModel.java

[GitHub] [hadoop] hadoop-yetus commented on issue #1688: S3a MultiObjectDeleteSupport prevent NullPointerException

2019-11-01 Thread GitBox
hadoop-yetus commented on issue #1688: S3a MultiObjectDeleteSupport prevent NullPointerException URL: https://github.com/apache/hadoop/pull/1688#issuecomment-548791470 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16674) TestDNS.testRDNS can fail with ServiceUnavailableException

2019-11-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964794#comment-16964794 ] Steve Loughran commented on HADOOP-16674: - interesting Q. skipped is probably the correct

[GitHub] [hadoop] torarvid opened a new pull request #1688: S3a MultiObjectDeleteSupport prevent NullPointerException

2019-11-01 Thread GitBox
torarvid opened a new pull request #1688: S3a MultiObjectDeleteSupport prevent NullPointerException URL: https://github.com/apache/hadoop/pull/1688 I've hit an issue where a DeleteObjects request using LocalStack causes a NullPointerException in the translateDeleteException function.

[jira] [Commented] (HADOOP-16663) Backport "HADOOP-16560 [YARN] use protobuf-maven-plugin to generate protobuf classes" to all active branches

2019-11-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964644#comment-16964644 ] Hadoop QA commented on HADOOP-16663: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16598) Backport "HADOOP-16558 [COMMON+HDFS] use protobuf-maven-plugin to generate protobuf classes" to all active branches

2019-11-01 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964636#comment-16964636 ] Duo Zhang commented on HADOOP-16598: [~stack] sir, seems you pushed wrong patch for branch-2 and