[GitHub] [hadoop] hadoop-yetus commented on pull request #2112: HDFS-15448.When starting a DataNode, call BlockPoolManager#startAll() twice.

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2112: URL: https://github.com/apache/hadoop/pull/2112#issuecomment-655301457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 19m

[jira] [Commented] (HADOOP-16862) [JDK11] Support JavaDoc

2020-07-07 Thread Ishani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153223#comment-17153223 ] Ishani commented on HADOOP-16862: - [https://github.com/apache/hadoop/pull/2125] > [JDK11] Support

[GitHub] [hadoop] ishaniahuja edited a comment on pull request #2125: HADOOP-16966. ABFS: change rest version to 2019-12-12

2020-07-07 Thread GitBox
ishaniahuja edited a comment on pull request #2125: URL: https://github.com/apache/hadoop/pull/2125#issuecomment-655274280 yetus has a -1 because of javadoc and test4tests(as no new tests were added or existing modified). I created 2 production accounts - namespace and non namespace for

[GitHub] [hadoop] ishaniahuja commented on pull request #2125: HADOOP-16966. ABFS: change rest version to 2019-12-12

2020-07-07 Thread GitBox
ishaniahuja commented on pull request #2125: URL: https://github.com/apache/hadoop/pull/2125#issuecomment-655274280 yetus has a -1 because of javadoc and test4tests(as no new tests were added or existing modified). I created 2 production accounts - namespace and non namespace for testing

[GitHub] [hadoop] bilaharith commented on pull request #2123: ABFS: Making AzureADAuthenticator.getToken() throw HttpException if a…

2020-07-07 Thread GitBox
bilaharith commented on pull request #2123: URL: https://github.com/apache/hadoop/pull/2123#issuecomment-655273139 Javadoc is failing in the trunk as well. Please find the JIRA [HADOOP-17085](https://issues.apache.org/jira/browse/HADOOP-17085) **Driver test results using accounts in

[jira] [Resolved] (HADOOP-15761) intermittent failure of TestAbfsClient.validateUserAgent

2020-07-07 Thread Bilahari T H (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilahari T H resolved HADOOP-15761. --- Resolution: Won't Fix Please see

[GitHub] [hadoop] hadoop-yetus commented on pull request #2126: YARN-10344. Sync netty versions in hadoop-yarn-csi.

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2126: URL: https://github.com/apache/hadoop/pull/2126#issuecomment-655265616 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 21m

[jira] [Commented] (HADOOP-16798) job commit failure in S3A MR magic committer test

2020-07-07 Thread Aaron Fabbri (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153199#comment-17153199 ] Aaron Fabbri commented on HADOOP-16798: --- I missed the party on this one, but just had a thought..

[GitHub] [hadoop] aajisaka opened a new pull request #2126: YARN-10344. Sync netty versions in hadoop-yarn-csi.

2020-07-07 Thread GitBox
aajisaka opened a new pull request #2126: URL: https://github.com/apache/hadoop/pull/2126 JIRA: https://issues.apache.org/jira/browse/YARN-10344 Before: ``` [INFO] --- maven-dependency-plugin:3.0.2:tree (default-cli) @ hadoop-yarn-csi --- [INFO]

[jira] [Updated] (HADOOP-17116) Skip Retry INFO logging on first failover from a proxy

2020-07-07 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanisha Koneru updated HADOOP-17116: Attachment: HADOOP-17116.001.patch > Skip Retry INFO logging on first failover from a

[GitHub] [hadoop] fengnanli commented on a change in pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
fengnanli commented on a change in pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#discussion_r451227559 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java

[GitHub] [hadoop] fengnanli commented on a change in pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
fengnanli commented on a change in pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#discussion_r451227291 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java

[GitHub] [hadoop] fengnanli commented on a change in pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
fengnanli commented on a change in pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#discussion_r451227069 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java

[GitHub] [hadoop] fengnanli commented on a change in pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
fengnanli commented on a change in pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#discussion_r451227025 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java

[GitHub] [hadoop] fengnanli commented on pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
fengnanli commented on pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#issuecomment-655221130 github screwed up a lot of my comments and I will reply again. This is an automated message from the Apache

[GitHub] [hadoop] fengnanli commented on a change in pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
fengnanli commented on a change in pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#discussion_r451226040 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java

[jira] [Created] (HADOOP-17116) Skip Retry INFO logging on first failover from a proxy

2020-07-07 Thread Hanisha Koneru (Jira)
Hanisha Koneru created HADOOP-17116: --- Summary: Skip Retry INFO logging on first failover from a proxy Key: HADOOP-17116 URL: https://issues.apache.org/jira/browse/HADOOP-17116 Project: Hadoop Common

[jira] [Commented] (HADOOP-17099) Replace Guava Predicate with Java8+ Predicate

2020-07-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153132#comment-17153132 ] Hadoop QA commented on HADOOP-17099: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] hadoop-yetus commented on pull request #2124: HADOOP-17101. replace Guava Function

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2124: URL: https://github.com/apache/hadoop/pull/2124#issuecomment-655145549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HADOOP-17101) Replace Guava Function with Java8+ Function

2020-07-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153093#comment-17153093 ] Hadoop QA commented on HADOOP-17101: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-16830) Add public IOStatistics API; S3A to support

2020-07-07 Thread Luca Canali (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153056#comment-17153056 ] Luca Canali commented on HADOOP-16830: -- Thanks, that looks quite useful and promising. I'll test

[GitHub] [hadoop] hadoop-yetus commented on pull request #2123: ABFS: Making AzureADAuthenticator.getToken() throw HttpException if a…

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2123: URL: https://github.com/apache/hadoop/pull/2123#issuecomment-655071803 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hadoop] hadoop-yetus commented on pull request #2125: HADOOP-16966. ABFS: change rest version to 2019-12-12

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2125: URL: https://github.com/apache/hadoop/pull/2125#issuecomment-655059920 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 30m

[jira] [Commented] (HADOOP-16492) Support HuaweiCloud Object Storage as a Hadoop Backend File System

2020-07-07 Thread Brahma Reddy Battula (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152970#comment-17152970 ] Brahma Reddy Battula commented on HADOOP-16492: --- [~zhongjun] thanks for uploading the

[GitHub] [hadoop] xiaoyuyao commented on pull request #2085: HADOOP-17079. Optimize UGI#getGroups by adding UGI#getGroupsSet.

2020-07-07 Thread GitBox
xiaoyuyao commented on pull request #2085: URL: https://github.com/apache/hadoop/pull/2085#issuecomment-655016953 @jojochuang can you help take a look at this change? Thanks This is an automated message from the Apache Git

[GitHub] [hadoop] ishaniahuja opened a new pull request #2125: HADOOP-16966. ABFS: change rest version to 2019-12-12

2020-07-07 Thread GitBox
ishaniahuja opened a new pull request #2125: URL: https://github.com/apache/hadoop/pull/2125 The PR changes the RestVersion to 2019-12-12 while sending requests from ABFS Driver. The change was tested with namespace and non namespace account in production. Whats missing? Documentation for

[jira] [Updated] (HADOOP-16966) ABFS: Enable new Rest Version and add documentation for appendblob

2020-07-07 Thread Ishani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishani updated HADOOP-16966: Description: When the new RestVersion(2019-12-12) is enabled in the backend, enable that in the driver

[jira] [Updated] (HADOOP-16966) ABFS: Enable new Rest Version and add documentation for appendblob

2020-07-07 Thread Ishani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishani updated HADOOP-16966: Summary: ABFS: Enable new Rest Version and add documentation for appendblob (was: ABFS: Enable new Rest

[jira] [Resolved] (HADOOP-17058) Support for Appendblob in abfs driver

2020-07-07 Thread Ishani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishani resolved HADOOP-17058. - Resolution: Fixed > Support for Appendblob in abfs driver > - > >

[GitHub] [hadoop] amahussein closed pull request #2124: HADOOP-17101. replace Guava Function

2020-07-07 Thread GitBox
amahussein closed pull request #2124: URL: https://github.com/apache/hadoop/pull/2124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HADOOP-17101) Replace Guava Function with Java8+ Function

2020-07-07 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated HADOOP-17101: --- Attachment: HADOOP-17101.003.patch > Replace Guava Function with Java8+ Function >

[jira] [Updated] (HADOOP-17099) Replace Guava Predicate with Java8+ Predicate

2020-07-07 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated HADOOP-17099: --- Attachment: HADOOP-17099.003.patch > Replace Guava Predicate with Java8+ Predicate >

[GitHub] [hadoop] hadoop-yetus commented on pull request #2123: ABFS: Making AzureADAuthenticator.getToken() throw HttpException if a…

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2123: URL: https://github.com/apache/hadoop/pull/2123#issuecomment-654957447 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HADOOP-17115) Replace Guava initialization of Sets.newHashSet

2020-07-07 Thread Ahmed Hussein (Jira)
Ahmed Hussein created HADOOP-17115: -- Summary: Replace Guava initialization of Sets.newHashSet Key: HADOOP-17115 URL: https://issues.apache.org/jira/browse/HADOOP-17115 Project: Hadoop Common

[jira] [Created] (HADOOP-17114) Replace Guava initialization of Lists.newArrayList

2020-07-07 Thread Ahmed Hussein (Jira)
Ahmed Hussein created HADOOP-17114: -- Summary: Replace Guava initialization of Lists.newArrayList Key: HADOOP-17114 URL: https://issues.apache.org/jira/browse/HADOOP-17114 Project: Hadoop Common

[GitHub] [hadoop] amahussein opened a new pull request #2124: HADOOP-17001. replace Guava Function

2020-07-07 Thread GitBox
amahussein opened a new pull request #2124: URL: https://github.com/apache/hadoop/pull/2124 - I have added a rule to prevent import of Guava `Function`, `Multimaps` and `ImmutableListMultimap` - I added a new package `org.apache.hadoop.util.noguava` that will be the place holder for

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2069: HADOOP-16830. IOStatistics API.

2020-07-07 Thread GitBox
mukund-thakur commented on a change in pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#discussion_r450905137 ## File path: hadoop-common-project/hadoop-common/src/site/markdown/filesystem/iostatistics.md ## @@ -0,0 +1,432 @@ + + +# Statistic collection

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2069: HADOOP-16830. IOStatistics API.

2020-07-07 Thread GitBox
mukund-thakur commented on a change in pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#discussion_r450904865 ## File path: hadoop-common-project/hadoop-common/src/site/markdown/filesystem/iostatistics.md ## @@ -0,0 +1,432 @@ + + +# Statistic collection

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2069: HADOOP-16830. IOStatistics API.

2020-07-07 Thread GitBox
mukund-thakur commented on a change in pull request #2069: URL: https://github.com/apache/hadoop/pull/2069#discussion_r450904423 ## File path: hadoop-common-project/hadoop-common/src/site/markdown/filesystem/iostatistics.md ## @@ -0,0 +1,432 @@ + + +# Statistic collection

[jira] [Updated] (HADOOP-17113) Adding ReadAhead Counters in ABFS

2020-07-07 Thread Mehakmeet Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh updated HADOOP-17113: - Component/s: fs/azure Description: Adding ReadAheads Counters in ABFS to track the

[jira] [Updated] (HADOOP-17113) Adding ReadAhead Counters in ABFS

2020-07-07 Thread Mehakmeet Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh updated HADOOP-17113: - Affects Version/s: 3.3.0 > Adding ReadAhead Counters in ABFS >

[jira] [Updated] (HADOOP-17113) Adding ReadAhead Counters in ABFS

2020-07-07 Thread Mehakmeet Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh updated HADOOP-17113: - Summary: Adding ReadAhead Counters in ABFS (was: Adding ReadAhead ) > Adding

[jira] [Assigned] (HADOOP-17113) Adding ReadAhead Counters in ABFS

2020-07-07 Thread Mehakmeet Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehakmeet Singh reassigned HADOOP-17113: Assignee: Mehakmeet Singh > Adding ReadAhead Counters in ABFS >

[jira] [Created] (HADOOP-17113) Adding ReadAhead

2020-07-07 Thread Mehakmeet Singh (Jira)
Mehakmeet Singh created HADOOP-17113: Summary: Adding ReadAhead Key: HADOOP-17113 URL: https://issues.apache.org/jira/browse/HADOOP-17113 Project: Hadoop Common Issue Type: Improvement

[GitHub] [hadoop] hadoop-yetus commented on pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#issuecomment-654735425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 21m

[GitHub] [hadoop] hadoop-yetus commented on pull request #2097: HADOOP-17088. Failed to load Xinclude files with relative path in cas…

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2097: URL: https://github.com/apache/hadoop/pull/2097#issuecomment-654730841 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 26m

[GitHub] [hadoop] crossfire commented on a change in pull request #2097: HADOOP-17088. Failed to load Xinclude files with relative path in cas…

2020-07-07 Thread GitBox
crossfire commented on a change in pull request #2097: URL: https://github.com/apache/hadoop/pull/2097#discussion_r450710197 ## File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java ## @@ -1062,6 +1062,38 @@ public void

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2113: HADOOP-17105: S3AFS - Do not attempt to resolve symlinks in globStatus

2020-07-07 Thread GitBox
mukund-thakur commented on a change in pull request #2113: URL: https://github.com/apache/hadoop/pull/2113#discussion_r450705856 ## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileOperationCost.java ## @@ -574,4 +574,48 @@ public void

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2038: HADOOP-17022 Tune S3AFileSystem.listFiles() api.

2020-07-07 Thread GitBox
mukund-thakur commented on a change in pull request #2038: URL: https://github.com/apache/hadoop/pull/2038#discussion_r450676043 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java ## @@ -4181,79 +4181,114 @@ public

[GitHub] [hadoop] hadoop-yetus commented on pull request #2037: HDFS-14984. HDFS setQuota: Error message should be added for invalid …

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2037: URL: https://github.com/apache/hadoop/pull/2037#issuecomment-654652151 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 25m

[GitHub] [hadoop] hadoop-yetus commented on pull request #2073: HADOOP-16998 WASB : NativeAzureFsOutputStream#close() throwing java.l…

2020-07-07 Thread GitBox
hadoop-yetus commented on pull request #2073: URL: https://github.com/apache/hadoop/pull/2073#issuecomment-654641695 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 25m

[GitHub] [hadoop] fengnanli edited a comment on pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
fengnanli edited a comment on pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#issuecomment-653946194 Thanks very much @sunchao @goiri @Hexiaoqiao for the detailed review. I have addressed all comments and please give it another look.

[GitHub] [hadoop] fengnanli commented on pull request #2110: HDFS-15447 RBF: Add top real owners metrics for delegation tokens

2020-07-07 Thread GitBox
fengnanli commented on pull request #2110: URL: https://github.com/apache/hadoop/pull/2110#issuecomment-654625072 I didn't know I have to click `resolve conversation` to publish the reply. Just resolved all of the comments.