[GitHub] [hadoop] sumangala-patki commented on pull request #2344: Hadoop 17265
sumangala-patki commented on pull request #2344: URL: https://github.com/apache/hadoop/pull/2344#issuecomment-699746628 ``` TEST RESULTS HNS-enabled account: With Authentication Type: OAuth [INFO] Results: [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 458, Failures: 0, Errors: 0, Skipped: 75 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140 With Authentication Type: SharedKey [INFO] Results: [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 458, Failures: 0, Errors: 0, Skipped: 75 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140 Non-HNS account: With Authentication Type: OAuth [INFO] Results: [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 458, Failures: 0, Errors: 0, Skipped: 75 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140 With Authentication Type: SharedKey [INFO] Results: [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 458, Failures: 0, Errors: 0, Skipped: 75 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17288) Use shaded guava from thirdparty
[ https://issues.apache.org/jira/browse/HADOOP-17288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202980#comment-17202980 ] Wei-Chiu Chuang commented on HADOOP-17288: -- We need to ensure no public API breakage. There will be applications using Hadoop internal APIs and they will likely break. We need to understand the impact of change. > Use shaded guava from thirdparty > > > Key: HADOOP-17288 > URL: https://issues.apache.org/jira/browse/HADOOP-17288 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Use the shaded version of guava in hadoop-thirdparty -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] sumangala-patki opened a new pull request #2344: Hadoop 17265
sumangala-patki opened a new pull request #2344: URL: https://github.com/apache/hadoop/pull/2344 This PR introduces a client-provided identifier to correlate all the filesystem requests generated by the client session. A client session here could be interacting with multiple storage accounts and hence multiple ABFS filesystem instances. Hence, a unique ID needs to be passed across all the filesystem instances. The client correlation-id appears in the client request header and is visible in the azure storage diagnostic logs. Tests include checks to ensure that the requests do not fail due to invalid inputs for the correlation Id. They also verify that the response header for the client request id contains this identifier if valid, and replaced with an empty string if invalid. The format for the client request header has been changed to client-correlation-id:client-request-id. We include tests for each of valid, invalid and empty strings as input for the correlation id. Validation checks for client correlation id configuration: A valid client correlation id is a string comprising only alphanumeric characters and/or hyphens. The string can be empty, but should not exceed 65 characters in length. If found invalid, an empty string is passed to the configuration instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17287) Support new Instance by non default constructor by ReflectionUtils
[ https://issues.apache.org/jira/browse/HADOOP-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maobaolong updated HADOOP-17287: Target Version/s: 3.2.1, 3.2.2, 3.4.0 (was: 3.4.0) > Support new Instance by non default constructor by ReflectionUtils > -- > > Key: HADOOP-17287 > URL: https://issues.apache.org/jira/browse/HADOOP-17287 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.4.0 >Reporter: maobaolong >Assignee: maobaolong >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15955) declare that fs.s3a.ext. is a prefix for arbitrary extensions
[ https://issues.apache.org/jira/browse/HADOOP-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maobaolong updated HADOOP-15955: Target Version/s: 3.4.0 (was: 3.2.1) > declare that fs.s3a.ext. is a prefix for arbitrary extensions > - > > Key: HADOOP-15955 > URL: https://issues.apache.org/jira/browse/HADOOP-15955 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.2.0 >Reporter: Steve Loughran >Priority: Trivial > > it turns out to be useful to use per-bucket config extensions for things like > delegation tokens. > To avoid third-party extensions to pollute the fs.s3a. namespace with their > own config options (So meaning its inevitable things break when we add some > new fs option), I propose the following policy > # applications/extensions MUST NOT add their own config options under fs.s3a. > # anyone is free to use "fs.s3a.ext.$product." options in s3a. > # we promise not to go near those options in the S3A module > # it is left to people who add their own settings here to avoid clashing with > others, This is why you should use a unique product name > With this specified (where?) then if someone uses some fs.s3a. option which > gets broken by an updated s3a connector, well, we say "wontfix", —and indeed, > get to tell them off for doing this. > Propose: similar for the other stores -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15955) declare that fs.s3a.ext. is a prefix for arbitrary extensions
[ https://issues.apache.org/jira/browse/HADOOP-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maobaolong updated HADOOP-15955: Target Version/s: 3.2.1 (was: 3.2.1, 3.3.1, 3.4.0, 3.2.3) > declare that fs.s3a.ext. is a prefix for arbitrary extensions > - > > Key: HADOOP-15955 > URL: https://issues.apache.org/jira/browse/HADOOP-15955 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.2.0 >Reporter: Steve Loughran >Priority: Trivial > > it turns out to be useful to use per-bucket config extensions for things like > delegation tokens. > To avoid third-party extensions to pollute the fs.s3a. namespace with their > own config options (So meaning its inevitable things break when we add some > new fs option), I propose the following policy > # applications/extensions MUST NOT add their own config options under fs.s3a. > # anyone is free to use "fs.s3a.ext.$product." options in s3a. > # we promise not to go near those options in the S3A module > # it is left to people who add their own settings here to avoid clashing with > others, This is why you should use a unique product name > With this specified (where?) then if someone uses some fs.s3a. option which > gets broken by an updated s3a connector, well, we say "wontfix", —and indeed, > get to tell them off for doing this. > Propose: similar for the other stores -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15955) declare that fs.s3a.ext. is a prefix for arbitrary extensions
[ https://issues.apache.org/jira/browse/HADOOP-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maobaolong updated HADOOP-15955: Target Version/s: 3.2.1, 3.3.1, 3.4.0, 3.2.3 (was: 3.4.0) > declare that fs.s3a.ext. is a prefix for arbitrary extensions > - > > Key: HADOOP-15955 > URL: https://issues.apache.org/jira/browse/HADOOP-15955 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.2.0 >Reporter: Steve Loughran >Priority: Trivial > > it turns out to be useful to use per-bucket config extensions for things like > delegation tokens. > To avoid third-party extensions to pollute the fs.s3a. namespace with their > own config options (So meaning its inevitable things break when we add some > new fs option), I propose the following policy > # applications/extensions MUST NOT add their own config options under fs.s3a. > # anyone is free to use "fs.s3a.ext.$product." options in s3a. > # we promise not to go near those options in the S3A module > # it is left to people who add their own settings here to avoid clashing with > others, This is why you should use a unique product name > With this specified (where?) then if someone uses some fs.s3a. option which > gets broken by an updated s3a connector, well, we say "wontfix", —and indeed, > get to tell them off for doing this. > Propose: similar for the other stores -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17289) ABFS: Testcase failure ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
[ https://issues.apache.org/jira/browse/HADOOP-17289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17289: Labels: pull-request-available (was: ) > ABFS: Testcase failure > ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics > > > Key: HADOOP-17289 > URL: https://issues.apache.org/jira/browse/HADOOP-17289 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.4.0 >Reporter: Bilahari T H >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The test case is failing when the fs.azure.test.appendblob.enabled=true. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17289) ABFS: Testcase failure ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
[ https://issues.apache.org/jira/browse/HADOOP-17289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilahari T H updated HADOOP-17289: -- Status: Patch Available (was: Open) > ABFS: Testcase failure > ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics > > > Key: HADOOP-17289 > URL: https://issues.apache.org/jira/browse/HADOOP-17289 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.4.0 >Reporter: Bilahari T H >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The test case is failing when the fs.azure.test.appendblob.enabled=true. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17289) ABFS: Testcase failure ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
[ https://issues.apache.org/jira/browse/HADOOP-17289?focusedWorklogId=491744=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491744 ] ASF GitHub Bot logged work on HADOOP-17289: --- Author: ASF GitHub Bot Created on: 27/Sep/20 19:59 Start Date: 27/Sep/20 19:59 Worklog Time Spent: 10m Work Description: bilaharith opened a new pull request #2343: URL: https://github.com/apache/hadoop/pull/2343 Currently the test does not work when the fs.azure.test.appendblob.enabled=true. Fix: By making the expected calls number relative to the number of calls before the actual operations are made. **Driver test results against taccounts in Central India region** HNS-OAuth-AppendBlobTrue [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 73 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24 HNS-OAuth-AppendBlobFalse [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 73 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24 HNS-SharedKey-AppendBlobTrue [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 33 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16 HNS-SharedKey-AppendBlobFalse [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 33 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16 NonHNS-SharedKey [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 245 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 491744) Remaining Estimate: 0h Time Spent: 10m > ABFS: Testcase failure > ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics > > > Key: HADOOP-17289 > URL: https://issues.apache.org/jira/browse/HADOOP-17289 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.4.0 >Reporter: Bilahari T H >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The test case is failing when the fs.azure.test.appendblob.enabled=true. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] bilaharith opened a new pull request #2343: HADOOP-17289 ABFS: Fixing the test case ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
bilaharith opened a new pull request #2343: URL: https://github.com/apache/hadoop/pull/2343 Currently the test does not work when the fs.azure.test.appendblob.enabled=true. Fix: By making the expected calls number relative to the number of calls before the actual operations are made. **Driver test results against taccounts in Central India region** HNS-OAuth-AppendBlobTrue [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 73 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24 HNS-OAuth-AppendBlobFalse [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 73 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24 HNS-SharedKey-AppendBlobTrue [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 33 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16 HNS-SharedKey-AppendBlobFalse [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 33 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16 NonHNS-SharedKey [INFO] Results: [INFO] [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [INFO] Results: [INFO] [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 245 [INFO] Results: [INFO] [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17289) ABFS: Testcase failure ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
[ https://issues.apache.org/jira/browse/HADOOP-17289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilahari T H updated HADOOP-17289: -- Summary: ABFS: Testcase failure ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics (was: ABFS: Fixing the testcase ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics) > ABFS: Testcase failure > ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics > > > Key: HADOOP-17289 > URL: https://issues.apache.org/jira/browse/HADOOP-17289 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure >Affects Versions: 3.4.0 >Reporter: Bilahari T H >Priority: Minor > > The test case is failing when the fs.azure.test.appendblob.enabled=true. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-17289) ABFS: Fixing the testcase ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics
Bilahari T H created HADOOP-17289: - Summary: ABFS: Fixing the testcase ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics Key: HADOOP-17289 URL: https://issues.apache.org/jira/browse/HADOOP-17289 Project: Hadoop Common Issue Type: Sub-task Components: fs/azure Affects Versions: 3.4.0 Reporter: Bilahari T H The test case is failing when the fs.azure.test.appendblob.enabled=true. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17288) Use shaded guava from thirdparty
[ https://issues.apache.org/jira/browse/HADOOP-17288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17288: Labels: pull-request-available (was: ) > Use shaded guava from thirdparty > > > Key: HADOOP-17288 > URL: https://issues.apache.org/jira/browse/HADOOP-17288 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Use the shaded version of guava in hadoop-thirdparty -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn opened a new pull request #2342: HADOOP-17288. Use shaded guava from thirdparty.
ayushtkn opened a new pull request #2342: URL: https://github.com/apache/hadoop/pull/2342 https://issues.apache.org/jira/browse/HADOOP-17288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17288) Use shaded guava from thirdparty
[ https://issues.apache.org/jira/browse/HADOOP-17288?focusedWorklogId=491728=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491728 ] ASF GitHub Bot logged work on HADOOP-17288: --- Author: ASF GitHub Bot Created on: 27/Sep/20 17:08 Start Date: 27/Sep/20 17:08 Worklog Time Spent: 10m Work Description: ayushtkn opened a new pull request #2342: URL: https://github.com/apache/hadoop/pull/2342 https://issues.apache.org/jira/browse/HADOOP-17288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 491728) Remaining Estimate: 0h Time Spent: 10m > Use shaded guava from thirdparty > > > Key: HADOOP-17288 > URL: https://issues.apache.org/jira/browse/HADOOP-17288 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Use the shaded version of guava in hadoop-thirdparty -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-17288) Use shaded guava from thirdparty
Ayush Saxena created HADOOP-17288: - Summary: Use shaded guava from thirdparty Key: HADOOP-17288 URL: https://issues.apache.org/jira/browse/HADOOP-17288 Project: Hadoop Common Issue Type: Sub-task Reporter: Ayush Saxena Assignee: Ayush Saxena Use the shaded version of guava in hadoop-thirdparty -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17287) Support new Instance by non default constructor by ReflectionUtils
[
https://issues.apache.org/jira/browse/HADOOP-17287?focusedWorklogId=491710=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491710
]
ASF GitHub Bot logged work on HADOOP-17287:
---
Author: ASF GitHub Bot
Created on: 27/Sep/20 15:25
Start Date: 27/Sep/20 15:25
Worklog Time Spent: 10m
Work Description: maobaolong commented on a change in pull request #2341:
URL: https://github.com/apache/hadoop/pull/2341#discussion_r495583929
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ReflectionUtils.java
##
@@ -124,15 +124,29 @@ private static void setJobConf(Object theObject,
Configuration conf) {
*/
@SuppressWarnings("unchecked")
public static T newInstance(Class theClass, Configuration conf) {
+return newInstance(theClass, conf, EMPTY_ARRAY);
+ }
+
+ /** Create an object for the given class and initialize it from conf
+ *
+ * @param theClass class of which an object is created
+ * @param conf Configuration
+ * @param argsType the types of the arguments
+ * @param values the values of the arguments
+ * @return a new object
+ */
+ @SuppressWarnings("unchecked")
+ public static T newInstance(Class theClass, Configuration conf,
+ Class[] argsType, Object ... values) {
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 491710)
Time Spent: 50m (was: 40m)
> Support new Instance by non default constructor by ReflectionUtils
> --
>
> Key: HADOOP-17287
> URL: https://issues.apache.org/jira/browse/HADOOP-17287
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: maobaolong
>Assignee: maobaolong
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-17287) Support new Instance by non default constructor by ReflectionUtils
[
https://issues.apache.org/jira/browse/HADOOP-17287?focusedWorklogId=491709=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491709
]
ASF GitHub Bot logged work on HADOOP-17287:
---
Author: ASF GitHub Bot
Created on: 27/Sep/20 15:25
Start Date: 27/Sep/20 15:25
Worklog Time Spent: 10m
Work Description: maobaolong commented on a change in pull request #2341:
URL: https://github.com/apache/hadoop/pull/2341#discussion_r495583920
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ReflectionUtils.java
##
@@ -124,15 +124,29 @@ private static void setJobConf(Object theObject,
Configuration conf) {
*/
@SuppressWarnings("unchecked")
public static T newInstance(Class theClass, Configuration conf) {
+return newInstance(theClass, conf, EMPTY_ARRAY);
+ }
+
+ /** Create an object for the given class and initialize it from conf
+ *
+ * @param theClass class of which an object is created
+ * @param conf Configuration
+ * @param argsType the types of the arguments
+ * @param values the values of the arguments
+ * @return a new object
+ */
+ @SuppressWarnings("unchecked")
+ public static T newInstance(Class theClass, Configuration conf,
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 491709)
Time Spent: 40m (was: 0.5h)
> Support new Instance by non default constructor by ReflectionUtils
> --
>
> Key: HADOOP-17287
> URL: https://issues.apache.org/jira/browse/HADOOP-17287
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: maobaolong
>Assignee: maobaolong
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] maobaolong commented on a change in pull request #2341: HADOOP-17287. Support new Instance by non default constructor by ReflectionUtils
maobaolong commented on a change in pull request #2341:
URL: https://github.com/apache/hadoop/pull/2341#discussion_r495583920
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ReflectionUtils.java
##
@@ -124,15 +124,29 @@ private static void setJobConf(Object theObject,
Configuration conf) {
*/
@SuppressWarnings("unchecked")
public static T newInstance(Class theClass, Configuration conf) {
+return newInstance(theClass, conf, EMPTY_ARRAY);
+ }
+
+ /** Create an object for the given class and initialize it from conf
+ *
+ * @param theClass class of which an object is created
+ * @param conf Configuration
+ * @param argsType the types of the arguments
+ * @param values the values of the arguments
+ * @return a new object
+ */
+ @SuppressWarnings("unchecked")
+ public static T newInstance(Class theClass, Configuration conf,
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] maobaolong commented on a change in pull request #2341: HADOOP-17287. Support new Instance by non default constructor by ReflectionUtils
maobaolong commented on a change in pull request #2341:
URL: https://github.com/apache/hadoop/pull/2341#discussion_r495583929
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ReflectionUtils.java
##
@@ -124,15 +124,29 @@ private static void setJobConf(Object theObject,
Configuration conf) {
*/
@SuppressWarnings("unchecked")
public static T newInstance(Class theClass, Configuration conf) {
+return newInstance(theClass, conf, EMPTY_ARRAY);
+ }
+
+ /** Create an object for the given class and initialize it from conf
+ *
+ * @param theClass class of which an object is created
+ * @param conf Configuration
+ * @param argsType the types of the arguments
+ * @param values the values of the arguments
+ * @return a new object
+ */
+ @SuppressWarnings("unchecked")
+ public static T newInstance(Class theClass, Configuration conf,
+ Class[] argsType, Object ... values) {
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Resolved] (HADOOP-17278) Shade guava 29.0-jre in hadoop thirdparty
[ https://issues.apache.org/jira/browse/HADOOP-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinayakumar B resolved HADOOP-17278. Fix Version/s: thirdparty-1.1.0 Hadoop Flags: Reviewed Resolution: Fixed Merged to trunk of hadoop-thirdparty > Shade guava 29.0-jre in hadoop thirdparty > - > > Key: HADOOP-17278 > URL: https://issues.apache.org/jira/browse/HADOOP-17278 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Ayush Saxena >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Fix For: thirdparty-1.1.0 > > > Shade guava 27.0-jre in hadoop-thirdparty -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-17280) Service-user cost shouldn't be accumulated to totalDecayedCallCost and totalRawCallCost.
[ https://issues.apache.org/jira/browse/HADOOP-17280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202752#comment-17202752 ] Jinglun commented on HADOOP-17280: -- Hi [~hexiaoqiao] [~tasanuma], could you help reviewing this, thanks very much ! > Service-user cost shouldn't be accumulated to totalDecayedCallCost and > totalRawCallCost. > > > Key: HADOOP-17280 > URL: https://issues.apache.org/jira/browse/HADOOP-17280 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Jinglun >Assignee: Jinglun >Priority: Major > Attachments: HADOOP-17280.001.patch, HADOOP-17280.002.patch, > HADOOP-17280.003.patch, HADOOP-17280.004.patch > > > HADOOP-17165 has introduced a very useful feature: service-user. After this > feature I think we shouldn't add the service-user's cost into > totalDecayedCallCost and totalRawCallCost anymore. Because it may give all > the identities the priority 0(Supposing we have a big service-user). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
