[
https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314414#comment-17314414
]
Viraj Jasani commented on HADOOP-17612:
---
Thanks for inputs [~ayushtkn] [~eolivelli]. Keeping an
virajjasani commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-812976534
Thanks for this PR @ayushtkn . TestBlockRecovery is consistently failing and
fix in-progress here: #2844
Let me see if I can also take up some other flakies or
[
https://issues.apache.org/jira/browse/HADOOP-17619?focusedWorklogId=576524=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576524
]
ASF GitHub Bot logged work on HADOOP-17619:
---
Author: ASF GitHub Bot
qizhu-lucas commented on a change in pull request #2846:
URL: https://github.com/apache/hadoop/pull/2846#discussion_r606750017
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
##
@@ -107,7 +107,7 @@ public
virajjasani commented on a change in pull request #2844:
URL: https://github.com/apache/hadoop/pull/2844#discussion_r606748973
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery2.java
##
@@ -0,0 +1,464 @@
+/*
+
qizhu-lucas commented on pull request #2829:
URL: https://github.com/apache/hadoop/pull/2829#issuecomment-812964703
Thanks @ayushtkn for commit and review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-812963302
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314385#comment-17314385
]
Duo Zhang commented on HADOOP-16206:
[~ahussein] So you suggest we do a benchmark first to get a
[
https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17314362#comment-17314362
]
Ayush Saxena commented on HADOOP-17612:
---
bq. The best we can do as of this point is bump up
[
https://issues.apache.org/jira/browse/HADOOP-17619?focusedWorklogId=576501=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576501
]
ASF GitHub Bot logged work on HADOOP-17619:
---
Author: ASF GitHub Bot
ayushtkn commented on a change in pull request #2846:
URL: https://github.com/apache/hadoop/pull/2846#discussion_r606714993
##
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
##
@@ -107,7 +107,7 @@ public boolean
ayushtkn commented on a change in pull request #2833:
URL: https://github.com/apache/hadoop/pull/2833#discussion_r606714508
##
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
##
@@ -873,6 +873,22 @@
+
+
ayushtkn commented on pull request #2829:
URL: https://github.com/apache/hadoop/pull/2829#issuecomment-812929534
Thanx @qizhu-lucas for the contribution, @Hexiaoqiao for the review.
@qizhu-lucas, I missed your message, sorry.
--
This is an automated message from the Apache Git
ayushtkn merged pull request #2829:
URL: https://github.com/apache/hadoop/pull/2829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ayushtkn commented on a change in pull request #2844:
URL: https://github.com/apache/hadoop/pull/2844#discussion_r606712644
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery1.java
##
@@ -336,191 +322,194 @@
ayushtkn commented on a change in pull request #2831:
URL: https://github.com/apache/hadoop/pull/2831#discussion_r606710952
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerSafeMode.java
##
@@ -640,7 +644,18
hadoop-yetus commented on pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860#issuecomment-812922960
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
ayushtkn commented on pull request #2852:
URL: https://github.com/apache/hadoop/pull/2852#issuecomment-812918934
Apart from the checkstyle issue, changes LGTM.
Removal of code shouldn't bother, it is used in ``validatePaths`` which
won't break by passing the actual dest.
In the
steveloughran commented on pull request #2852:
URL: https://github.com/apache/hadoop/pull/2852#issuecomment-812887968
going to have to pull in people who know more of the distcp code to review
this, in particular, someone needs to understand what the code being removed is
meant to be
[
https://issues.apache.org/jira/browse/HADOOP-17615?focusedWorklogId=576435=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576435
]
ASF GitHub Bot logged work on HADOOP-17615:
---
Author: ASF GitHub Bot
steveloughran commented on pull request #2842:
URL: https://github.com/apache/hadoop/pull/2842#issuecomment-812877682
what's causing the test failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ayushtkn opened a new pull request #2860:
URL: https://github.com/apache/hadoop/pull/2860
Checking HDFS Pre-Commit builds, to get hold of the flaky tests.
Please ignore for reviewing.
If any fix is found for any test, please push directly to the PR, or drop a
comment.
--
This is
hadoop-yetus commented on pull request #2859:
URL: https://github.com/apache/hadoop/pull/2859#issuecomment-812868839
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2856:
URL: https://github.com/apache/hadoop/pull/2856#issuecomment-812863295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
tomscut opened a new pull request #2859:
URL: https://github.com/apache/hadoop/pull/2859
JIRA: [HDFS-15951](https://issues.apache.org/jira/browse/HDFS-15951)
Remove unused parameters in org.apache.hadoop.hdfs.NameNodeProxiesClient.
--
This is an automated message from the Apache
hadoop-yetus commented on pull request #1971:
URL: https://github.com/apache/hadoop/pull/1971#issuecomment-812846675
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2858:
URL: https://github.com/apache/hadoop/pull/2858#issuecomment-812842463
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857#issuecomment-812833238
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
GauthamBanasandra commented on pull request #2858:
URL: https://github.com/apache/hadoop/pull/2858#issuecomment-812832629
This PR fixes a warning reported in PR
https://github.com/apache/hadoop/pull/2792.
```
inotify.proto:35:1: warning: Import hdfs.proto is unused.
```
--
GauthamBanasandra opened a new pull request #2858:
URL: https://github.com/apache/hadoop/pull/2858
* hdfs.proto is imported in inotify.proto
and is unused. Thus, removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
GauthamBanasandra commented on pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857#issuecomment-812820177
We can observe that `Max int64_t + 1` and `Min int64_t` are equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
GauthamBanasandra commented on pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857#issuecomment-812820088
I was able to verify this change using the following standalone C++ program -
```cpp
#include
#include
#include
int main(int argc, char *argv[]) {
GauthamBanasandra commented on pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857#issuecomment-812819946
This PR fixes some warnings reported as part of
https://github.com/apache/hadoop/pull/2792.
```
[ 63%] Building CXX object
GauthamBanasandra opened a new pull request #2857:
URL: https://github.com/apache/hadoop/pull/2857
* There are some instance where
the overflow is deliberately
done in order to get the lower
bound. This results in an
overflow warning.
* We fix this by using the min
34 matches
Mail list logo
