[jira] [Commented] (HADOOP-18393) Hadoop 3.3.2 have CVE cmoing from dependecies

2022-08-04 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575587#comment-17575587 ] Ayush Saxena commented on HADOOP-18393: --- They seems to fixed in the latest versions of

[GitHub] [hadoop] ayushtkn commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-04 Thread GitBox
ayushtkn commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1206059801 I tried with -T1C, and first it failed with: ``` [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.2:yarn (yarn install) on project

[jira] [Created] (HADOOP-18393) Hadoop 3.3.2 have CVE cmoing from dependecies

2022-08-04 Thread suman agrawal (Jira)
suman agrawal created HADOOP-18393: -- Summary: Hadoop 3.3.2 have CVE cmoing from dependecies Key: HADOOP-18393 URL: https://issues.apache.org/jira/browse/HADOOP-18393 Project: Hadoop Common

[GitHub] [hadoop] hadoop-yetus commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1206053471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn merged pull request #4686: HADOOP-17234. Addendum. Add .asf.yaml to allow github and jira integration.

2022-08-04 Thread GitBox
ayushtkn merged PR #4686: URL: https://github.com/apache/hadoop/pull/4686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-17234) Add .asf.yaml to allow github and jira integration

2022-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575536#comment-17575536 ] ASF GitHub Bot commented on HADOOP-17234: - ayushtkn commented on PR #4686: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #4686: HADOOP-17234. Addendum. Add .asf.yaml to allow github and jira integration.

2022-08-04 Thread GitBox
ayushtkn commented on PR #4686: URL: https://github.com/apache/hadoop/pull/4686#issuecomment-1205992430 Thanx @liuml07 for the review!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] virajjasani closed pull request #4671: HDFS-16702. MiniDFSCluster should report cause of exception in assertion error

2022-08-04 Thread GitBox
virajjasani closed pull request #4671: HDFS-16702. MiniDFSCluster should report cause of exception in assertion error URL: https://github.com/apache/hadoop/pull/4671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] virajjasani commented on pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-04 Thread GitBox
virajjasani commented on PR #4705: URL: https://github.com/apache/hadoop/pull/4705#issuecomment-1205982942 For `ITestS3ATemporaryCredentials` test, I have provides these configs: 1. test.fs.s3a.name 2. fs.contract.test.fs.s3a 3. test.sts.endpoint 4. fs.s3a.endpoint 5.

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938385346 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[GitHub] [hadoop] slfan1989 commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-04 Thread GitBox
slfan1989 commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1205954516 @pbacsko Can you help review this PR? I refer to the code of [YARN-9615](https://issues.apache.org/jira/browse/YARN-9615) and the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1205952306 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4662: HDFS-16705. RBF: Support healthMonitor timeout configurable and cache NN and client proxy in NamenodeHeartbeatService

2022-08-04 Thread GitBox
ZanderXu commented on code in PR #4662: URL: https://github.com/apache/hadoop/pull/4662#discussion_r938370708 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -399,13 +356,58 @@ private

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

2022-08-04 Thread GitBox
ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1205937429 The failed UT `org.apache.hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes.testBalancerWithObserverWithFailedNode` works well locally. -- This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1205926396 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1205924672 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4705: URL: https://github.com/apache/hadoop/pull/4705#issuecomment-1205922126 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4695: URL: https://github.com/apache/hadoop/pull/4695#issuecomment-1205911230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4704: HADOOP-18392. Propagate vectored s3a input stream stats to file system stats.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4704: URL: https://github.com/apache/hadoop/pull/4704#issuecomment-1205910824 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938345043 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938344693 ##

[GitHub] [hadoop] goiri commented on a diff in pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
goiri commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938339570 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[GitHub] [hadoop] slfan1989 commented on pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
slfan1989 commented on PR #4695: URL: https://github.com/apache/hadoop/pull/4695#issuecomment-1205881341 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
slfan1989 commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1205881226 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938321651 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938321356 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[GitHub] [hadoop] virajjasani commented on pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-04 Thread GitBox
virajjasani commented on PR #4705: URL: https://github.com/apache/hadoop/pull/4705#issuecomment-1205862908 For `ITestS3ATemporaryCredentials` test, I have provides these configs: 1. test.fs.s3a.name 2. fs.contract.test.fs.s3a 3. test.sts.endpoint 4. fs.s3a.endpoint 5.

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938305994 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r938304186 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java: ## @@ -101,4

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r938303936 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java: ## @@ -52,7

[GitHub] [hadoop] hadoop-yetus commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1205842675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Assigned] (HADOOP-18073) Upgrade AWS SDK to v2

2022-08-04 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur reassigned HADOOP-18073: -- Assignee: Ahmar Suhail > Upgrade AWS SDK to v2 > - > >

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-08-04 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575469#comment-17575469 ] Mukund Thakur commented on HADOOP-18073: [~ahmarsu]  

[GitHub] [hadoop] hadoop-yetus commented on pull request #4699: HDFS-16717. Replace NPE with IOException in DataNode.class

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4699: URL: https://github.com/apache/hadoop/pull/4699#issuecomment-1205797255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4699: HDFS-16717. Replace NPE with IOException in DataNode.class

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4699: URL: https://github.com/apache/hadoop/pull/4699#issuecomment-1205794926 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4703: URL: https://github.com/apache/hadoop/pull/4703#issuecomment-1205789560 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file w…

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4697: URL: https://github.com/apache/hadoop/pull/4697#issuecomment-1205788195 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] KevinWikant commented on pull request #4568: HDFS-16664. Use correct GenerationStamp when invalidating corrupt block replicas

2022-08-04 Thread GitBox
KevinWikant commented on PR #4568: URL: https://github.com/apache/hadoop/pull/4568#issuecomment-1205781950 Hey Xiaohui, appreciate you taking the time to review this :) Just wanted to clarify a few things: ``` This is a complete unnecessary change. It was mentioned in your

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #4690: HADOOP-18181. Move prefetch common classes to hadoop common

2022-08-04 Thread GitBox
mukund-thakur commented on code in PR #4690: URL: https://github.com/apache/hadoop/pull/4690#discussion_r938221909 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockOperations.java: ## @@ -163,61 +163,61 @@ private synchronized

[jira] [Assigned] (HADOOP-18142) Increase precommit job timeout from 24 hr to 30 hr

2022-08-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18142: - Assignee: (was: Viraj Jasani) > Increase precommit job timeout from 24 hr to 30

[GitHub] [hadoop] virajjasani commented on pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-04 Thread GitBox
virajjasani commented on PR #4705: URL: https://github.com/apache/hadoop/pull/4705#issuecomment-1205757927 The above mentioned 5 errors with "No AWS credentials" is not relevant to this change, they appear even without this patch. I have provided `export AWS_ACCESS_KEY_ID=

[GitHub] [hadoop] virajjasani commented on pull request #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-04 Thread GitBox
virajjasani commented on PR #4705: URL: https://github.com/apache/hadoop/pull/4705#issuecomment-1205754299 Tested against `us-west-2` endpoint: ``` mvn -Dparallel-tests -DtestsThreadCount=8 clean verify [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time

[jira] [Updated] (HADOOP-18373) IOStatisticsContext tuning

2022-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18373: Labels: pull-request-available (was: ) > IOStatisticsContext tuning >

[GitHub] [hadoop] virajjasani opened a new pull request, #4705: HADOOP-18373. IOStatisticsContext tuning

2022-08-04 Thread GitBox
virajjasani opened a new pull request, #4705: URL: https://github.com/apache/hadoop/pull/4705 ### Description of PR Tuning of the IOStatisticsContext code change property name to "fs.iostatistics" for consistent naming Edit core-site.xml to always collect context

[jira] [Updated] (HADOOP-18392) Propagate vectored s3a input stream stats to file system stats.

2022-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18392: Labels: pull-request-available (was: ) > Propagate vectored s3a input stream stats to

[GitHub] [hadoop] mukund-thakur opened a new pull request, #4704: HADOOP-18392. Propagate vectored s3a input stream stats to file system stats.

2022-08-04 Thread GitBox
mukund-thakur opened a new pull request, #4704: URL: https://github.com/apache/hadoop/pull/4704 ### Description of PR Propagate vectored s3a input stream stats to file system stats. ### How was this patch tested? Re-ran the vectored io tests using us-east-1 endpoint.

[jira] [Commented] (HADOOP-11867) Add a high-performance vectored read API.

2022-08-04 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575438#comment-17575438 ] Mukund Thakur commented on HADOOP-11867: {quote} * the position returned by getPosl; is

[jira] [Commented] (HADOOP-11867) Add a high-performance vectored read API.

2022-08-04 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575437#comment-17575437 ] Mukund Thakur commented on HADOOP-11867: Okay sure. You mean in the java doc and

[GitHub] [hadoop] hadoop-yetus commented on pull request #4692: HADOOP-18365. Update the remote address when a change is detected

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4692: URL: https://github.com/apache/hadoop/pull/4692#issuecomment-1205701836 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-18392) Propagate vectored s3a input stream stats to file system stats.

2022-08-04 Thread Mukund Thakur (Jira)
Mukund Thakur created HADOOP-18392: -- Summary: Propagate vectored s3a input stream stats to file system stats. Key: HADOOP-18392 URL: https://issues.apache.org/jira/browse/HADOOP-18392 Project:

[GitHub] [hadoop] XiaohuiSun1 commented on pull request #4568: HDFS-16664. Use correct GenerationStamp when invalidating corrupt block replicas

2022-08-04 Thread GitBox
XiaohuiSun1 commented on PR #4568: URL: https://github.com/apache/hadoop/pull/4568#issuecomment-1205691070 -1 (Sorry for coming up so straight). This is a complete unnecessary change. It was mentioned in your last JIRA HDFS-16064 by

[GitHub] [hadoop] hadoop-yetus commented on pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4693: URL: https://github.com/apache/hadoop/pull/4693#issuecomment-1205690140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1205687962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4568: HDFS-16664. Use correct GenerationStamp when invalidating corrupt block replicas

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4568: URL: https://github.com/apache/hadoop/pull/4568#issuecomment-1205655180 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4695: URL: https://github.com/apache/hadoop/pull/4695#issuecomment-1205615307 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4695: URL: https://github.com/apache/hadoop/pull/4695#issuecomment-1205611071 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #4703: YARN-11241. Add uncleaning option for local app log file with log-aggregation enabled

2022-08-04 Thread GitBox
ashutoshcipher opened a new pull request, #4703: URL: https://github.com/apache/hadoop/pull/4703 ### Description of PR Add uncleaning option for local app log file with log-aggregation enabled JIRA - YARN-11241 ### How was this patch tested? Unit test ###

[GitHub] [hadoop] hadoop-yetus commented on pull request #4702: HADOOP-18366. Fix ITestS3Select.testSelectSeekFullLandsat is timing out.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4702: URL: https://github.com/apache/hadoop/pull/4702#issuecomment-1205608372 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4701: YARN-10885. Make FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1205605201 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18391) harden VectoredReadUtils

2022-08-04 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575387#comment-17575387 ] Mukund Thakur commented on HADOOP-18391: {quote}VectoredReadUtils.readInDirectBuffer should

[GitHub] [hadoop] ashutoshcipher commented on pull request #4539: HADOOP-17649. Update wildfly openssl to 2.2.1.Final

2022-08-04 Thread GitBox
ashutoshcipher commented on PR #4539: URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1205575082 I am testing this on: ``` System Version: macOS 12.4 (21F79) Kernel Version: Darwin 21.5.0 ``` -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] goiri commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
goiri commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r938066334 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java: ## @@ -101,4

[GitHub] [hadoop] steveloughran commented on pull request #4539: HADOOP-17649. Update wildfly openssl to 2.2.1.Final

2022-08-04 Thread GitBox
steveloughran commented on PR #4539: URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1205563534 also, be good to know what linux version you are testing on. i will have to test this on a vm before merging too, because the openssl native integration has been brittle in the past

[GitHub] [hadoop] goiri commented on pull request #4662: HDFS-16705. RBF: Support healthMonitor timeout configurable and cache NN and client proxy in NamenodeHeartbeatService

2022-08-04 Thread GitBox
goiri commented on PR #4662: URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1205552322 @slfan1989 you still have comments. Any proposal to fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] sunchao commented on a diff in pull request #4585: HADOOP-18383. Codecs with @DoNotPool annotation are not closed causing memory leak

2022-08-04 Thread GitBox
sunchao commented on code in PR #4585: URL: https://github.com/apache/hadoop/pull/4585#discussion_r938045862 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/AlreadyClosedException.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache

[GitHub] [hadoop] goiri commented on a diff in pull request #4701: YARN-10885. add FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
goiri commented on code in PR #4701: URL: https://github.com/apache/hadoop/pull/4701#discussion_r938061543 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java:

[GitHub] [hadoop] goiri merged pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

2022-08-04 Thread GitBox
goiri merged PR #4656: URL: https://github.com/apache/hadoop/pull/4656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (HADOOP-18391) harden VectoredReadUtils

2022-08-04 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18391: --- Summary: harden VectoredReadUtils Key: HADOOP-18391 URL: https://issues.apache.org/jira/browse/HADOOP-18391 Project: Hadoop Common Issue Type:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4701: YARN-10885. add FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4701: URL: https://github.com/apache/hadoop/pull/4701#issuecomment-1205539070 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4683: HADOOP-18361. Update commons-net from 3.6 to 3.8.0.

2022-08-04 Thread GitBox
slfan1989 commented on PR #4683: URL: https://github.com/apache/hadoop/pull/4683#issuecomment-1205509108 @ayushtkn Can you help review the code? The version of this jar(commons-net) can be upgraded. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-18366) ITestS3Select.testSelectSeekFullLandsat is timing out

2022-08-04 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575356#comment-17575356 ] Ahmar Suhail commented on HADOOP-18366: --- Timeout issue appears to be because of logging. Seek in

[GitHub] [hadoop] slfan1989 commented on pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

2022-08-04 Thread GitBox
slfan1989 commented on PR #4656: URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1205505375 @goiri Thank you for helping to review the code, I will follow up with YARN-11236 after this pr is completed. -- This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (HADOOP-18366) ITestS3Select.testSelectSeekFullLandsat is timing out

2022-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18366: Labels: pull-request-available (was: ) > ITestS3Select.testSelectSeekFullLandsat is

[GitHub] [hadoop] ahmarsuhail opened a new pull request, #4702: HADOOP-18366. Fix ITestS3Select.testSelectSeekFullLandsat is timing out.

2022-08-04 Thread GitBox
ahmarsuhail opened a new pull request, #4702: URL: https://github.com/apache/hadoop/pull/4702 ### Description of PR Reduces the size of the data read to 1MB from the landsat file. Previously we were reading the entire file of ~42MB. ### How was this patch tested?

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
slfan1989 commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r937372323 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4695: URL: https://github.com/apache/hadoop/pull/4695#issuecomment-1205456700 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-04 Thread GitBox
slfan1989 commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1205453922 @goiri Can you help review this PR? I refer to the code of YARN-9615 and the YARN-10846 patch to complete this pr. This pr adds some metrics to NM's dispatcher.

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937944582 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/TestAuditTool.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937926001 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditTool.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hadoop] hadoop-yetus commented on pull request #4698: HADOOP-18382. SDK upgrade prerequisites

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4698: URL: https://github.com/apache/hadoop/pull/4698#issuecomment-1205393758 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937910850 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMerger.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937900727 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMerger.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937910850 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMerger.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937903008 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/TestS3AAuditLogMerger.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937908465 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditTool.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hadoop] slfan1989 opened a new pull request, #4701: YARN-10885. add FederationStateStoreFacade#getApplicationHomeSubCluster use JCache.

2022-08-04 Thread GitBox
slfan1989 opened a new pull request, #4701: URL: https://github.com/apache/hadoop/pull/4701 JIRA: YARN-10885. add FederationStateStoreFacade#getApplicationHomeSubCluster use JCache. JunitTest will be added later. -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937906506 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMerger.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937906165 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/TestS3AAuditLogMerger.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937897093 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMergerAndParser.java: ## @@ -0,0 +1,546 @@ +/* + * Licensed to the Apache

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937900247 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMerger.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937899698 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditTool.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937898572 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditTool.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937898011 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditTool.java: ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-04 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r937895338 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/S3AAuditLogMergerAndParser.java: ## @@ -0,0 +1,546 @@ +/* + * Licensed to the Apache

[jira] [Assigned] (HADOOP-18366) ITestS3Select.testSelectSeekFullLandsat is timing out

2022-08-04 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail reassigned HADOOP-18366: - Assignee: Ahmar Suhail > ITestS3Select.testSelectSeekFullLandsat is timing out >

[GitHub] [hadoop] hadoop-yetus commented on pull request #4700: HADOOP-18090 Exclude com/jcraft/jsch classes from being shaded/relocated

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4700: URL: https://github.com/apache/hadoop/pull/4700#issuecomment-1205306830 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] cxzl25 commented on a diff in pull request #4139: HDFS-16524. Add configuration to control blocks deletion asynchronous…

2022-08-04 Thread GitBox
cxzl25 commented on code in PR #4139: URL: https://github.com/apache/hadoop/pull/4139#discussion_r937786349 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3403,6 +3399,33 @@ FSPermissionChecker

[GitHub] [hadoop] hadoop-yetus commented on pull request #4690: HADOOP-18181. Move prefetch common classes to hadoop common

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4690: URL: https://github.com/apache/hadoop/pull/4690#issuecomment-1205260801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4698: HADOOP-18382. SDK upgrade prerequisites

2022-08-04 Thread GitBox
hadoop-yetus commented on PR #4698: URL: https://github.com/apache/hadoop/pull/4698#issuecomment-1205252170 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-08-04 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575259#comment-17575259 ] Ahmar Suhail commented on HADOOP-18073: --- [~ste...@apache.org] / [~mthakur]  could you please

  1   2   >