hadoop-yetus commented on PR #4934:
URL: https://github.com/apache/hadoop/pull/4934#issuecomment-1260414197
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4934:
URL: https://github.com/apache/hadoop/pull/4934#issuecomment-1260413070
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ZanderXu opened a new pull request, #4942:
URL: https://github.com/apache/hadoop/pull/4942
### Description of PR
When patching the fine-grained locking of datanode, found there is a
redundant lock in deepCopyReplica, maybe we can remove it.
--
This is an automated message from
slfan1989 commented on code in PR #4934:
URL: https://github.com/apache/hadoop/pull/4934#discussion_r981835229
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouter.java:
##
@@ -22,17 +22,38
hadoop-yetus commented on PR #4903:
URL: https://github.com/apache/hadoop/pull/4903#issuecomment-1260201727
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610302#comment-17610302
]
ASF GitHub Bot commented on HADOOP-18469:
-
hadoop-yetus commented on PR #4940:
URL:
hadoop-yetus commented on PR #4940:
URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1260197552
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610285#comment-17610285
]
ASF GitHub Bot commented on HADOOP-18463:
-
hadoop-yetus commented on PR #4921:
URL:
hadoop-yetus commented on PR #4921:
URL: https://github.com/apache/hadoop/pull/4921#issuecomment-1260156398
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610250#comment-17610250
]
ASF GitHub Bot commented on HADOOP-18468:
-
hadoop-yetus commented on PR #4937:
URL:
hadoop-yetus commented on PR #4937:
URL: https://github.com/apache/hadoop/pull/4937#issuecomment-1260066722
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4917:
URL: https://github.com/apache/hadoop/pull/4917#issuecomment-1260057240
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4917:
URL: https://github.com/apache/hadoop/pull/4917#issuecomment-1260050489
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #4924:
URL: https://github.com/apache/hadoop/pull/4924#issuecomment-1260032481
@goiri Thank you very much for your help reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
slfan1989 commented on PR #4846:
URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1260032750
@goiri Thank you very much for your help reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
hadoop-yetus commented on PR #4903:
URL: https://github.com/apache/hadoop/pull/4903#issuecomment-1260021980
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri merged PR #4924:
URL: https://github.com/apache/hadoop/pull/4924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
goiri commented on code in PR #4934:
URL: https://github.com/apache/hadoop/pull/4934#discussion_r981683490
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouter.java:
##
@@ -22,17 +22,38 @@
goiri merged PR #4846:
URL: https://github.com/apache/hadoop/pull/4846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
goiri commented on code in PR #4904:
URL: https://github.com/apache/hadoop/pull/4904#discussion_r981681300
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
slfan1989 commented on PR #4846:
URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1259987263
@goiri Can you help merge this pr into trunk branch? Thank you very much!
after this pr is completed, I will submit a new pr to clean up the completed
application in the router's
slfan1989 commented on PR #4934:
URL: https://github.com/apache/hadoop/pull/4934#issuecomment-1259976845
@goiri Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hadoop-yetus commented on PR #4941:
URL: https://github.com/apache/hadoop/pull/4941#issuecomment-1259926904
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[ https://issues.apache.org/jira/browse/HADOOP-18467 ]
Martin Filla deleted comment on HADOOP-18467:
---
was (Author: JIRAUSER296140):
I looked to repository
[
https://issues.apache.org/jira/browse/HADOOP-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610186#comment-17610186
]
Martin Filla edited comment on HADOOP-18467 at 9/27/22 6:20 PM:
I
[
https://issues.apache.org/jira/browse/HADOOP-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610186#comment-17610186
]
Martin Filla commented on HADOOP-18467:
---
I lookefd to repository
[
https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610183#comment-17610183
]
ASF GitHub Bot commented on HADOOP-18469:
-
pjfanning commented on PR #4940:
URL:
pjfanning commented on PR #4940:
URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1259867954
@steveloughran I can rework this to just have the hadoop-common changes and
can do other PRs to uptake this in yarn, hdfs, etc.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610177#comment-17610177
]
Steve Loughran commented on HADOOP-18073:
-
ok, what changes do you want in the branch? a list
[
https://issues.apache.org/jira/browse/HADOOP-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610169#comment-17610169
]
Steve Loughran commented on HADOOP-18467:
-
maybe its the way we use maven to fetch protoc,
susheel-gupta opened a new pull request, #4941:
URL: https://github.com/apache/hadoop/pull/4941
### Description of PR
Revisit try blocks without catch blocks but having finally blocks for
logging of uncaught exceptions throughout SLS.
### How was this patch tested?
[
https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610146#comment-17610146
]
Mukund Thakur commented on HADOOP-18470:
https://github.com/apache/hadoop/tree/branch-3.3.5
>
[
https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18470:
Component/s: build
> Release hadoop 3.3.5
>
>
>
[
https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18470:
Affects Version/s: 3.3.5
> Release hadoop 3.3.5
>
>
>
[
https://issues.apache.org/jira/browse/HADOOP-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukund Thakur reassigned HADOOP-18470:
--
Assignee: Mukund Thakur
> Release hadoop 3.3.5
>
>
>
[
https://issues.apache.org/jira/browse/HADOOP-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610129#comment-17610129
]
ASF GitHub Bot commented on HADOOP-18347:
-
mukund-thakur merged PR #4918:
URL:
mukund-thakur merged PR #4918:
URL: https://github.com/apache/hadoop/pull/4918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #4936:
URL: https://github.com/apache/hadoop/pull/4936#issuecomment-1259692160
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Mukund Thakur created HADOOP-18470:
--
Summary: Release hadoop 3.3.5
Key: HADOOP-18470
URL: https://issues.apache.org/jira/browse/HADOOP-18470
Project: Hadoop Common
Issue Type: New Feature
slfan1989 commented on PR #4939:
URL: https://github.com/apache/hadoop/pull/4939#issuecomment-1259619279
@goiri Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hadoop-yetus commented on PR #4936:
URL: https://github.com/apache/hadoop/pull/4936#issuecomment-1259580336
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
hadoop-yetus commented on PR #4936:
URL: https://github.com/apache/hadoop/pull/4936#issuecomment-1259571440
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
[
https://issues.apache.org/jira/browse/HADOOP-18416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610047#comment-17610047
]
ASF GitHub Bot commented on HADOOP-18416:
-
mehakmeet commented on PR #4931:
URL:
mehakmeet commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1259483553
@steveloughran Noted. Wanted to double-check since this has a commented-out
bit from the trunk changes. Wanted to see if this was within the coding
standard(having a TODO comment in
[
https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PJ Fanning updated HADOOP-18469:
Summary: Add XMLUtils methods to centralise code that creates secure XML
parsers (was: Add an
[
https://issues.apache.org/jira/browse/HADOOP-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610025#comment-17610025
]
Martijn Visser commented on HADOOP-18440:
-
I cam across this ticket accidentally, let me know
[
https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17610014#comment-17610014
]
ASF GitHub Bot commented on HADOOP-18469:
-
pjfanning opened a new pull request, #4940:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18469:
Labels: pull-request-available (was: )
> Add an XMLUtils method to centralise code that
pjfanning opened a new pull request, #4940:
URL: https://github.com/apache/hadoop/pull/4940
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g.
[
https://issues.apache.org/jira/browse/HADOOP-17705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prabhu Joseph updated HADOOP-17705:
---
Description:
Currently, AWS region is either constructed via the endpoint URL, by making
[
https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609997#comment-17609997
]
ASF GitHub Bot commented on HADOOP-18073:
-
ahmarsuhail closed pull request #4706: HADOOP-18073.
[
https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609996#comment-17609996
]
ASF GitHub Bot commented on HADOOP-18073:
-
ahmarsuhail commented on PR #4706:
URL:
ahmarsuhail closed pull request #4706: HADOOP-18073. Adds in s3 client config
and updates list.
URL: https://github.com/apache/hadoop/pull/4706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ahmarsuhail commented on PR #4706:
URL: https://github.com/apache/hadoop/pull/4706#issuecomment-1259367384
closing this, these changes will be part of a new PR I'll open once the
feature branch is in sync with trunk.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609994#comment-17609994
]
Ahmar Suhail commented on HADOOP-18073:
---
[~ste...@apache.org] / [~mthakur] , this [feature
hadoop-yetus commented on PR #4938:
URL: https://github.com/apache/hadoop/pull/4938#issuecomment-1259335732
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PJ Fanning updated HADOOP-18469:
Summary: Add an XMLUtils method to centralise code that creates secure XML
parsers (was: Add an
[
https://issues.apache.org/jira/browse/HADOOP-18463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609979#comment-17609979
]
ASF GitHub Bot commented on HADOOP-18463:
-
steveloughran commented on code in PR #4921:
URL:
steveloughran commented on code in PR #4921:
URL: https://github.com/apache/hadoop/pull/4921#discussion_r981079747
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractVectoredReadTest.java:
##
@@ -393,39 +392,40 @@ public void
[
https://issues.apache.org/jira/browse/HADOOP-18416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609975#comment-17609975
]
ASF GitHub Bot commented on HADOOP-18416:
-
steveloughran commented on PR #4931:
URL:
steveloughran commented on PR #4931:
URL: https://github.com/apache/hadoop/pull/4931#issuecomment-1259321944
LGTM.
Mehakmeet, you don't need to get a +1 on a simple backport, seeing that
yetus is happy is enough. if it's complicate it is still good to get some
review, but only
navinko commented on code in PR #4917:
URL: https://github.com/apache/hadoop/pull/4917#discussion_r981077780
##
hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRequestHedgingProxyProvider.java:
##
@@ -98,9 +100,10 @@ public
navinko commented on code in PR #4917:
URL: https://github.com/apache/hadoop/pull/4917#discussion_r981076098
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java:
##
@@ -172,8 +172,8 @@ private Configuration initHAConf(URI
hadoop-yetus commented on PR #4938:
URL: https://github.com/apache/hadoop/pull/4938#issuecomment-1259316426
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ZanderXu commented on code in PR #4903:
URL: https://github.com/apache/hadoop/pull/4903#discussion_r981060797
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java:
##
@@ -1891,23 +1894,22 @@ public void
PJ Fanning created HADOOP-18469:
---
Summary: Add an XMLUtils class to centralise code that creates
secure XML parsers
Key: HADOOP-18469
URL: https://issues.apache.org/jira/browse/HADOOP-18469
Project:
ZanderXu commented on PR #4903:
URL: https://github.com/apache/hadoop/pull/4903#issuecomment-1259291182
@haiyang1987 Can you fix the checkStyle first? Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/HADOOP-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sneha Vijayarajan updated HADOOP-17015:
---
Description:
Initially changes were made as part of this PR to handle idempotency
[
https://issues.apache.org/jira/browse/HADOOP-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609911#comment-17609911
]
Sneha Vijayarajan commented on HADOOP-17015:
RENAME Idempotency code is revoked.
Initially
ChenSammi commented on code in PR #4917:
URL: https://github.com/apache/hadoop/pull/4917#discussion_r980927224
##
hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRequestHedgingProxyProvider.java:
##
@@ -98,9 +100,10 @@ public
[
https://issues.apache.org/jira/browse/HADOOP-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Carl Jones updated HADOOP-18352:
---
Summary: Support AWS IAM Identity Centre (prev. AWS SSO) for providing
credentials
ashutoshcipher commented on PR #4886:
URL: https://github.com/apache/hadoop/pull/4886#issuecomment-1259095425
Thanks @aajisaka for reviewing and merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hadoop-yetus commented on PR #4938:
URL: https://github.com/apache/hadoop/pull/4938#issuecomment-1259094092
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #4463:
URL: https://github.com/apache/hadoop/pull/4463#issuecomment-1259065155
@aajisaka Can you help review the code again? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aajisaka merged PR #4886:
URL: https://github.com/apache/hadoop/pull/4886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #4846:
URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1259032015
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
76 matches
Mail list logo
